From: Spencer Baugh <sbaugh@janestreet.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@catern.com, 62621@debbugs.gnu.org
Subject: bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename
Date: Fri, 14 Jul 2023 08:46:00 -0400 [thread overview]
Message-ID: <iercz0uiruf.fsf@janestreet.com> (raw)
In-Reply-To: <83edlafzht.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Jul 2023 15:29:02 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Spencer Baugh <sbaugh@janestreet.com>
>> Cc: sbaugh@catern.com, 62621@debbugs.gnu.org
>> Date: Fri, 14 Jul 2023 08:20:02 -0400
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> I agree, and I'm happy to change it to use a simple symbolic value
>> >> 'project instead for the transform I wrote, but I'm not sure how best to
>> >> handle the dependencies: uniquify.el is in loadup.el, is it OK for it to
>> >> rely on project-uniquify-dirname-transform being autoloaded?
>> >
>> > I don't understand the difficulty. If the function value could be
>> > defined in uniquify.el, why cannot a symbolic value be defined there?
>>
>> I don't understand your question :)
>>
>> Here's concretely the diff I would apply. This makes uniquify.el mention a
>> function from project.el. Is that OK?
>
> No.
I figured. So now you see the issue with the symbolic approach.
If the defcustom just takes a function, though, that solves the
dependency issue. Because the user's config handles taking the function
from project.el and putting it in the variable from uniquify.el.
>> > If the symbolic values are specific to project, simply let-bind
>> > uniquify-dirname-transform to the value of the appropriate project.el
>> > defcustom when project.el calls uniquify.
>>
>> These customizations are in effect all the time, not just when the user
>> is calling a project.el command. e.g. rename-buffer triggers uniquify.
>
> Then you can set the buffer-local value of uniquify-dirname-transform
> in the project.el buffers. Would that solve the problem?
The buffers it should affect are all file-visiting buffers. project.el
doesn't currently have any code which runs for every new buffer. I
guess we've considered adding that, but I'm not sure this is a good
reason...
>> >> Unfortunately, this isn't quite right. uniquify never uses
>> >> default-directory, counterintuitively - by default, it uses the
>> >> directory of buffer-file-name, which can differ from default-directory.
>> >
>> > That's a minor issue, just use "buffer's directory" instead.
>> >
>> > But I wonder why uniquify does something counterintuitive like that.
>>
>> I assume it's something like "default-directory changes (such as by M-x
>> cd) shouldn't change the buffer name too".
>
> default-directory of a file-visiting buffer doesn't change.
I don't think that's true. If I open ~/.emacs.d/init.el then (cd "/")
then default-directory in that file-visiting buffer is / instead of
~/.emacs.d
>> The fact that uniquify doesn't use default-directory also means it's
>> unable to uniquify buffers which aren't visiting files
>
> Exactly.
next prev parent reply other threads:[~2023-07-14 12:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 17:37 bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename Spencer Baugh
2023-04-02 17:57 ` Eli Zaretskii
2023-04-02 21:59 ` Drew Adams
2023-04-02 18:25 ` Juri Linkov
2023-04-14 16:08 ` Spencer Baugh
2023-07-13 22:51 ` sbaugh
2023-07-14 6:29 ` Eli Zaretskii
2023-07-14 11:28 ` sbaugh
2023-07-14 12:01 ` Eli Zaretskii
2023-07-14 12:20 ` Spencer Baugh
2023-07-14 12:29 ` Eli Zaretskii
2023-07-14 12:46 ` Spencer Baugh [this message]
2023-07-14 13:51 ` Eli Zaretskii
2023-07-14 14:14 ` Spencer Baugh
2023-07-14 19:10 ` Eli Zaretskii
2023-07-14 19:15 ` sbaugh
2023-07-15 5:42 ` Eli Zaretskii
2023-07-15 6:20 ` Eli Zaretskii
2023-07-18 0:19 ` Dmitry Gutov
2023-07-18 1:37 ` Dmitry Gutov
2023-07-18 16:03 ` Spencer Baugh
2023-07-19 2:47 ` Dmitry Gutov
2023-07-19 6:56 ` Juri Linkov
2023-07-18 17:51 ` Juri Linkov
2023-07-19 2:24 ` Dmitry Gutov
2023-07-14 16:31 ` Juri Linkov
2023-07-18 0:34 ` Dmitry Gutov
2023-07-18 11:07 ` Eli Zaretskii
2023-07-19 2:22 ` Dmitry Gutov
2023-07-19 12:14 ` Eli Zaretskii
2023-07-19 12:31 ` Spencer Baugh
2023-07-19 13:25 ` Eli Zaretskii
2023-07-21 13:34 ` Spencer Baugh
2023-07-21 14:37 ` Eli Zaretskii
2023-07-22 18:00 ` Spencer Baugh
2023-07-24 19:18 ` Spencer Baugh
2023-07-26 15:18 ` Eli Zaretskii
2023-08-03 8:00 ` Eli Zaretskii
2023-08-03 11:54 ` Spencer Baugh
2023-08-03 14:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=iercz0uiruf.fsf@janestreet.com \
--to=sbaugh@janestreet.com \
--cc=62621@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.