From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: dmitry@gutov.dev, 62621@debbugs.gnu.org, sbaugh@catern.com
Subject: bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename
Date: Wed, 19 Jul 2023 16:25:52 +0300 [thread overview]
Message-ID: <83v8eg3ue7.fsf@gnu.org> (raw)
In-Reply-To: <ierpm4ow0aj.fsf@janestreet.com> (message from Spencer Baugh on Wed, 19 Jul 2023 08:31:00 -0400)
> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: Dmitry Gutov <dmitry@gutov.dev>, sbaugh@catern.com, 62621@debbugs.gnu.org
> Date: Wed, 19 Jul 2023 08:31:00 -0400
>
> >> >>> Repeat after me: Use options whose values are functions
> >> >>> are hard on our users, because they require them to be Lisp
> >> >>> programmers.
> >> >> That doesn't have to be the case. If the defcustom's docstring mentions
> >> >> several functions that can be used, and the :type widget includes them
> >> >> as well, the user can decide to switch to any of them without writing
> >> >> any Lisp (or having to understand the implementations).
> >> > But that was not so in this particular case.
> >>
> >> That's easy to fix, as long as you don't have additional objections to
> >> that approach.
> >
> > I'd need to see the fix first, because I don't think I have a clear
> > idea of what you have in mind.
> >
> > (My objections, btw, where very minor and of pure usability nature.
> > Frankly, I'm surprised such a simple and more-or-less agreed-upon
> > comment got such a long thread of discussing various loosely-related
> > issues.)
>
> Like this:
Thanks, but it still falls short of what Dmitry described above: the
doc string doesn't "mention several functions that can be used".
> +(defcustom uniquify-dirname-transform #'identity
> + "Function to transform buffer's directory for uniquifying its name.
> +
> +It takes a single argument: the directory of the buffer. It
> +should return a string filename (which does not need to actually
> +exist in the filesystem) to use for uniquifying the buffer name."
Please read this carefully and try to put yourself in the shoes of a
user who needs to make sense out of this description. The immediate
question I had is what does "transforming a buffer's directory" have
to do with "uniquifying the buffer name"? Uniquifying a buffer's name
is not about its directory, at least not in general. IOW, the
starting point of this description is too "inside" the implementation.
next prev parent reply other threads:[~2023-07-19 13:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 17:37 bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename Spencer Baugh
2023-04-02 17:57 ` Eli Zaretskii
2023-04-02 21:59 ` Drew Adams
2023-04-02 18:25 ` Juri Linkov
2023-04-14 16:08 ` Spencer Baugh
2023-07-13 22:51 ` sbaugh
2023-07-14 6:29 ` Eli Zaretskii
2023-07-14 11:28 ` sbaugh
2023-07-14 12:01 ` Eli Zaretskii
2023-07-14 12:20 ` Spencer Baugh
2023-07-14 12:29 ` Eli Zaretskii
2023-07-14 12:46 ` Spencer Baugh
2023-07-14 13:51 ` Eli Zaretskii
2023-07-14 14:14 ` Spencer Baugh
2023-07-14 19:10 ` Eli Zaretskii
2023-07-14 19:15 ` sbaugh
2023-07-15 5:42 ` Eli Zaretskii
2023-07-15 6:20 ` Eli Zaretskii
2023-07-18 0:19 ` Dmitry Gutov
2023-07-18 1:37 ` Dmitry Gutov
2023-07-18 16:03 ` Spencer Baugh
2023-07-19 2:47 ` Dmitry Gutov
2023-07-19 6:56 ` Juri Linkov
2023-07-18 17:51 ` Juri Linkov
2023-07-19 2:24 ` Dmitry Gutov
2023-07-14 16:31 ` Juri Linkov
2023-07-18 0:34 ` Dmitry Gutov
2023-07-18 11:07 ` Eli Zaretskii
2023-07-19 2:22 ` Dmitry Gutov
2023-07-19 12:14 ` Eli Zaretskii
2023-07-19 12:31 ` Spencer Baugh
2023-07-19 13:25 ` Eli Zaretskii [this message]
2023-07-21 13:34 ` Spencer Baugh
2023-07-21 14:37 ` Eli Zaretskii
2023-07-22 18:00 ` Spencer Baugh
2023-07-24 19:18 ` Spencer Baugh
2023-07-26 15:18 ` Eli Zaretskii
2023-08-03 8:00 ` Eli Zaretskii
2023-08-03 11:54 ` Spencer Baugh
2023-08-03 14:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8eg3ue7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62621@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.