From: sbaugh@catern.com
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@janestreet.com, 62621@debbugs.gnu.org
Subject: bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename
Date: Fri, 14 Jul 2023 11:28:13 +0000 (UTC) [thread overview]
Message-ID: <878rbika0i.fsf@catern.com> (raw)
In-Reply-To: <83edlb3t0t.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Jul 2023 09:29:38 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 62621@debbugs.gnu.org
>> From: sbaugh@catern.com
>> Date: Thu, 13 Jul 2023 22:51:53 +0000 (UTC)
>>
>> I've thought quite a bit about how to make this configurable, and I
>> think just letting people write their own arbitrary transformation
>> functions, as I do in this patch, is what we should provide. Making
>> things any more modular is fairly difficult. Packages can come along
>> and provide other fancy functions if they like.
>
> If there are a couple of simpler alternatives which could be offered
> via simple symbolic values, we should not force everyone to write
> functions, IMNSHO. IOW, we should NOT immediately generalize to
> functions only because such generalization could make sense in some
> use cases. Repeat after me: Use options whose values are functions
> are hard on our users, because they require them to be Lisp
> programmers.
I agree, and I'm happy to change it to use a simple symbolic value
'project instead for the transform I wrote, but I'm not sure how best to
handle the dependencies: uniquify.el is in loadup.el, is it OK for it to
rely on project-uniquify-dirname-transform being autoloaded?
>> +(defcustom uniquify-dirname-transform #'identity
>> + "A function to transform the dirname used to uniquify a buffer.
>
> "Function to transform buffer's `default-directory' for uniquifying its name."
Unfortunately, this isn't quite right. uniquify never uses
default-directory, counterintuitively - by default, it uses the
directory of buffer-file-name, which can differ from default-directory.
>> +It takes a single argument: the directory of the buffer. It
>> +should return a string filename (which does not need to actually
>> +exist in the filesystem) to use for uniquifying the buffer name."
>> + :type '(choice (function-item :tag "Don't change the dirname" identity)
>> + function)
>> + :group 'uniquify)
>
> The :version tag is missing.
>
> Also, the doc string should state that the default is to use the
> buffer's default-directory without any transformations. It should
> also include a link to uniquify-buffer-file-name, so that users could
> consult the uniquify facilities if they need to.
Will include that in the next version.
next prev parent reply other threads:[~2023-07-14 11:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 17:37 bug#62621: 29.0.60; uniquify can't make buffers unique based on things other than filename Spencer Baugh
2023-04-02 17:57 ` Eli Zaretskii
2023-04-02 21:59 ` Drew Adams
2023-04-02 18:25 ` Juri Linkov
2023-04-14 16:08 ` Spencer Baugh
2023-07-13 22:51 ` sbaugh
2023-07-14 6:29 ` Eli Zaretskii
2023-07-14 11:28 ` sbaugh [this message]
2023-07-14 12:01 ` Eli Zaretskii
2023-07-14 12:20 ` Spencer Baugh
2023-07-14 12:29 ` Eli Zaretskii
2023-07-14 12:46 ` Spencer Baugh
2023-07-14 13:51 ` Eli Zaretskii
2023-07-14 14:14 ` Spencer Baugh
2023-07-14 19:10 ` Eli Zaretskii
2023-07-14 19:15 ` sbaugh
2023-07-15 5:42 ` Eli Zaretskii
2023-07-15 6:20 ` Eli Zaretskii
2023-07-18 0:19 ` Dmitry Gutov
2023-07-18 1:37 ` Dmitry Gutov
2023-07-18 16:03 ` Spencer Baugh
2023-07-19 2:47 ` Dmitry Gutov
2023-07-19 6:56 ` Juri Linkov
2023-07-18 17:51 ` Juri Linkov
2023-07-19 2:24 ` Dmitry Gutov
2023-07-14 16:31 ` Juri Linkov
2023-07-18 0:34 ` Dmitry Gutov
2023-07-18 11:07 ` Eli Zaretskii
2023-07-19 2:22 ` Dmitry Gutov
2023-07-19 12:14 ` Eli Zaretskii
2023-07-19 12:31 ` Spencer Baugh
2023-07-19 13:25 ` Eli Zaretskii
2023-07-21 13:34 ` Spencer Baugh
2023-07-21 14:37 ` Eli Zaretskii
2023-07-22 18:00 ` Spencer Baugh
2023-07-24 19:18 ` Spencer Baugh
2023-07-26 15:18 ` Eli Zaretskii
2023-08-03 8:00 ` Eli Zaretskii
2023-08-03 11:54 ` Spencer Baugh
2023-08-03 14:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rbika0i.fsf@catern.com \
--to=sbaugh@catern.com \
--cc=62621@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.