From: phillip.lord@russet.org.uk
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Yuan Fu" <casouri@gmail.com>,
70077@debbugs.gnu.org, "Ihor Radchenko" <yantar92@gmail.com>,
"Qiantan Hong" <qhong@alum.mit.edu>,
"Frédéric Bour" <frederic.bour@lakaban.net>,
"João Távora" <joaotavora@gmail.com>,
"Nicolas Goaziou" <mail@nicolasgoaziou.fr>,
"Alan Mackenzie" <acm@muc.de>,
"Stephen Leake" <stephen_leake@stephe-leake.org>,
"Alan Zimmerman" <alan.zimm@gmail.com>
Subject: bug#70077: An easier way to track buffer changes
Date: Fri, 29 Mar 2024 18:20:32 -0400 [thread overview]
Message-ID: <e94e6fc3b497db294a87fa2b4c388a11@russet.org.uk> (raw)
In-Reply-To: <jwvle615806.fsf@iro.umontreal.ca>
On 2024-03-29 12:15, Stefan Monnier wrote:
> Tags: patch
>
> Our `*-change-functions` hook are fairly tricky to use right.
> Some of the issues are:
>
> - before and after calls are not necessarily paired.
> - the beg/end values don't always match.
> - there can be thousands of calls from within a single command.
> - these hooks are run at a fairly low-level so there are things they
> really shouldn't do, such as modify the buffer or wait.
> - the after call doesn't get enough info to rebuild the before-change
> state,
> so some callers need to use both before-c-f and after-c-f (and then
> deal with the first two points above).
>
> The worst part is that those problems occur rarely, so many coders
> don't
> see it at first and have to learn them the hard way, sometimes forcing
> them to rethink their original design.
>
> So I think we should provide something simpler.
> I attached a proof-of-concept API which aims to do that, with the
> following entry points:
>
> (defun track-changes-register ( signal)
> "Register a new tracker and return a new tracker ID.
> SIGNAL is a function that will be called with no argument when
> the current buffer is modified, so that we can react to the change.
> Once called, SIGNAL is not called again until `track-changes-fetch'
> is called with the corresponding tracker ID."
>
> (defun track-changes-unregister (id)
> "Remove the tracker denoted by ID.
> Trackers can consume resources (especially if `track-changes-fetch'
> is
> not called), so it is good practice to unregister them when you
> don't
> need them any more."
>
> (defun track-changes-fetch (id func)
> "Fetch the pending changes.
> ID is the tracker ID returned by a previous
> `track-changes-register'.
> FUNC is a function. It is called with 3 arguments (BEGIN END
> BEFORE)
> where BEGIN..END delimit the region that was changed since the last
> time `track-changes-fetch' was called and BEFORE is a string
> containing
> the previous content of that region.
>
> If no changes occurred since the last time, FUNC is not called and
> we return nil, otherwise we return the value returned by FUNC,
> and re-enable the TRACKER corresponding to ID."
>
> It's not meant as a replacement of the existing hooks since it doesn't
> try to accommodate some uses such as those that use before-c-f to
> implement a finer-grained form of read-only text.
>
> The driving design was:
>
> - Try to provide enough info such that it is possible and easy to
> maintain a copy of the buffer simply by applying the reported
> changes.
> E.g. for uses such as `eglot.el` or `crdt.el`.
> - Make the API less synchronous: take care of combining small changes
> into larger ones, and let the clients decide when they react to
> changes.
>
> If you're in the Cc, it's because I believe you have valuable
> experience
> with those hooks, so I'd be happy to hear your thought about whether
> you think this would indeed (have) be(en) better than what we have.
Your description of the problem is entirely consistent with my
experience. The last time I
checked it was `subst-char-in-region' which was causing most of the
difficulties, normally as a result of `fill-paragraph'.
If I remember correctly, I think this wouldn't be enough for my use. You
keep two buffers
in sync, you have to use before-change-function -- it is only before any
change that the
two buffers are guaranteed to be in sync and it is this that allows you
to work out what the
`start' and `end' positions mean in the copied buffer. Afterward, you
cannot work out what the end position because you don't know if the
change is a change, insertion, deletion or both.
Last time I checked, I did find relatively few primitives that were
guilty of being inconsistent -- in the case of `subst-char-in-region',
it returned the maximal area of effect before the and the minimal area
of effect after. Would it not be easier to fix these?
Phil
next prev parent reply other threads:[~2024-03-29 22:20 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 16:15 bug#70077: An easier way to track buffer changes Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 18:12 ` Eli Zaretskii
2024-03-29 18:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 6:34 ` Eli Zaretskii
2024-03-30 14:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 16:45 ` Eli Zaretskii
2024-03-31 2:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-01 11:53 ` Ihor Radchenko
2024-04-01 14:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-01 17:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-02 14:22 ` Ihor Radchenko
2024-04-02 15:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-02 16:21 ` Ihor Radchenko
2024-04-02 17:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-03 12:34 ` Ihor Radchenko
2024-04-03 12:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-04 17:58 ` Ihor Radchenko
2024-03-30 3:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 5:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 22:20 ` phillip.lord [this message]
2024-03-29 22:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 6:46 ` Eli Zaretskii
2024-03-30 12:06 ` phillip.lord
2024-03-30 13:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 9:51 ` Ihor Radchenko
2024-03-30 12:49 ` Eli Zaretskii
2024-03-30 13:19 ` Ihor Radchenko
2024-03-30 13:31 ` Eli Zaretskii
2024-03-30 14:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-05 22:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-06 8:43 ` Eli Zaretskii
2024-04-08 15:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-08 15:53 ` Eli Zaretskii
2024-04-08 17:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-08 17:27 ` Andrea Corallo
2024-04-08 18:36 ` Eli Zaretskii
2024-04-08 20:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 4:10 ` Eli Zaretskii
2024-04-08 20:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 3:56 ` Eli Zaretskii
2024-04-09 23:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-13 13:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-06 17:37 ` Dmitry Gutov
2024-04-06 19:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 14:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 15:47 ` Dmitry Gutov
2024-04-07 14:07 ` Ihor Radchenko
2024-04-08 16:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 17:35 ` Ihor Radchenko
2024-04-10 2:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e94e6fc3b497db294a87fa2b4c388a11@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=70077@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=alan.zimm@gmail.com \
--cc=casouri@gmail.com \
--cc=frederic.bour@lakaban.net \
--cc=joaotavora@gmail.com \
--cc=mail@nicolasgoaziou.fr \
--cc=monnier@iro.umontreal.ca \
--cc=qhong@alum.mit.edu \
--cc=stephen_leake@stephe-leake.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.