bug#60526: 29.0.60; javascript-mode → js-mode

bug#60526: 29.0.60; javascript-mode → js-mode

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

It looks wrong to require from users to add mappings for both `js-mode'
and its alias `javascript-mode' to `major-mode-remap-alist':

  (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode))
  (add-to-list 'major-mode-remap-alist '(javascript-mode . js-ts-mode))

Either `major-mode-remap-alist' could support aliases, or simpler
would be just to replace the alias in `auto-mode-alist':


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: javascript-ts-mode.patch --]
[-- Type: text/x-diff, Size: 571 bytes --]

diff --git a/lisp/files.el b/lisp/files.el
index c45c3d40a5d..2acc1d1df4a 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -2952,9 +2952,9 @@ auto-mode-alist
      ("\\.dbk\\'" . xml-mode)
      ("\\.dtd\\'" . sgml-mode)
      ("\\.ds\\(ss\\)?l\\'" . dsssl-mode)
-     ("\\.js[mx]?\\'" . javascript-mode)
+     ("\\.js[mx]?\\'" . js-mode)
      ;; https://en.wikipedia.org/wiki/.har
-     ("\\.har\\'" . javascript-mode)
+     ("\\.har\\'" . js-mode)
      ("\\.json\\'" . js-json-mode)
      ("\\.[ds]?va?h?\\'" . verilog-mode)
      ("\\.by\\'" . bovine-grammar-mode)

bug#60526: 29.0.60; javascript-mode → js-mode

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 03 Jan 2023 20:12:38 +0200
> 
> 
> It looks wrong to require from users to add mappings for both `js-mode'
> and its alias `javascript-mode' to `major-mode-remap-alist':
> 
>   (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode))
>   (add-to-list 'major-mode-remap-alist '(javascript-mode . js-ts-mode))
> 
> Either `major-mode-remap-alist' could support aliases, or simpler
> would be just to replace the alias in `auto-mode-alist':
> 
> diff --git a/lisp/files.el b/lisp/files.el
> index c45c3d40a5d..2acc1d1df4a 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -2952,9 +2952,9 @@ auto-mode-alist
>       ("\\.dbk\\'" . xml-mode)
>       ("\\.dtd\\'" . sgml-mode)
>       ("\\.ds\\(ss\\)?l\\'" . dsssl-mode)
> -     ("\\.js[mx]?\\'" . javascript-mode)
> +     ("\\.js[mx]?\\'" . js-mode)
>       ;; https://en.wikipedia.org/wiki/.har
> -     ("\\.har\\'" . javascript-mode)
> +     ("\\.har\\'" . js-mode)
>       ("\\.json\\'" . js-json-mode)
>       ("\\.[ds]?va?h?\\'" . verilog-mode)
>       ("\\.by\\'" . bovine-grammar-mode)

This is basically a no-brainer, but we had javascript-mode there for
quite some time, and it's too late to change that for Emacs 29.
Please install on master.

bug#60526: 29.0.60; javascript-mode → js-mode

[Yuan Fu]

> On Jan 3, 2023, at 1:21 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Juri Linkov <juri@linkov.net>
>> Date: Tue, 03 Jan 2023 20:12:38 +0200
>> 
>> 
>> It looks wrong to require from users to add mappings for both `js-mode'
>> and its alias `javascript-mode' to `major-mode-remap-alist':
>> 
>>  (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode))
>>  (add-to-list 'major-mode-remap-alist '(javascript-mode . js-ts-mode))
>> 
>> Either `major-mode-remap-alist' could support aliases, or simpler
>> would be just to replace the alias in `auto-mode-alist':
>> 
>> diff --git a/lisp/files.el b/lisp/files.el
>> index c45c3d40a5d..2acc1d1df4a 100644
>> --- a/lisp/files.el
>> +++ b/lisp/files.el
>> @@ -2952,9 +2952,9 @@ auto-mode-alist
>>      ("\\.dbk\\'" . xml-mode)
>>      ("\\.dtd\\'" . sgml-mode)
>>      ("\\.ds\\(ss\\)?l\\'" . dsssl-mode)
>> -     ("\\.js[mx]?\\'" . javascript-mode)
>> +     ("\\.js[mx]?\\'" . js-mode)
>>      ;; https://en.wikipedia.org/wiki/.har
>> -     ("\\.har\\'" . javascript-mode)
>> +     ("\\.har\\'" . js-mode)
>>      ("\\.json\\'" . js-json-mode)
>>      ("\\.[ds]?va?h?\\'" . verilog-mode)
>>      ("\\.by\\'" . bovine-grammar-mode)
> 
> This is basically a no-brainer, but we had javascript-mode there for
> quite some time, and it's too late to change that for Emacs 29.
> Please install on master.

I thought auto-mode-alist should use the canonical name and major-mode-remap-alist maps the canonical name to the actual mode. Why do we need 

>> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode))

if auto-mode-alist uses javascript-mode?

Yuan

bug#60526: 29.0.60; javascript-mode → js-mode

[Juri Linkov]

>>> -     ("\\.js[mx]?\\'" . javascript-mode)
>>> +     ("\\.js[mx]?\\'" . js-mode)
>>>      ;; https://en.wikipedia.org/wiki/.har
>>> -     ("\\.har\\'" . javascript-mode)
>>> +     ("\\.har\\'" . js-mode)
>>>      ("\\.json\\'" . js-json-mode)
>>>      ("\\.[ds]?va?h?\\'" . verilog-mode)
>>>      ("\\.by\\'" . bovine-grammar-mode)
>>
>> This is basically a no-brainer, but we had javascript-mode there for
>> quite some time, and it's too late to change that for Emacs 29.
>> Please install on master.
>
> I thought auto-mode-alist should use the canonical name and
> major-mode-remap-alist maps the canonical name to the actual mode.

But the canonical name is js-mode, because javascript-mode is
an alias to js-mode.

> Why do we need
>
>>> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode))
>
> if auto-mode-alist uses javascript-mode?

This is needed for the case when users or packages customized
auto-mode-alist to use the name js-mode.

bug#60526: 29.0.60; javascript-mode → js-mode

[Yuan Fu]

Juri Linkov <juri@linkov.net> writes:

>>>> -     ("\\.js[mx]?\\'" . javascript-mode)
>>>> +     ("\\.js[mx]?\\'" . js-mode)
>>>>      ;; https://en.wikipedia.org/wiki/.har
>>>> -     ("\\.har\\'" . javascript-mode)
>>>> +     ("\\.har\\'" . js-mode)
>>>>      ("\\.json\\'" . js-json-mode)
>>>>      ("\\.[ds]?va?h?\\'" . verilog-mode)
>>>>      ("\\.by\\'" . bovine-grammar-mode)
>>>
>>> This is basically a no-brainer, but we had javascript-mode there for
>>> quite some time, and it's too late to change that for Emacs 29.
>>> Please install on master.
>>
>> I thought auto-mode-alist should use the canonical name and
>> major-mode-remap-alist maps the canonical name to the actual mode.
>
> But the canonical name is js-mode, because javascript-mode is
> an alias to js-mode.

js-mode feels more like "implementation name" to me. After all, the name
of the language is Javascript, not js. I think javascript-mode best
represents "major mode for javascript", not js-mode, if you get what I
mean.

>> Why do we need
>>
>>>> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode))
>>
>> if auto-mode-alist uses javascript-mode?
>
> This is needed for the case when users or packages customized
> auto-mode-alist to use the name js-mode.

If they customize auto-mode-alist to js-mode, I expect them to expect
Emacs to use js-mode by default, not the tree-sitter mode.

Yuan

bug#60526: 29.0.60; javascript-mode → js-mode

[Juri Linkov]

> js-mode feels more like "implementation name" to me. After all, the name
> of the language is Javascript, not js. I think javascript-mode best
> represents "major mode for javascript", not js-mode, if you get what I
> mean.

Indeed, and the treesit module is named tree-sitter-javascript, not js.
So closing this report now.

bug#60526: 29.0.60; javascript-mode → js-mode

[Dmitry Gutov]

On 08/01/2023 03:39, Yuan Fu wrote:
> Juri Linkov<juri@linkov.net>  writes:
> 
>>>>> -     ("\\.js[mx]?\\'" . javascript-mode)
>>>>> +     ("\\.js[mx]?\\'" . js-mode)
>>>>>       ;;https://en.wikipedia.org/wiki/.har
>>>>> -     ("\\.har\\'" . javascript-mode)
>>>>> +     ("\\.har\\'" . js-mode)
>>>>>       ("\\.json\\'" . js-json-mode)
>>>>>       ("\\.[ds]?va?h?\\'" . verilog-mode)
>>>>>       ("\\.by\\'" . bovine-grammar-mode)
>>>> This is basically a no-brainer, but we had javascript-mode there for
>>>> quite some time, and it's too late to change that for Emacs 29.
>>>> Please install on master.
>>> I thought auto-mode-alist should use the canonical name and
>>> major-mode-remap-alist maps the canonical name to the actual mode.
>> But the canonical name is js-mode, because javascript-mode is
>> an alias to js-mode.
> js-mode feels more like "implementation name" to me. After all, the name
> of the language is Javascript, not js. I think javascript-mode best
> represents "major mode for javascript", not js-mode, if you get what I
> mean.
> 

javascript-mode was the name of a different mode. js-mode was a later 
rewrite of it.