From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60526: 29.0.60; javascript-mode =?UTF-8?Q?=E2=86=92?= js-mode Date: Tue, 3 Jan 2023 23:40:47 -0700 Message-ID: <3E20C72B-F725-4EDC-A2E2-F0BEA7B563B6@gmail.com> References: <86fscrwkq1.fsf@mail.linkov.net> <83sfgrz7wu.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60526@debbugs.gnu.org, Stefan Monnier , Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 04 07:41:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCxSr-00058i-3r for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Jan 2023 07:41:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCxSW-0007kZ-Ph; Wed, 04 Jan 2023 01:41:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCxSU-0007kK-9w for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 01:41:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCxSQ-0002Zl-DU for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 01:41:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCxSP-0002sm-Tg for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2023 01:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2023 06:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60526 X-GNU-PR-Package: emacs Original-Received: via spool by 60526-submit@debbugs.gnu.org id=B60526.167281446011066 (code B ref 60526); Wed, 04 Jan 2023 06:41:01 +0000 Original-Received: (at 60526) by debbugs.gnu.org; 4 Jan 2023 06:41:00 +0000 Original-Received: from localhost ([127.0.0.1]:47381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCxSN-0002sP-Lk for submit@debbugs.gnu.org; Wed, 04 Jan 2023 01:40:59 -0500 Original-Received: from mail-pj1-f51.google.com ([209.85.216.51]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCxSJ-0002s8-Bs for 60526@debbugs.gnu.org; Wed, 04 Jan 2023 01:40:57 -0500 Original-Received: by mail-pj1-f51.google.com with SMTP id z9-20020a17090a468900b00226b6e7aeeaso555767pjf.1 for <60526@debbugs.gnu.org>; Tue, 03 Jan 2023 22:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tGrliAjc1KC/MkeEKuomh/mvEsC4CK96oQn/MqWSx74=; b=HVjnn0xT5tMHRvDrhTUF7LHovSjtI6lWzAp9eS2sjwdp+6ocGUTYhrrb30W/NZVYle x5hniRxd+bvW7yhQazIFuvqifAhQdWvai2XqfnTEGYHBSPw+sCi99ZrqTDFpaw7ugDbB U1tDRLU4y/HMWJ2wLMRTpL8MFcKj7RY9yiaUdMolan9UnqNCmU4QefYobW4Z6zwSy2Nm nl+xd+C22wXAKb3Eez6/yV1S+EJC72KurKOLE39p8w/LWCioBGdzaAwp3AGVPM1gVGcU KXpuMzKA+ItB2UyNpefrq3iUGwdBUB/A9geTpEmAtwe9/LjK4qyaX/z2HaXobTi2sErY lfHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tGrliAjc1KC/MkeEKuomh/mvEsC4CK96oQn/MqWSx74=; b=I5uDufCXl/f/Qgj4W38C0i948Ht+t5EsI5jB/wQL1ly48ZdXlNPprRYP/QevTfqlV+ Vbmkw0L8OinArO858S65EzFqUJ5hXojvbt1NJT4+5ZuU2O0znJuCb+xRP7d0aQdPZTFc vO8z+MCvUd5SdRpsqrBkmmKX5Axz6TFL7j2Xdx5PjqQQLGPmhPlEc/H8OakfBgV+gFrt iDuQ687dx0WSOxbw3QhQx7BbPO17GwShPvCWSQ6nuK7KkOvYeodb17I6yyY6A2d+6aZM 8u7bbyltozYB/BVbGF/FaOvn5fz4EKcIcIFCLtNlW34ee6CE/CwzOPjn8TVcPBrsWsFa uP2w== X-Gm-Message-State: AFqh2kqYcEMITa+zLY8hIQaRGTGT+tt5dPBv2TE1Sh6lLOCkSVg8bUcg Q65edtjwm63vSj8Iv4ZstGM= X-Google-Smtp-Source: AMrXdXtyv/FMsdY1bNZQU1DqM1Ds5ipwmjsdw+YTJNu6KE5xIeAR0gWN4jOO72H5KGj4UPfRlBPvtw== X-Received: by 2002:a17:902:aa96:b0:18e:8223:6447 with SMTP id d22-20020a170902aa9600b0018e82236447mr46916384plr.22.1672814449232; Tue, 03 Jan 2023 22:40:49 -0800 (PST) Original-Received: from smtpclient.apple (ip68-3-33-122.ph.ph.cox.net. [68.3.33.122]) by smtp.gmail.com with ESMTPSA id n15-20020a170902e54f00b00189348ab156sm2059790plf.283.2023.01.03.22.40.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2023 22:40:48 -0800 (PST) In-Reply-To: <83sfgrz7wu.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252448 Archived-At: > On Jan 3, 2023, at 1:21 PM, Eli Zaretskii wrote: >=20 >> From: Juri Linkov >> Date: Tue, 03 Jan 2023 20:12:38 +0200 >>=20 >>=20 >> It looks wrong to require from users to add mappings for both = `js-mode' >> and its alias `javascript-mode' to `major-mode-remap-alist': >>=20 >> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) >> (add-to-list 'major-mode-remap-alist '(javascript-mode . = js-ts-mode)) >>=20 >> Either `major-mode-remap-alist' could support aliases, or simpler >> would be just to replace the alias in `auto-mode-alist': >>=20 >> diff --git a/lisp/files.el b/lisp/files.el >> index c45c3d40a5d..2acc1d1df4a 100644 >> --- a/lisp/files.el >> +++ b/lisp/files.el >> @@ -2952,9 +2952,9 @@ auto-mode-alist >> ("\\.dbk\\'" . xml-mode) >> ("\\.dtd\\'" . sgml-mode) >> ("\\.ds\\(ss\\)?l\\'" . dsssl-mode) >> - ("\\.js[mx]?\\'" . javascript-mode) >> + ("\\.js[mx]?\\'" . js-mode) >> ;; https://en.wikipedia.org/wiki/.har >> - ("\\.har\\'" . javascript-mode) >> + ("\\.har\\'" . js-mode) >> ("\\.json\\'" . js-json-mode) >> ("\\.[ds]?va?h?\\'" . verilog-mode) >> ("\\.by\\'" . bovine-grammar-mode) >=20 > This is basically a no-brainer, but we had javascript-mode there for > quite some time, and it's too late to change that for Emacs 29. > Please install on master. I thought auto-mode-alist should use the canonical name and = major-mode-remap-alist maps the canonical name to the actual mode. Why = do we need=20 >> (add-to-list 'major-mode-remap-alist '(js-mode . js-ts-mode)) if auto-mode-alist uses javascript-mode? Yuan=