From: Gregory Heytings <gregory@heytings.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 59444-done@debbugs.gnu.org
Subject: bug#59444: ADVICE-ON-FAILURE sed syntax error
Date: Mon, 21 Nov 2022 12:49:50 +0000 [thread overview]
Message-ID: <c25df841bae513e5dc39@heytings.org> (raw)
In-Reply-To: <B4506886-AA82-4591-A533-036FF81C8C3A@gmail.com>
Thanks for your bug report.
>
> Right now on Emacs master (d9d8a2eba9), any build error results in
>
Is this new? That part of the Makefile hasn't changed in the last two
months, after it was introduced.
>
> The bug is here somewhere (Makefile.in:413):
>
> sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,$${p;/^# ADVICE-ON-FAILURE-END:${make-target}/q};'
>
> Any reason why this isn't just written
>
> sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,/^# ADVICE-ON-FAILURE-END:${make-target}/p'
>
> ? The latter would work with any standard `sed`.
>
Again I tested this with (GNU) sed with --posix, and it gave the expected
result. The reason I chose the former expression instead of the latter is
because it's how I usually write such patterns. After reading the POSIX
standard, it turns out that a semicolon is required after the 'q'. Fixed
(a3b654e069) and closing.
next prev parent reply other threads:[~2022-11-21 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 11:51 bug#59444: ADVICE-ON-FAILURE sed syntax error Mattias Engdegård
2022-11-21 12:49 ` Gregory Heytings [this message]
2022-11-21 13:11 ` Mattias Engdegård
2022-11-21 13:17 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c25df841bae513e5dc39@heytings.org \
--to=gregory@heytings.org \
--cc=59444-done@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.