From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#59444: ADVICE-ON-FAILURE sed syntax error Date: Mon, 21 Nov 2022 12:49:50 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59444-done@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 21 13:50:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ox6Fe-0008VM-Pd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Nov 2022 13:50:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox6FR-0007is-6h; Mon, 21 Nov 2022 07:50:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox6FP-0007hu-7b for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 07:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox6FO-000460-SM for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 07:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ox6FO-0005o8-IB for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 07:50:02 -0500 Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59444 X-GNU-PR-Package: emacs Mail-Followup-To: 59444@debbugs.gnu.org, gregory@heytings.org, mattias.engdegard@gmail.com Original-Received: via spool by 59444-done@debbugs.gnu.org id=D59444.166903499522301 (code D ref 59444); Mon, 21 Nov 2022 12:50:02 +0000 Original-Received: (at 59444-done) by debbugs.gnu.org; 21 Nov 2022 12:49:55 +0000 Original-Received: from localhost ([127.0.0.1]:45700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6FH-0005nd-IK for submit@debbugs.gnu.org; Mon, 21 Nov 2022 07:49:55 -0500 Original-Received: from heytings.org ([95.142.160.155]:52844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6FE-0005nT-DB for 59444-done@debbugs.gnu.org; Mon, 21 Nov 2022 07:49:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669034990; bh=5xSIDjdvCxh5g+f4j6bIRMYMH+Ads6pwL9zqe33TA9w=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=dtGawsKCB1l+5psP3DyiqC0PtBrbu1GIfRkjqv8/fLXbpAWrPheRNaKqdOZLWuodD 6d+EjQ6rMUnmtw5st86d3SacXzXEoIMMH/DLCFY+GegLpIo9vgq1kDBFK9yvwyGY8i EKxC23PalU3vz29tXDeTemMPF5J0S60yE9ADpkXzux9Fam3Lr9sUhh0jxfrL7sqlls UpJM7VOQ1bURXJpxo0AR7unWLiMfBgqKvFECFwazDyRLbFTv+4jVfJrieDVAayUXwn MCKBzRab7p8RHA0JXdDFJlo5bhYfjpQU+P/ZMC3ZqyJGphwtYSh8s+TDCP/fFwq1sR pjuOpWtoI0S1A== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248521 Archived-At: Thanks for your bug report. > > Right now on Emacs master (d9d8a2eba9), any build error results in > Is this new? That part of the Makefile hasn't changed in the last two months, after it was introduced. > > The bug is here somewhere (Makefile.in:413): > > sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,$${p;/^# ADVICE-ON-FAILURE-END:${make-target}/q};' > > Any reason why this isn't just written > > sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,/^# ADVICE-ON-FAILURE-END:${make-target}/p' > > ? The latter would work with any standard `sed`. > Again I tested this with (GNU) sed with --posix, and it gave the expected result. The reason I chose the former expression instead of the latter is because it's how I usually write such patterns. After reading the POSIX standard, it turns out that a semicolon is required after the 'q'. Fixed (a3b654e069) and closing.