From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: 59444@debbugs.gnu.org
Cc: Gregory Heytings <gregory@heytings.org>
Subject: bug#59444: ADVICE-ON-FAILURE sed syntax error
Date: Mon, 21 Nov 2022 12:51:05 +0100 [thread overview]
Message-ID: <B4506886-AA82-4591-A533-036FF81C8C3A@gmail.com> (raw)
Right now on Emacs master (d9d8a2eba9), any build error results in
***
*** "make all" failed with exit status 2.
***
sed: 1: "/^# ADVICE-ON-FAILURE-B ...": extra characters at the end of q command
make[1]: *** [advice-on-failure] Error 1
make: *** [all] Error 2
which is less than helpful. (This is with macOS 11.7, system tools.)
The bug is here somewhere (Makefile.in:413):
sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,$${p;/^# ADVICE-ON-FAILURE-END:${make-target}/q};'
Any reason why this isn't just written
sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,/^# ADVICE-ON-FAILURE-END:${make-target}/p'
? The latter would work with any standard `sed`.
next reply other threads:[~2022-11-21 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 11:51 Mattias Engdegård [this message]
2022-11-21 12:49 ` bug#59444: ADVICE-ON-FAILURE sed syntax error Gregory Heytings
2022-11-21 13:11 ` Mattias Engdegård
2022-11-21 13:17 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B4506886-AA82-4591-A533-036FF81C8C3A@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=59444@debbugs.gnu.org \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.