all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Filippo Argiolas <filippo.argiolas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Foreground color opacity
Date: Tue, 12 Sep 2023 06:55:14 +0200	[thread overview]
Message-ID: <CAOdrLGLO2s7y2ywFQ0XpzwXA53=9Siu6nxqUpjutMiP=MHmC0w@mail.gmail.com> (raw)
In-Reply-To: <83tts0p1vu.fsf@gnu.org>

On Tue, Sep 12, 2023 at 4:21 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > > One such example is flyspell.el's flyspell-prog-mode.  See
> > > flyspell-prog-text-faces there.
> >
> > Thanks! That should be easily solvable by adding
> > `font-lock-string-face-clangd-inactive' and the other relevant
> > inactive face variants to `flyspell-prog-text-faces'.
> > FWIW with eglot+clangd (and I guess other servers too) inactive code
> > regions already behave differently because they are not compiled, so
> > you won't get e.g. any flymake diagnostics or inlay hints, so it could
> > be a little less of an issue if something else like flyspell in this
> > case breaks.
>
> My point is that this technique _will_ break features, and I don't
> think it's reasonable to expect each one of them to be fixed
> individually.

Sure and that's a pretty valid point. Thank you for the insight!
I could experiment a bit more with overlays. Maybe setting an overlay
for each node instead of directly changing the face property. Not sure
if that may impact performance though, need to do some test.

My point was that with eglot there are several features that already
do break within inactive regions, at least with clangd, as the
language server rightfully considers them as dead code. Flymake
diagnostics, symbol highlight, documentation on hover, completion come
to mind but there are probably others.

I'll add a known issues section about this in the readme while I look
for a better solution.

Filippo



  reply	other threads:[~2023-09-12  4:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 10:45 Foreground color opacity Filippo Argiolas
2023-09-11 12:58 ` Eli Zaretskii
2023-09-11 13:09   ` Filippo Argiolas
2023-09-11 14:04     ` Eli Zaretskii
2023-09-11 14:58       ` [External] : " Drew Adams
2023-09-11 16:08         ` Filippo Argiolas
2023-09-11 16:25       ` Filippo Argiolas
2023-09-11 16:56         ` Eli Zaretskii
2023-09-11 19:00           ` Filippo Argiolas
2023-09-12  2:21             ` Eli Zaretskii
2023-09-12  4:55               ` Filippo Argiolas [this message]
2023-09-12  5:24                 ` Filippo Argiolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOdrLGLO2s7y2ywFQ0XpzwXA53=9Siu6nxqUpjutMiP=MHmC0w@mail.gmail.com' \
    --to=filippo.argiolas@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.