From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.devel Subject: Re: Foreground color opacity Date: Tue, 12 Sep 2023 06:55:14 +0200 Message-ID: References: <83fs3krhmi.fsf@gnu.org> <838r9crel3.fsf@gnu.org> <8334zkr6ll.fsf@gnu.org> <83tts0p1vu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29263"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 12 06:55:54 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfvRJ-0007Ky-Ue for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Sep 2023 06:55:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfvR0-00079B-1C; Tue, 12 Sep 2023 00:55:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfvQy-00078l-59 for emacs-devel@gnu.org; Tue, 12 Sep 2023 00:55:32 -0400 Original-Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfvQu-0007ws-OQ; Tue, 12 Sep 2023 00:55:31 -0400 Original-Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-411f5dd7912so35921311cf.3; Mon, 11 Sep 2023 21:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694494526; x=1695099326; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8Tu0Z38/fnWoRBDohWRwKABn91dtZalLObcIU5xbJBk=; b=BanJ4UPPkgmv5oPx/yXiG4bVnraeD04eAotiRdX4RrSq63KZnGvvoz8tDOU58yqOz/ PaL6JJwO1nUvAFpe3OcbiseXfuYk8bWx1YyhrejFI2m/wfF9XmliFFaxDAvbbFwp30Gc P0D4XiqF+zFsANYnALcpGykvkqy91jccJgD0pgWc/SZ9zzjH74llHlJY6AdpCw9i78op hgtrJYtZT2B4dGMe4w70883DBGB/0+dcfydYnkUkdTXtKAcak66xpBq64mgd6ZKAmwCF 84KQPwwYrfRgROcgO9KQAuwBj7pGi2njxh1xDvlh8uZxt4vORFR/Z125ctQgQJf4PcbW m0Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694494526; x=1695099326; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Tu0Z38/fnWoRBDohWRwKABn91dtZalLObcIU5xbJBk=; b=n5AS69MWmKfgCeRaEp3ARuyVp2zAEx9GxaLite/rWpG3Nyj5VUxfFMCPGrPvVqLt1Q tIoRcfLphRLgltrznPnj19ejpnPvM03Ohbv6zK/u3voUADbsvY7yMpZnk2zcJyR3y2Y7 EtUdv1TVikH+sqYOrlB5jxFSFqpQ9C3BHqPMRwWrwe4Td3FnkiKTcz+B5ASV2OM6+VH3 aQ9wGQzMOM8aBYnUBHNdI3CeQhA6vpQgawYYC/ifh4YWgbs1zAeWozwJR7q10q7ug+1Z 6yQPqngq+i2ha12NI5hos+4KuIJa6f2IoTA0ZYhPBpAmogajH/5xpNQwKhVp0L+7xK7L M8jw== X-Gm-Message-State: AOJu0Yxho7a5cKgT6ri5H7S0gGUPFroNzmJynruAycm9aS+dijIdokEL zPTiNPjgmDvLSXeoelgquSshoMsH5qYmU3GH9ifwuYkT X-Google-Smtp-Source: AGHT+IHEJYU6RQRPRp+bQsEatgFuxnQUgEf1zyRhaTynb1k6mbrwJOGX/yFG4EDgLssetxUu5JRfIk9kKy0xe4dukM4= X-Received: by 2002:ac8:5f90:0:b0:403:788f:5d0d with SMTP id j16-20020ac85f90000000b00403788f5d0dmr15518263qta.0.1694494526092; Mon, 11 Sep 2023 21:55:26 -0700 (PDT) In-Reply-To: <83tts0p1vu.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=filippo.argiolas@gmail.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310503 Archived-At: On Tue, Sep 12, 2023 at 4:21=E2=80=AFAM Eli Zaretskii wrote: > > > One such example is flyspell.el's flyspell-prog-mode. See > > > flyspell-prog-text-faces there. > > > > Thanks! That should be easily solvable by adding > > `font-lock-string-face-clangd-inactive' and the other relevant > > inactive face variants to `flyspell-prog-text-faces'. > > FWIW with eglot+clangd (and I guess other servers too) inactive code > > regions already behave differently because they are not compiled, so > > you won't get e.g. any flymake diagnostics or inlay hints, so it could > > be a little less of an issue if something else like flyspell in this > > case breaks. > > My point is that this technique _will_ break features, and I don't > think it's reasonable to expect each one of them to be fixed > individually. Sure and that's a pretty valid point. Thank you for the insight! I could experiment a bit more with overlays. Maybe setting an overlay for each node instead of directly changing the face property. Not sure if that may impact performance though, need to do some test. My point was that with eglot there are several features that already do break within inactive regions, at least with clangd, as the language server rightfully considers them as dead code. Flymake diagnostics, symbol highlight, documentation on hover, completion come to mind but there are probably others. I'll add a known issues section about this in the readme while I look for a better solution. Filippo