all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Filippo Argiolas <filippo.argiolas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Foreground color opacity
Date: Tue, 12 Sep 2023 05:21:41 +0300	[thread overview]
Message-ID: <83tts0p1vu.fsf@gnu.org> (raw)
In-Reply-To: <CAOdrLGLY6Qb7zmm=69gdC44k4=9nkPy5kTkUijLUtQYQ+-txWA@mail.gmail.com> (message from Filippo Argiolas on Mon, 11 Sep 2023 21:00:35 +0200)

> From: Filippo Argiolas <filippo.argiolas@gmail.com>
> Date: Mon, 11 Sep 2023 21:00:35 +0200
> Cc: emacs-devel@gnu.org
> 
> On Mon, Sep 11, 2023 at 6:57 PM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > From: Filippo Argiolas <filippo.argiolas@gmail.com>
> > > Date: Mon, 11 Sep 2023 18:25:50 +0200
> > > Cc: emacs-devel@gnu.org
> > >
> > > Didn't encounter any issue so far with c and c-ts modes but something
> > > like you described could definitely happen if someone relies on font
> > > face to detect symbol type. I'd say that's kind of an unsafe aspect to
> > > rely on. Do you have any example in mind of code doing that so I could
> > > run some tests?
> >
> > One such example is flyspell.el's flyspell-prog-mode.  See
> > flyspell-prog-text-faces there.
> 
> Thanks! That should be easily solvable by adding
> `font-lock-string-face-clangd-inactive' and the other relevant
> inactive face variants to `flyspell-prog-text-faces'.
> FWIW with eglot+clangd (and I guess other servers too) inactive code
> regions already behave differently because they are not compiled, so
> you won't get e.g. any flymake diagnostics or inlay hints, so it could
> be a little less of an issue if something else like flyspell in this
> case breaks.

My point is that this technique _will_ break features, and I don't
think it's reasonable to expect each one of them to be fixed
individually.



  reply	other threads:[~2023-09-12  2:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 10:45 Foreground color opacity Filippo Argiolas
2023-09-11 12:58 ` Eli Zaretskii
2023-09-11 13:09   ` Filippo Argiolas
2023-09-11 14:04     ` Eli Zaretskii
2023-09-11 14:58       ` [External] : " Drew Adams
2023-09-11 16:08         ` Filippo Argiolas
2023-09-11 16:25       ` Filippo Argiolas
2023-09-11 16:56         ` Eli Zaretskii
2023-09-11 19:00           ` Filippo Argiolas
2023-09-12  2:21             ` Eli Zaretskii [this message]
2023-09-12  4:55               ` Filippo Argiolas
2023-09-12  5:24                 ` Filippo Argiolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tts0p1vu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=filippo.argiolas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.