* Bug: fill-paragraph in Org buffer [9.4 (9.4-19-gb1de0c-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201019/)]
@ 2020-10-26 17:11 Gustavo Barros
2022-10-22 13:10 ` Gustavo Barros
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Barros @ 2020-10-26 17:11 UTC (permalink / raw)
To: emacs-orgmode
Hi All,
Calling `fill-paragraph' in an Org buffer may leak paragraph boundaries,
and even heading boundaries, and break document structure.
I'm aware, of course, of `org-fill-paragraph'. Indeed, `org-mode' both
sets `fill-paragraph' function to `org-fill-paragraph' and remaps the
`fill-paragraph' binding to `org-fill-paragraph'. If I understand
correctly, this is technically redundant, but (a guess) probably the
remapping is kept for backwards compatibility reasons.
I don't know why this happens. As far as I get, `fill-paragraph' should
be calling `fill-paragraph-function', so I'd expect both to do the same
thing. But currently they don't.
Why would anyone call `fill-paragraph' instead of `org-fill-paragraph'?
Well, if you have some paragraph filling tweak you like, you might. For
example, one such instance is that widespread "fill-or-unfill" function,
which I think started with Artur Malabarba, and was eventually packaged
by Steve Purcell in https://github.com/purcell/unfill (180k+ downloads
at MELPA).
Either way, even when the binding for `fill-paragraph' is remapped to
`org-fill-paragraph' it should be at least safe (I think...) to call
`fill-paragraph' directly in an Org buffer, even when it might arguably
be better to call `org-fill-paragraph'.
An ECM to reproduce the issue is:
- Start 'emacs -Q'
- Do an initial setup:
#+begin_src emacs-lisp
(add-to-list 'load-path "~/.emacs.d/elpa/org-plus-contrib-20201019")
#+end_src
- Visit file =test.org= with contents:
#+begin_src org
,* Foo
- Boo
- Baz
,* Bar
:PROPERTIES:
:CATEGORY: home
:CUSTOM_ID: Bar
:END:
#+end_src
- Place point in the "Baz" list item under heading "Foo", and call `M-x
org-fill-paragraph'. As expected, the buffer is unchanged.
- Now call `M-x fill-paragraph'. The result is:
- The result is:
#+begin_src org
,* Foo
- Boo
- Baz
,* Bar
:PROPERTIES:
:CATEGORY: home :CUSTOM_ID: Bar
:END:
#+end_src
where `fill-paragraph' "filled" the contents of the properties drawer of
the following heading, despite three whole blank lines and a heading
along the way.
Best regards,
Gustavo.
Emacs : GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.20, cairo version 1.16.0)
of 2020-08-11
Package: Org mode version 9.4 (9.4-19-gb1de0c-elpaplus @
/home/gustavo/.emacs.d/elpa/org-plus-contrib-20201019/)
current state:
==============
(setq
org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
org-link-shell-confirm-function 'yes-or-no-p
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook
change-major-mode-hook org-show-all append local] 5]
#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook
org-babel-show-result-all append local] 5]
org-babel-result-hide-spec org-babel-hide-all-hashes
org-eldoc-load)
org-archive-hook '(org-attach-archive-delete-maybe)
org-confirm-elisp-link-function 'yes-or-no-p
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-metaup-hook '(org-babel-load-in-session-maybe)
org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3
"\n\n(fn ENTRY)"]
org-babel-pre-tangle-hook '(save-buffer)
org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
org-agenda-loop-over-headlines-in-active-region nil
org-src-lang-modes '(("arduino" . arduino) ("redis" . redis) ("php"
. php) ("C" . c) ("C++" . c++)
("asymptote" . asy) ("bash" . sh) ("beamer"
. latex) ("calc" . fundamental) ("cpp" . c++)
("ditaa" . artist) ("dot" . fundamental) ("elisp"
. emacs-lisp) ("ocaml" . tuareg)
("screen" . shell-script) ("shell" . sh) ("sqlite"
. sql))
org-occur-hook '(org-first-headline-recenter)
org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-hide-drawers org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
org-export-before-parsing-hook '(org-attach-expand-links)
org-confirm-shell-link-function 'yes-or-no-p
org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link)
("id" :follow org-id-open) ("eww" :follow
org-eww-open :store org-eww-store-link)
("rmail" :follow org-rmail-open :store
org-rmail-store-link)
("mhe" :follow org-mhe-open :store
org-mhe-store-link)
("irc" :follow org-irc-visit :store
org-irc-store-link :export org-irc-export)
("info" :follow org-info-open :export
org-info-export :store org-info-store-link)
("gnus" :follow org-gnus-open :store
org-gnus-store-link)
("docview" :follow org-docview-open :export
org-docview-export :store
org-docview-store-link)
("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
("bbdb" :follow org-bbdb-open :export
org-bbdb-export :complete org-bbdb-complete-link
:store org-bbdb-store-link)
("w3m" :store org-w3m-store-link) ("file+sys")
("file+emacs")
("shell" :follow org-link--open-shell)
("news" :follow
#[514 "\301\300\302Q\"\207" ["news" browse-url
":"] 6 "\n\n(fn URL ARG)"])
("mailto" :follow
#[514 "\301\300\302Q\"\207" ["mailto" browse-url
":"] 6 "\n\n(fn URL ARG)"])
("https" :follow
#[514 "\301\300\302Q\"\207" ["https" browse-url
":"] 6 "\n\n(fn URL ARG)"])
("http" :follow
#[514 "\301\300\302Q\"\207" ["http" browse-url
":"] 6 "\n\n(fn URL ARG)"])
("ftp" :follow
#[514 "\301\300\302Q\"\207" ["ftp" browse-url
":"] 6 "\n\n(fn URL ARG)"])
("help" :follow org-link--open-help) ("file"
:complete org-link-complete-file)
("elisp" :follow org-link--open-elisp) ("doi"
:follow org-link--open-doi))
org-link-elisp-confirm-function 'yes-or-no-p
)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-24 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-26 17:11 Bug: fill-paragraph in Org buffer [9.4 (9.4-19-gb1de0c-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201019/)] Gustavo Barros
2022-10-22 13:10 ` Gustavo Barros
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.