From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0AUeApcDl1+qBQAA0tVLHw (envelope-from ) for ; Mon, 26 Oct 2020 17:12:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yPymOZYDl1/0NAAA1q6Kng (envelope-from ) for ; Mon, 26 Oct 2020 17:12:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 726FB94036A for ; Mon, 26 Oct 2020 17:12:54 +0000 (UTC) Received: from localhost ([::1]:37306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX63B-00083F-76 for larch@yhetil.org; Mon, 26 Oct 2020 13:12:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX61m-0007Aj-2u for emacs-orgmode@gnu.org; Mon, 26 Oct 2020 13:11:26 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:55564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kX61i-0007O1-DD for emacs-orgmode@gnu.org; Mon, 26 Oct 2020 13:11:25 -0400 Received: by mail-pj1-x1034.google.com with SMTP id c17so3574269pjo.5 for ; Mon, 26 Oct 2020 10:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:user-agent:from:to:subject:message-id:date:mime-version; bh=dtuvhjgoAej2H/9s/uiVAE67s8JpDYNVzNYwAGRUWWg=; b=YIzMet2kCAO2ilUdHygwNT+c0EfG5rBy5nIQGNQI+8d0C+SfqZteJmYiVuR9tMJ3Th bf15dyBULSElRrhlUSl9TvQq4gcAzbv225+Fl0BycuqLE72QIUpd8s1xqUK3OVZRrOxP SXM0oPpRUmTmEuWRjluYQVkBTZ01V1VB/JWzhiDdwhB08cI3kDCayr9xPDF/4WTgMvjx yZD9kKWpyaWFcC1GJnll3U0cXQhVnxJMPxhC2w5enrP5hPsPEZzfx93k12tGozg/sE5z NOHcvN9Wmp39tBSwMh1sYUXmZE79JkEfI04qU1cmsDc+g5k9j9xVglAGeX8XESLJNthm 0wkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:user-agent:from:to:subject:message-id :date:mime-version; bh=dtuvhjgoAej2H/9s/uiVAE67s8JpDYNVzNYwAGRUWWg=; b=WfL8oDfQLv0b5qEKJg2IEMIymsTlWTkW5S+CZsfjca7wy3vW4RctdSox1OqhX0iJIh xNuzyVuqff398GVJEwYQPth1JazxVOUSMKWpHgGuA0Y1AESJC3yDm+FJNWd+yGlmSmri H6gOB8CFd+JH/iJX5DV21GQ5qKySzD8sNoz6fuvPrOJcvNtvn+zvABaNx21Pj87dFfCR ndfpwU235sr8Qs/JtcM/EgpnqSYtJleoweXlfkmpLaX1NKORHfHH1nOlY4knMOU7v3QK SM7IiIVL1TaNxv+95P8UM86uvdKKoQ71cu2PUIzskgBctXvfYbuKixNf5/jBMDJbmU+v uVLw== X-Gm-Message-State: AOAM533z92xjvMtL2t/OhuIJ+LmkR/+HLtqfzlXh5m4Vg+e44zSRFVSG qZ3K1J7wAu/Z44duzCdjgRC8bqWZpvyp7w== X-Google-Smtp-Source: ABdhPJwWB5EjDsGtP5/9EHzHlNFIpcKRbbh0K+6eK4yu6cFCB69iXiwda4tiDPOKdtrjis2UN/OP6g== X-Received: by 2002:a17:90a:294c:: with SMTP id x12mr16879497pjf.27.1603732279141; Mon, 26 Oct 2020 10:11:19 -0700 (PDT) Received: from gusbrs-laptop ([199.116.118.166]) by smtp.gmail.com with ESMTPSA id u14sm13461875pjf.53.2020.10.26.10.11.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 10:11:18 -0700 (PDT) User-agent: mu4e 1.4.13; emacs 27.1 From: Gustavo Barros To: emacs-orgmode@gnu.org Subject: Bug: fill-paragraph in Org buffer [9.4 (9.4-19-gb1de0c-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201019/)] Message-ID: <87lffs52vi.fsf@gmail.com> Date: Mon, 26 Oct 2020 14:11:13 -0300 MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=gusbrs.2016@gmail.com; helo=mail-pj1-x1034.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=YIzMet2k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: ZUHPGQUiY18J Hi All, Calling `fill-paragraph' in an Org buffer may leak paragraph boundaries, and even heading boundaries, and break document structure. I'm aware, of course, of `org-fill-paragraph'. Indeed, `org-mode' both sets `fill-paragraph' function to `org-fill-paragraph' and remaps the `fill-paragraph' binding to `org-fill-paragraph'. If I understand correctly, this is technically redundant, but (a guess) probably the remapping is kept for backwards compatibility reasons. I don't know why this happens. As far as I get, `fill-paragraph' should be calling `fill-paragraph-function', so I'd expect both to do the same thing. But currently they don't. Why would anyone call `fill-paragraph' instead of `org-fill-paragraph'? Well, if you have some paragraph filling tweak you like, you might. For example, one such instance is that widespread "fill-or-unfill" function, which I think started with Artur Malabarba, and was eventually packaged by Steve Purcell in https://github.com/purcell/unfill (180k+ downloads at MELPA). Either way, even when the binding for `fill-paragraph' is remapped to `org-fill-paragraph' it should be at least safe (I think...) to call `fill-paragraph' directly in an Org buffer, even when it might arguably be better to call `org-fill-paragraph'. An ECM to reproduce the issue is: - Start 'emacs -Q' - Do an initial setup: #+begin_src emacs-lisp (add-to-list 'load-path "~/.emacs.d/elpa/org-plus-contrib-20201019") #+end_src - Visit file =test.org= with contents: #+begin_src org ,* Foo - Boo - Baz ,* Bar :PROPERTIES: :CATEGORY: home :CUSTOM_ID: Bar :END: #+end_src - Place point in the "Baz" list item under heading "Foo", and call `M-x org-fill-paragraph'. As expected, the buffer is unchanged. - Now call `M-x fill-paragraph'. The result is: - The result is: #+begin_src org ,* Foo - Boo - Baz ,* Bar :PROPERTIES: :CATEGORY: home :CUSTOM_ID: Bar :END: #+end_src where `fill-paragraph' "filled" the contents of the properties drawer of the following heading, despite three whole blank lines and a heading along the way. Best regards, Gustavo. Emacs : GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2020-08-11 Package: Org mode version 9.4 (9.4-19-gb1de0c-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201019/) current state: ============== (setq org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-link-shell-confirm-function 'yes-or-no-p org-metadown-hook '(org-babel-pop-to-session-maybe) org-clock-out-hook '(org-clock-remove-empty-clock-drawer) org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-all append local] 5] #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes org-eldoc-load) org-archive-hook '(org-attach-archive-delete-maybe) org-confirm-elisp-link-function 'yes-or-no-p org-agenda-before-write-hook '(org-agenda-add-entry-text) org-metaup-hook '(org-babel-load-in-session-maybe) org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"] org-babel-pre-tangle-hook '(save-buffer) org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-agenda-loop-over-headlines-in-active-region nil org-src-lang-modes '(("arduino" . arduino) ("redis" . redis) ("php" . php) ("C" . c) ("C++" . c++) ("asymptote" . asy) ("bash" . sh) ("beamer" . latex) ("calc" . fundamental) ("cpp" . c++) ("ditaa" . artist) ("dot" . fundamental) ("elisp" . emacs-lisp) ("ocaml" . tuareg) ("screen" . shell-script) ("shell" . sh) ("sqlite" . sql)) org-occur-hook '(org-first-headline-recenter) org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate) org-export-before-parsing-hook '(org-attach-expand-links) org-confirm-shell-link-function 'yes-or-no-p org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link) ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link) ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link) ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link) ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link) ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell) ("news" :follow #[514 "\301\300\302Q\"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("mailto" :follow #[514 "\301\300\302Q\"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("https" :follow #[514 "\301\300\302Q\"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("http" :follow #[514 "\301\300\302Q\"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("ftp" :follow #[514 "\301\300\302Q\"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help) ("file" :complete org-link-complete-file) ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi)) org-link-elisp-confirm-function 'yes-or-no-p )