From: "João Távora" <joaotavora@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: "Simen Heggestøyl" <simenheg@runbox.com>,
"Philip K." <philipk@posteo.net>,
61976@debbugs.gnu.org,
"Stefan Monnier" <monnier@iro.umontreal.ca>,
"Noam Postavsky" <npostavs@gmail.com>
Subject: bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29
Date: Tue, 5 Sep 2023 01:07:50 +0100 [thread overview]
Message-ID: <CALDnm52b-UkZgGy+=Ctgeywwx2-Hjh9M9ht5WeDG8BvTow=-Xw@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmY=7QrZaap3U1KDt5kW-VNhR+_4Z+PjX5Tp=H2C3w84A@mail.gmail.com>
On Sat, Sep 2, 2023 at 8:14 PM Stefan Kangas <stefankangas@gmail.com> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> > Can you make a list of the safest/most important ones? (keeping on mind
> > things like backward-compatibility, etc...).
>
> I don't have the bandwidth for a detailed list right now.
>
> This was an easy one I spotted:
>
> https://github.com/joaotavora/yasnippet/pull/1125
Thanks, I merged that one and it indeed fixes the all test failures
on Emacs28.
I still have two new test failures on latest Emacs and I suspect
it's something to do with overlay changes.
Stefan Monnier can you have a look maybe? Could be related to your
overlay changes?
With Emacs 28 this passes:
emacs -Q --batch -L . -l yasnippet-tests.el --eval
'(ert-run-tests-batch-and-exit "issue-824")'
With latest master it doesn't. The issue seems to be a call to
yas-active-snippets which calls overlays-in in where BEG and END
are 1 and which returns no overlays because they have mysteriously
evaporated. But there are no overlays with 'evaporate' properties
that I can detect.
João
next prev parent reply other threads:[~2023-09-05 0:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6404531a.050a0220.40f60.a17aSMTPIN_ADDED_BROKEN@mx.google.com>
2023-09-01 19:46 ` bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29 Stefan Kangas
2023-09-01 21:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 21:16 ` João Távora
2023-09-01 21:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 23:59 ` Stefan Kangas
2023-09-02 4:21 ` João Távora
2023-09-02 19:14 ` Stefan Kangas
2023-09-02 19:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 0:07 ` João Távora [this message]
2023-09-04 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 21:22 ` João Távora
2023-09-04 22:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-05 8:29 Simen Heggestøyl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm52b-UkZgGy+=Ctgeywwx2-Hjh9M9ht5WeDG8BvTow=-Xw@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=61976@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@gmail.com \
--cc=philipk@posteo.net \
--cc=simenheg@runbox.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.