From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29 Date: Tue, 5 Sep 2023 01:07:50 +0100 Message-ID: References: <6404531a.050a0220.40f60.a17aSMTPIN_ADDED_BROKEN@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10037"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Simen =?UTF-8?Q?Heggest=C3=B8yl?= , "Philip K." , 61976@debbugs.gnu.org, Stefan Monnier , Noam Postavsky To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 05 02:06:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdJaC-0002OR-6p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Sep 2023 02:06:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdJa1-0005cj-Jv; Mon, 04 Sep 2023 20:06:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdJZz-0005cM-H9 for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 20:06:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdJZy-0006ki-8n for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 20:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdJZy-0007VI-0u for bug-gnu-emacs@gnu.org; Mon, 04 Sep 2023 20:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 00:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61976-submit@debbugs.gnu.org id=B61976.169387232728797 (code B ref 61976); Tue, 05 Sep 2023 00:06:01 +0000 Original-Received: (at 61976) by debbugs.gnu.org; 5 Sep 2023 00:05:27 +0000 Original-Received: from localhost ([127.0.0.1]:52932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdJZP-0007UP-Gb for submit@debbugs.gnu.org; Mon, 04 Sep 2023 20:05:27 -0400 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:45492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdJZL-0007U6-CJ for 61976@debbugs.gnu.org; Mon, 04 Sep 2023 20:05:26 -0400 Original-Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-4ff9b389677so2986382e87.3 for <61976@debbugs.gnu.org>; Mon, 04 Sep 2023 17:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693872317; x=1694477117; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9Q7gN09q6/Imn14oqBOoHypk4tjfGUl+ae0YC3mSp6E=; b=AIrDjkLdSkCCznJXuSwahV5oji0CVR16jYdcFYqmUJ5d0dWBBJPyCFXnec+6CDGqve Q+nAQmG6i+cO7nxfbsy63YdvZo6KTu4kqM/0jhndPHLSGLRWQrOjPuvJUhoITRSmPF1j jaVpSrs4m0wAxt5Hj6d1qcyG1/2iyhI+RU+/96uVjdz73QZZOgDy0zrlI6olNQqUL8nI otWpBWWM4zos5wppQuJUrPQtk0bkXUqY/DpxcyPLDbiIJ5qgr8GV1nbQuhXl3Xg13udF bp5W0zkbqkZElaAnirQ1ket//C7MlAEU8q0aXodOT4Kylcz1a702pkMTmJgJd8t5c1Qj 2FYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693872317; x=1694477117; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Q7gN09q6/Imn14oqBOoHypk4tjfGUl+ae0YC3mSp6E=; b=DnhPc+9Ks/+R6MBIlxb9Hwe2tys1ye3mbHRts80v/DG29wSX/DndLhK/quvOHDKafz moIbXXudBQLe90WEIMcHwZfL1F6GNuCOAfUDBcU/5pdWjqcUYFNCNMhe89NfWVF8WfgS jST1+aHYkmQvNtmsG0/D36NnWsybVZEpgFrgEWLpfdRrbKohZNZ3jG5ArWE8fKDA3x81 hhZi+eFNGZATs7DhDlITJiz5XU1AtTOAiesEOYlzIayrqC190nCUJBQXsoq9kEyPKdOQ POhqtFCGCplzBCno5MJkHJ8rsAikt5rZCZO1iRLuSahmd5wo8SVz5H+9y7C44Q1bIkVo kL6g== X-Gm-Message-State: AOJu0Yx2FwJs7MUQnqkP7jg7UrnXN+zVwsdAEcvOqIXf5xTkF0RR2gp+ MdhbEwZyYXLU7h6owI5IxV+tbVidjpNeGgL/TT8= X-Google-Smtp-Source: AGHT+IF4HKimAJUHI5IcLVGuS3iWE/P10RidAPCTrmzOuqa7Roo3RlEBm1992YrK+lx23TgHthaixgaD7I1wjtKlTno= X-Received: by 2002:a2e:878c:0:b0:2b9:ac48:d804 with SMTP id n12-20020a2e878c000000b002b9ac48d804mr7996351lji.38.1693872316870; Mon, 04 Sep 2023 17:05:16 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269323 Archived-At: On Sat, Sep 2, 2023 at 8:14=E2=80=AFPM Stefan Kangas wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > Can you make a list of the safest/most important ones? (keeping on mind > > things like backward-compatibility, etc...). > > I don't have the bandwidth for a detailed list right now. > > This was an easy one I spotted: > > https://github.com/joaotavora/yasnippet/pull/1125 Thanks, I merged that one and it indeed fixes the all test failures on Emacs28. I still have two new test failures on latest Emacs and I suspect it's something to do with overlay changes. Stefan Monnier can you have a look maybe? Could be related to your overlay changes? With Emacs 28 this passes: emacs -Q --batch -L . -l yasnippet-tests.el --eval '(ert-run-tests-batch-and-exit "issue-824")' With latest master it doesn't. The issue seems to be a call to yas-active-snippets which calls overlays-in in where BEG and END are 1 and which returns no overlays because they have mysteriously evaporated. But there are no overlays with 'evaporate' properties that I can detect. Jo=C3=A3o