From: "Simen Heggestøyl" <simenheg@runbox.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 61976@debbugs.gnu.org
Subject: bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29
Date: Sun, 05 Mar 2023 09:29:01 +0100 [thread overview]
Message-ID: <43894.644132682$1678005025@news.gmane.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Hi. The attached patch fixes the compilation warnings in yasnippet.el
when compiling with Emacs 29.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-compilation-warnings-in-Emacs-29.patch --]
[-- Type: text/x-diff, Size: 3390 bytes --]
From a5a9254f35dd85f6b945fc274fd020e887949e07 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@runbox.com>
Date: Sun, 5 Mar 2023 08:44:01 +0100
Subject: [PATCH] Fix compilation warnings in Emacs 29
---
yasnippet.el | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/yasnippet.el b/yasnippet.el
index 78ef38ac39..0129087805 100644
--- a/yasnippet.el
+++ b/yasnippet.el
@@ -476,14 +476,15 @@ See also Info node `(elisp) Syntax Descriptors'.")
'()
"Hooks to run after a snippet exited.
-The hooks will be run in an environment where some variables bound to
-proper values:
+The hooks will be run in an environment where some variables are
+bound to proper values:
`yas-snippet-beg' : The beginning of the region of the snippet.
`yas-snippet-end' : Similar to beg.
-Attention: These hooks are not run when exiting nested/stacked snippet expansion!")
+Attention: These hooks are not run when exiting nested/stacked
+snippet expansion!")
(defvar yas-before-expand-snippet-hook
'()
@@ -555,7 +556,7 @@ conditions.
sexp))
(defcustom yas-keymap-disable-hook nil
- "The `yas-keymap' bindings are disabled if any function in this list returns non-nil.
+ "Disable `yas-keymap' bindings if any function in this list returns non-nil.
This is useful to control whether snippet navigation bindings
override bindings from other packages (e.g., `company-mode')."
:type 'hook)
@@ -1813,7 +1814,8 @@ Optional PROMPT sets the prompt to use."
SNIPPETS is a list of snippet definitions, each taking the
following form
- (KEY TEMPLATE NAME CONDITION GROUP EXPAND-ENV LOAD-FILE KEYBINDING UUID SAVE-FILE)
+ (KEY TEMPLATE NAME CONDITION GROUP EXPAND-ENV LOAD-FILE
+ KEYBINDING UUID SAVE-FILE)
Within these, only KEY and TEMPLATE are actually mandatory.
@@ -2980,7 +2982,7 @@ marks it as something else (typically comment ender)."
'again))
(defun yas-longest-key-from-whitespace (start-point)
- "As `yas-key-syntaxes' element, look for longest key between point and whitespace.
+ "As `yas-key-syntaxes' element, find longest key between point and whitespace.
A newline will be considered whitespace even if the mode syntax
marks it as something else (typically comment ender)."
@@ -3728,8 +3730,8 @@ Use as a `:filter' argument for a conditional keybinding."
"Clears unmodified field if at field start, skips to next tab.
Otherwise deletes a character normally by calling `delete-char'."
- (interactive)
(declare (obsolete "Bind to `yas-maybe-skip-and-clear-field' instead." "0.13"))
+ (interactive)
(cond ((yas--maybe-clear-field-filter t)
(yas--skip-and-clear (or field (yas-current-field)))
(yas-next-field 1))
@@ -4740,9 +4742,11 @@ The following count as a field:
* \"${n: text}\", for a numbered field with default text, as long as N is not 0;
* \"${n: text$(expression)}, the same with a Lisp expression;
- this is caught with the curiously named `yas--multi-dollar-lisp-expression-regexp'
+ this is caught with the curiously named
+ `yas--multi-dollar-lisp-expression-regexp'
-* the same as above but unnumbered, (no N:) and number is calculated automatically.
+* the same as above but unnumbered, (no N:) and number is
+ calculated automatically.
When multiple expressions are found, only the last one counts."
;;
--
2.39.1
[-- Attachment #3: Type: text/plain, Size: 10 bytes --]
-- Simen
next reply other threads:[~2023-03-05 8:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 8:29 Simen Heggestøyl [this message]
[not found] <6404531a.050a0220.40f60.a17aSMTPIN_ADDED_BROKEN@mx.google.com>
2023-09-01 19:46 ` bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29 Stefan Kangas
2023-09-01 21:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 21:16 ` João Távora
2023-09-01 21:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-01 23:59 ` Stefan Kangas
2023-09-02 4:21 ` João Távora
2023-09-02 19:14 ` Stefan Kangas
2023-09-02 19:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 0:07 ` João Távora
2023-09-04 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 21:22 ` João Távora
2023-09-04 22:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='43894.644132682$1678005025@news.gmane.org' \
--to=simenheg@runbox.com \
--cc=61976@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.