From: "João Távora" <joaotavora@gmail.com>
To: miha@kamnitnik.top
Cc: Michael Albinus <michael.albinus@gmx.de>, 62194@debbugs.gnu.org
Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29
Date: Wed, 15 Mar 2023 20:45:47 +0000 [thread overview]
Message-ID: <CALDnm50YjHKg+TDJ3yxmnGyrEaZAxqEqSgihzLEbGfKFCo97nQ@mail.gmail.com> (raw)
In-Reply-To: <875yb1pxai.fsf@miha-pc>
On Wed, Mar 15, 2023 at 8:31 PM <miha@kamnitnik.top> wrote:
>
> (dolist (p (delq proc (process-list)))
> (when (tramp-file-name-equal-p v (process-get p 'vector))
> THIS --> (accept-process-output p 0 nil t))))
>
> I'm somewhat against these additional accept-process-output calls. While
> we do limit them to processes from the same ssh connection, I'd argue
> that usually, such processes aren't really related to the main tramp ssh
> process. They could be a random *shell* process that doesn't really
> belong to tramp.el any more IMO. Or in this case, eglot's jsonrpc
> process.
I'm "against" this too, but hard facts here trump arguments and opinion.
This is exactly what fixes the ControlMaster hang, that's well understood,
and is really intended. It brings about some other failures but I've just
confirmed that if you put
(while (accept-process-output p 0 nil t))
then all's well.
Of course, it's only _one_ of the ways to fix the problem. If you have another
more elegant one, but I don't know if signals is a great one. I'd guess
SIGWINCH to be somewhat limited in platform support, right?
João
next prev parent reply other threads:[~2023-03-15 20:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 23:08 bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 João Távora
2023-03-15 9:40 ` Michael Albinus
2023-03-15 11:45 ` Michael Albinus
2023-03-15 20:24 ` João Távora
2023-03-15 20:36 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-15 20:45 ` João Távora [this message]
2023-03-16 12:02 ` Michael Albinus
2023-03-16 12:20 ` João Távora
2023-03-16 14:57 ` Michael Albinus
2023-03-16 15:12 ` João Távora
2023-03-16 17:35 ` Michael Albinus
2023-03-16 17:59 ` João Távora
2023-03-16 21:18 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 21:57 ` João Távora
2023-03-16 23:38 ` João Távora
2023-03-17 16:45 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 16:47 ` Eli Zaretskii
2023-03-17 17:22 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 17:22 ` Eli Zaretskii
2023-03-17 10:44 ` Michael Albinus
2023-03-17 11:19 ` João Távora
2023-03-18 9:38 ` Michael Albinus
2023-03-18 11:29 ` João Távora
2023-03-18 12:23 ` Michael Albinus
2023-03-18 12:33 ` João Távora
2023-03-19 12:19 ` Michael Albinus
2023-03-15 20:16 ` João Távora
2023-03-16 15:02 ` Michael Albinus
2023-03-28 10:51 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50YjHKg+TDJ3yxmnGyrEaZAxqEqSgihzLEbGfKFCo97nQ@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=62194@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=miha@kamnitnik.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.