From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Wed, 15 Mar 2023 20:45:47 +0000 Message-ID: References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> <875yb1pxai.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus , 62194@debbugs.gnu.org To: miha@kamnitnik.top Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 15 21:45:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcXzo-0007lf-Av for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Mar 2023 21:45:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcXzd-0000Cv-Tj; Wed, 15 Mar 2023 16:45:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcXzb-0000BA-Bi for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 16:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcXza-0007wi-MA for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 16:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcXza-0001Lg-9s for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 16:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Mar 2023 20:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.16789130435036 (code B ref 62194); Wed, 15 Mar 2023 20:45:02 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 15 Mar 2023 20:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:40623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcXyd-0001JA-D2 for submit@debbugs.gnu.org; Wed, 15 Mar 2023 16:44:03 -0400 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:34334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcXyc-0001IS-7T for 62194@debbugs.gnu.org; Wed, 15 Mar 2023 16:44:02 -0400 Original-Received: by mail-oi1-f177.google.com with SMTP id w133so2981765oib.1 for <62194@debbugs.gnu.org>; Wed, 15 Mar 2023 13:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678913036; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Lutn3Pqm2a78/bxsX7aXadwdFwEurH00hSJHbx5rTH4=; b=QdqaDQFpJfgQ+mOLT6L2EAQUDVAQFxz5Y6gTJ6UJwsu2uGNOZlH01NfpeRrd7BYLRc 9upEQWRbSu0GFEp9nBu5OXE8ym88112S/1p3hFq/TYuPg8fLHr/+UTXRoImME2X6wq3o FCvaUBts/DTRak/Iz+0ZmcKd6FZH2L01UD2SWNM0aAYrZvyXT74UPl1IINS+dc1IIZP9 dI/3RAA7gNZxB5vThE1ZXvdtG01x4M7xqdoydJhm2W6qgoxN1k3he9yaqJFGKy3WtPb/ MKJBXWuSiJs8185/akYLgeYcoUz3KLlywed87CZOy7hBlqdpoETy87E3mjamN+dvI2Ai IU+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678913036; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lutn3Pqm2a78/bxsX7aXadwdFwEurH00hSJHbx5rTH4=; b=UKocEsGEEntKmzzwg4DS5H+JR/7cTwa03VGliYapXD713IZGLhYRcZRUb5nWWwTi3l MS0nAsRaHNPHU4bJqOQX33pFmEY4Zow2yBvAftkYj0WL6nazZPJMKct46WAD0edmwLpM KW75vK2hwEC7e7Uyk4tsPsFrURmdTpu8Noel4f2E4mkgSze7U8C0JiSLI8ioT9TTdOVy cNgsMbGbGPJLim7SMveEankERgY1eUyr3+NZ6FNQpGuBRfvZjAzXbnssWFGS4GHblrIo otDQnw5UzAl3os5Zh++oP0m0BtS0eiSf+DC/aOSnBxOkkXDhmcuvUgZH3oBWe9kIsyxr 8fVA== X-Gm-Message-State: AO0yUKU0IckW+UPlLPCgu++VI0x4EQoeWlCDms2PiV+VF2cYJYQVTIgE CcK5BHeuAtK3oGB49dBNl5KlATdiEr2BGRSNiXo= X-Google-Smtp-Source: AK7set9r2nbH/ooEWV8Ch/Wal7frYAkOZXXa632aXV720z6cwA2FFOd0JlLt117VZilukNH3yDPZGTnlqZAgOVKehRM= X-Received: by 2002:a05:6808:3013:b0:383:f981:b1e5 with SMTP id ay19-20020a056808301300b00383f981b1e5mr1585787oib.5.1678913036643; Wed, 15 Mar 2023 13:43:56 -0700 (PDT) In-Reply-To: <875yb1pxai.fsf@miha-pc> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257987 Archived-At: On Wed, Mar 15, 2023 at 8:31=E2=80=AFPM wrote: > > (dolist (p (delq proc (process-list))) > (when (tramp-file-name-equal-p v (process-get p 'vector)) > THIS --> (accept-process-output p 0 nil t)))) > > I'm somewhat against these additional accept-process-output calls. While > we do limit them to processes from the same ssh connection, I'd argue > that usually, such processes aren't really related to the main tramp ssh > process. They could be a random *shell* process that doesn't really > belong to tramp.el any more IMO. Or in this case, eglot's jsonrpc > process. I'm "against" this too, but hard facts here trump arguments and opinion. This is exactly what fixes the ControlMaster hang, that's well understood, and is really intended. It brings about some other failures but I've just confirmed that if you put (while (accept-process-output p 0 nil t)) then all's well. Of course, it's only _one_ of the ways to fix the problem. If you have ano= ther more elegant one, but I don't know if signals is a great one. I'd guess SIGWINCH to be somewhat limited in platform support, right? Jo=C3=A3o