all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 62194@debbugs.gnu.org
Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29
Date: Wed, 15 Mar 2023 20:24:41 +0000	[thread overview]
Message-ID: <87v8j14vau.fsf@gmail.com> (raw)
In-Reply-To: <874jqmjl0s.fsf@gmx.de> (Michael Albinus's message of "Wed, 15 Mar 2023 12:45:23 +0100")

merge 62194 61350
thanks

Michael Albinus <michael.albinus@gmx.de> writes:

> So I reommend the following:
>
> - At least in 'eglot--call-with-tramp-test', better in your Eglot
>   package, suppress vc related checks, by binding
>
>   (let ((vc-ignore-dir-regexp
>          (format "\\(%s\\)\\|\\(%s\\)"
>                  vc-ignore-dir-regexp
>                  tramp-file-name-regexp)))
>      ...)
>
> - If this works sufficiently, this bug shall be either closed, or merged
>   with bug#60534, which tracks this error.

I don't think I should be doing something this in eglot-tests.el,
because the tests pass on emacs-29 and this failure was introduced
very recently.

I've just confirmed inequivocally that these failures are direct fallout
from the fix to bug#61350, so I'm merging the two bugs: 62194 and 61350.

As I wrote in bug#61350, if I revert that commit and apply the simpler
patch that we discussed, everything's good, and I can remove the
ControlMaster supression workaround in Eglot, too.

João

diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 47173b95bea..885b29f9471 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -5800,6 +5800,11 @@ tramp-accept-process-output
 This is needed in order to hide `last-coding-system-used', which is set
 for process communication also.
 If the user quits via `C-g', it is propagated up to `tramp-file-name-handler'."
+  (when-let (((process-get proc 'shared-socket))
+	     (v (process-get proc 'vector)))
+    (dolist (p (delq proc (process-list)))
+      (when (tramp-file-name-equal-p v (process-get p 'vector))
+	(while (accept-process-output p 0 nil t)))))
   (with-current-buffer (process-buffer proc)
     (let ((inhibit-read-only t)
 	  last-coding-system-used








  reply	other threads:[~2023-03-15 20:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 23:08 bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 João Távora
2023-03-15  9:40 ` Michael Albinus
2023-03-15 11:45   ` Michael Albinus
2023-03-15 20:24     ` João Távora [this message]
2023-03-15 20:36     ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-15 20:45       ` João Távora
2023-03-16 12:02         ` Michael Albinus
2023-03-16 12:20           ` João Távora
2023-03-16 14:57             ` Michael Albinus
2023-03-16 15:12               ` João Távora
2023-03-16 17:35                 ` Michael Albinus
2023-03-16 17:59                   ` João Távora
2023-03-16 21:18                     ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 21:57                       ` João Távora
2023-03-16 23:38                         ` João Távora
2023-03-17 16:45                         ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 16:47                           ` Eli Zaretskii
2023-03-17 17:22                             ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 17:22                               ` Eli Zaretskii
2023-03-17 10:44                     ` Michael Albinus
2023-03-17 11:19                       ` João Távora
2023-03-18  9:38                         ` Michael Albinus
2023-03-18 11:29                           ` João Távora
2023-03-18 12:23                             ` Michael Albinus
2023-03-18 12:33                               ` João Távora
2023-03-19 12:19                           ` Michael Albinus
2023-03-15 20:16   ` João Távora
2023-03-16 15:02     ` Michael Albinus
2023-03-28 10:51       ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8j14vau.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=62194@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.