* Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter [not found] ` <20230112185953.C337AC004FD@vcs2.savannah.gnu.org> @ 2023-01-23 22:32 ` Basil L. Contovounesios 2023-01-27 10:22 ` Stefan Kangas 0 siblings, 1 reply; 6+ messages in thread From: Basil L. Contovounesios @ 2023-01-23 22:32 UTC (permalink / raw) To: emacs-devel; +Cc: Matthew Bauer, Philip Kaludercic ELPA Syncer [2023-01-12 13:59 -0500] wrote: > branch: elpa/nix-mode > commit 91a317e425be15b03d31d404d798c21faf373113 > Merge: 54e5626829 fb6c1ca5dd > Author: Matthew Bauer <mjbauer95@gmail.com> > Commit: GitHub <noreply@github.com> > > Merge pull request #176 from lafrenierejm/reformatter > > Replace custom `nixfmt` wrapping with `reformatter` [...] > diff --git a/nix-format.el b/nix-format.el > index 75e679e46e..679ad02629 100644 > --- a/nix-format.el > +++ b/nix-format.el > @@ -3,54 +3,29 @@ > ;; This file is NOT part of GNU Emacs. > > ;; Homepage: https://github.com/NixOS/nix-mode > -;; Package-Requires: ((emacs "24.1")) > +;; Package-Requires: ((emacs "24.1") (reformatter "0.6")) Just curious: is it okay in this case for a NonGNU ELPA package to depend unconditionally on a MELPA package? Maybe reformatter can/should also be distributed via NonGNU ELPA? Thanks, -- Basil ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter 2023-01-23 22:32 ` [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter Basil L. Contovounesios @ 2023-01-27 10:22 ` Stefan Kangas 2023-01-29 5:18 ` Richard Stallman 2023-02-08 23:31 ` Matthew Bauer 0 siblings, 2 replies; 6+ messages in thread From: Stefan Kangas @ 2023-01-27 10:22 UTC (permalink / raw) To: Basil L. Contovounesios, emacs-devel Cc: Matthew Bauer, Philip Kaludercic, Steve Purcell "Basil L. Contovounesios" <contovob@tcd.ie> writes: >> diff --git a/nix-format.el b/nix-format.el >> index 75e679e46e..679ad02629 100644 >> --- a/nix-format.el >> +++ b/nix-format.el >> @@ -3,54 +3,29 @@ >> ;; This file is NOT part of GNU Emacs. >> >> ;; Homepage: https://github.com/NixOS/nix-mode >> -;; Package-Requires: ((emacs "24.1")) >> +;; Package-Requires: ((emacs "24.1") (reformatter "0.6")) > > Just curious: is it okay in this case for a NonGNU ELPA package to > depend unconditionally on a MELPA package? No, that is not okay as it makes the package uninstallable. > Maybe reformatter can/should also be distributed via NonGNU ELPA? I think that is the best solution here, yes. Patches welcome, but meanwhile perhaps this should be reported as a bug so we don't lose track of it. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter 2023-01-27 10:22 ` Stefan Kangas @ 2023-01-29 5:18 ` Richard Stallman 2023-01-30 6:50 ` Stefan Kangas 2023-02-08 23:31 ` Matthew Bauer 1 sibling, 1 reply; 6+ messages in thread From: Richard Stallman @ 2023-01-29 5:18 UTC (permalink / raw) To: Stefan Kangas; +Cc: emacs-devel [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > Maybe reformatter can/should also be distributed via NonGNU ELPA? > I think that is the best solution here, yes. That is ok if reformatter meets the criteria for NonGNU ELPA, and presuming we want to distribute it. I don't know the facts for the former and I have no opinion about the latter. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter 2023-01-29 5:18 ` Richard Stallman @ 2023-01-30 6:50 ` Stefan Kangas 0 siblings, 0 replies; 6+ messages in thread From: Stefan Kangas @ 2023-01-30 6:50 UTC (permalink / raw) To: rms; +Cc: emacs-devel Richard Stallman <rms@gnu.org> writes: > > > Maybe reformatter can/should also be distributed via NonGNU ELPA? > > > I think that is the best solution here, yes. > > That is ok if reformatter meets the criteria for NonGNU ELPA, AFAICT, it does. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter 2023-01-27 10:22 ` Stefan Kangas 2023-01-29 5:18 ` Richard Stallman @ 2023-02-08 23:31 ` Matthew Bauer 2023-02-09 11:17 ` Basil L. Contovounesios 1 sibling, 1 reply; 6+ messages in thread From: Matthew Bauer @ 2023-02-08 23:31 UTC (permalink / raw) To: Stefan Kangas, emacs-devel; +Cc: Basil L. Contovounesios, Philip Kaludercic [-- Attachment #1: Type: text/plain, Size: 386 bytes --] > I think that is the best solution here, yes. Patches welcome, but > meanwhile perhaps this should be reported as a bug so we don't lose > track of it. To clarify, you are saying nix-mode should not depend on reformatter for it to work in ELPA? We can definitely revert the commit that introduced reformatter and avoid the dependency, but I want to make sure I understand correctly. [-- Attachment #2: Type: text/html, Size: 504 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter 2023-02-08 23:31 ` Matthew Bauer @ 2023-02-09 11:17 ` Basil L. Contovounesios 0 siblings, 0 replies; 6+ messages in thread From: Basil L. Contovounesios @ 2023-02-09 11:17 UTC (permalink / raw) To: Matthew Bauer; +Cc: Stefan Kangas, emacs-devel, Philip Kaludercic Matthew Bauer [2023-02-08 17:31 -0600] wrote: >> I think that is the best solution here, yes. Patches welcome, but >> meanwhile perhaps this should be reported as a bug so we don't lose >> track of it. > > To clarify, you are saying nix-mode should not depend on reformatter for it to work in ELPA? Yes, there should be no hard dependency, at least while reformatter continues to be unavailable in Emacs proper, GNU ELPA, or NonGNU ELPA. Meanwhile, it is okay for nix-mode to use reformatter on the condition that the latter is already installed, as an optional dependency. > We can definitely revert the commit that introduced reformatter and avoid the dependency, > but I want to make sure I understand correctly. That's one option, but another solution is for reformatter to be added to [Non]GNU ELPA, assuming its author and the [Non]GNU ELPA maintainers are in favour of that (I have not yet found the time to pursue this). Thanks, -- Basil ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-09 11:17 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <167354999339.24083.12015066505244176362@vcs2.savannah.gnu.org> [not found] ` <20230112185953.C337AC004FD@vcs2.savannah.gnu.org> 2023-01-23 22:32 ` [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter Basil L. Contovounesios 2023-01-27 10:22 ` Stefan Kangas 2023-01-29 5:18 ` Richard Stallman 2023-01-30 6:50 ` Stefan Kangas 2023-02-08 23:31 ` Matthew Bauer 2023-02-09 11:17 ` Basil L. Contovounesios
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.