Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter

Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter

[Basil L. Contovounesios]

ELPA Syncer [2023-01-12 13:59 -0500] wrote:

> branch: elpa/nix-mode
> commit 91a317e425be15b03d31d404d798c21faf373113
> Merge: 54e5626829 fb6c1ca5dd
> Author: Matthew Bauer <mjbauer95@gmail.com>
> Commit: GitHub <noreply@github.com>
>
>     Merge pull request #176 from lafrenierejm/reformatter
>     
>     Replace custom `nixfmt` wrapping with `reformatter`
[...]
> diff --git a/nix-format.el b/nix-format.el
> index 75e679e46e..679ad02629 100644
> --- a/nix-format.el
> +++ b/nix-format.el
> @@ -3,54 +3,29 @@
>  ;; This file is NOT part of GNU Emacs.
>  
>  ;; Homepage: https://github.com/NixOS/nix-mode
> -;; Package-Requires: ((emacs "24.1"))
> +;; Package-Requires: ((emacs "24.1") (reformatter "0.6"))

Just curious: is it okay in this case for a NonGNU ELPA package to
depend unconditionally on a MELPA package?  Maybe reformatter can/should
also be distributed via NonGNU ELPA?

Thanks,

-- 
Basil

Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter

[Stefan Kangas]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

>> diff --git a/nix-format.el b/nix-format.el
>> index 75e679e46e..679ad02629 100644
>> --- a/nix-format.el
>> +++ b/nix-format.el
>> @@ -3,54 +3,29 @@
>>  ;; This file is NOT part of GNU Emacs.
>>
>>  ;; Homepage: https://github.com/NixOS/nix-mode
>> -;; Package-Requires: ((emacs "24.1"))
>> +;; Package-Requires: ((emacs "24.1") (reformatter "0.6"))
>
> Just curious: is it okay in this case for a NonGNU ELPA package to
> depend unconditionally on a MELPA package?

No, that is not okay as it makes the package uninstallable.

> Maybe reformatter can/should also be distributed via NonGNU ELPA?

I think that is the best solution here, yes.  Patches welcome, but
meanwhile perhaps this should be reported as a bug so we don't lose
track of it.

Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > Maybe reformatter can/should also be distributed via NonGNU ELPA?

  > I think that is the best solution here, yes.

That is ok if reformatter meets the criteria for NonGNU ELPA,
and presuming we want to distribute it.  I don't know the facts
for the former and I have no opinion about the latter.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter

[Stefan Kangas]

Richard Stallman <rms@gnu.org> writes:

>   > > Maybe reformatter can/should also be distributed via NonGNU ELPA?
>
>   > I think that is the best solution here, yes.
>
> That is ok if reformatter meets the criteria for NonGNU ELPA,

AFAICT, it does.

Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter

[Matthew Bauer]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

> I think that is the best solution here, yes.  Patches welcome, but
> meanwhile perhaps this should be reported as a bug so we don't lose
> track of it.

To clarify, you are saying nix-mode should not depend on reformatter for it
to work in ELPA?
We can definitely revert the commit that introduced reformatter and avoid
the dependency,
but I want to make sure I understand correctly.

[-- Attachment #2: Type: text/html, Size: 504 bytes --]

Re: [nongnu] elpa/nix-mode 91a317e425 2/2: Merge pull request #176 from lafrenierejm/reformatter

[Basil L. Contovounesios]

Matthew Bauer [2023-02-08 17:31 -0600] wrote:

>> I think that is the best solution here, yes.  Patches welcome, but
>> meanwhile perhaps this should be reported as a bug so we don't lose
>> track of it.
>
> To clarify, you are saying nix-mode should not depend on reformatter for it to work in ELPA?

Yes, there should be no hard dependency, at least while reformatter
continues to be unavailable in Emacs proper, GNU ELPA, or NonGNU ELPA.

Meanwhile, it is okay for nix-mode to use reformatter on the condition
that the latter is already installed, as an optional dependency.

> We can definitely revert the commit that introduced reformatter and avoid the dependency,
> but I want to make sure I understand correctly.

That's one option, but another solution is for reformatter to be added
to [Non]GNU ELPA, assuming its author and the [Non]GNU ELPA maintainers
are in favour of that (I have not yet found the time to pursue this).

Thanks,

-- 
Basil