bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[lu4nx]

---
 lib-src/emacsclient.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
index af488128ba..a0c5b84bc5 100644
--- a/lib-src/emacsclient.c
+++ b/lib-src/emacsclient.c
@@ -1669,10 +1669,10 @@ set_socket (bool no_exit_if_error)
   /* No implicit or explicit socket, and no alternate editor.  */
   message (true, "%s: No socket or alternate editor.  Please use:\n\n"
 #ifdef SOCKETS_IN_FILE_SYSTEM
-"\t--socket-name\n"
+"\t--socket-name=SOCKET\n"
 #endif
-"\t--server-file      (or environment variable EMACS_SERVER_FILE)\n\
-\t--alternate-editor (or environment variable ALTERNATE_EDITOR)\n",
+"\t--server-file=SERVER      (or environment variable EMACS_SERVER_FILE)\n\
+\t--alternate-editor=EDITOR (or environment variable ALTERNATE_EDITOR)\n",
            progname);
   exit (EXIT_FAILURE);
 }
-- 
2.38.1

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[Eli Zaretskii]

> Cc: lu4nx <lx@shellcodes.org>
> From: lu4nx <lx@shellcodes.org>
> Date: Sun, 11 Dec 2022 17:32:32 +0800
> 
> ---
>  lib-src/emacsclient.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
> index af488128ba..a0c5b84bc5 100644
> --- a/lib-src/emacsclient.c
> +++ b/lib-src/emacsclient.c
> @@ -1669,10 +1669,10 @@ set_socket (bool no_exit_if_error)
>    /* No implicit or explicit socket, and no alternate editor.  */
>    message (true, "%s: No socket or alternate editor.  Please use:\n\n"
>  #ifdef SOCKETS_IN_FILE_SYSTEM
> -"\t--socket-name\n"
> +"\t--socket-name=SOCKET\n"
>  #endif
> -"\t--server-file      (or environment variable EMACS_SERVER_FILE)\n\
> -\t--alternate-editor (or environment variable ALTERNATE_EDITOR)\n",
> +"\t--server-file=SERVER      (or environment variable EMACS_SERVER_FILE)\n\
> +\t--alternate-editor=EDITOR (or environment variable ALTERNATE_EDITOR)\n",
>             progname);
>    exit (EXIT_FAILURE);
>  }

The --help message already says that.  Why do we need that in an error
message as well?

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[lux]

On Sun, 11 Dec 2022 12:26:16 +0200
Eli Zaretskii <eliz@gnu.org> wrote:

> The --help message already says that.  Why do we need that in an error
> message as well?

Because when I forgot `server-start`, the information given was not
intuitive enough, and I needed to use `--help` again. And these three
parameters themselves need to provide value, so adding them will be
more intuitive. Thanks.

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[lux]

lux <lx@shellcodes.org> writes:

> On Sun, 11 Dec 2022 12:26:16 +0200
> Eli Zaretskii <eliz@gnu.org> wrote:
>
>> The --help message already says that.  Why do we need that in an error
>> message as well?
>
> Because when I forgot `server-start`, the information given was not
> intuitive enough, and I needed to use `--help` again. And these three
> parameters themselves need to provide value, so adding them will be
> more intuitive. Thanks.

Hi, this question seems to be forgotten?

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[Eli Zaretskii]

> From: lux <lx@shellcodes.org>
> Cc: 59961@debbugs.gnu.org
> Date: Sun, 15 Jan 2023 18:16:43 +0800
> 
> lux <lx@shellcodes.org> writes:
> 
> > On Sun, 11 Dec 2022 12:26:16 +0200
> > Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> The --help message already says that.  Why do we need that in an error
> >> message as well?
> >
> > Because when I forgot `server-start`, the information given was not
> > intuitive enough, and I needed to use `--help` again. And these three
> > parameters themselves need to provide value, so adding them will be
> > more intuitive. Thanks.
> 
> Hi, this question seems to be forgotten?

No, not forgotten.  I just don't think we should make this change, as
the text says which features/options to use, not how to use them.

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: lux <lx@shellcodes.org>
>> Cc: 59961@debbugs.gnu.org
>> Date: Sun, 15 Jan 2023 18:16:43 +0800
>>
>> lux <lx@shellcodes.org> writes:
>>
>> > On Sun, 11 Dec 2022 12:26:16 +0200
>> > Eli Zaretskii <eliz@gnu.org> wrote:
>> >
>> >> The --help message already says that.  Why do we need that in an error
>> >> message as well?
>> >
>> > Because when I forgot `server-start`, the information given was not
>> > intuitive enough, and I needed to use `--help` again. And these three
>> > parameters themselves need to provide value, so adding them will be
>> > more intuitive. Thanks.
>>
>> Hi, this question seems to be forgotten?
>
> No, not forgotten.  I just don't think we should make this change, as
> the text says which features/options to use, not how to use them.

What's the drawback to being a bit more helpful though?

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[Eli Zaretskii]

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Wed, 10 Jan 2024 14:35:00 -0800
> Cc: lux <lx@shellcodes.org>, 59961@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: lux <lx@shellcodes.org>
> >> Cc: 59961@debbugs.gnu.org
> >> Date: Sun, 15 Jan 2023 18:16:43 +0800
> >>
> >> lux <lx@shellcodes.org> writes:
> >>
> >> > On Sun, 11 Dec 2022 12:26:16 +0200
> >> > Eli Zaretskii <eliz@gnu.org> wrote:
> >> >
> >> >> The --help message already says that.  Why do we need that in an error
> >> >> message as well?
> >> >
> >> > Because when I forgot `server-start`, the information given was not
> >> > intuitive enough, and I needed to use `--help` again. And these three
> >> > parameters themselves need to provide value, so adding them will be
> >> > more intuitive. Thanks.
> >>
> >> Hi, this question seems to be forgotten?
> >
> > No, not forgotten.  I just don't think we should make this change, as
> > the text says which features/options to use, not how to use them.
> 
> What's the drawback to being a bit more helpful though?

The message becomes longer.  And it only added the info to the
command-line options, but not to the corresponding environment
variables.  Finally, the meaning of SOCKET and SERVER are never
explained.

So it simply sounded to me like a personal issue that is not
necessarily relevant to everyone else.

bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information.

[Stefan Kangas]

tags 59961 + wontfix
close 59961
thanks

Eli Zaretskii <eliz@gnu.org> writes:

> The message becomes longer.  And it only added the info to the
> command-line options, but not to the corresponding environment
> variables.  Finally, the meaning of SOCKET and SERVER are never
> explained.
>
> So it simply sounded to me like a personal issue that is not
> necessarily relevant to everyone else.

Taking another look, I can see where you're coming from.  Adding more
text doesn't add significant information in this case, and it does make
it longer.

I'm closing the bug as wontfix, with apologies to lux for not accepting
the patch.  Thanks for sending it.