From: Stefan Kangas <stefankangas@gmail.com>
To: Matt Armstrong <matt@rfc20.org>
Cc: 58801-done@debbugs.gnu.org
Subject: bug#58801: [PATCH] Autoload the `calc-eval-error' variable
Date: Sun, 5 Nov 2023 08:38:21 -0800 [thread overview]
Message-ID: <CADwFkmktBD8jbDxqoFR0Kp-qKpxTzbYiikPHB+juAH=SNGb3pg@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=MFk2woDoa7P+kUV4QdcKgW1kketRF_ox1Z+nh=-TW8Q@mail.gmail.com>
Version: 30.1
Stefan Kangas <stefankangas@gmail.com> writes:
> We typically avoid autoloading variables, and I'm not sure it's
> justified here. See (info "(elisp) When to Autoload") for details.
>
> Could we instead just declare it in calc.el? I believe that should
> silence any warnings from the byte-compiler. It's a one line change:
>
> (defvar calc-eval-error)
>
> Or will that not work in your use case for some reason?
>
>> (In the particular case of the Calc package, dozens of functions and
>> variables are already autoloaded. The omission of `calc-eval-error'
>> also seems more an oversight than intentional.)
>
> FWIW, I couldn't find any autoloaded variables in calc-loaddefs.el.
> What am I missing?
No further comments here within 2 months, so I've pushed the above
proposed fix to master, and I'm closing this bug.
If this is still an issue, please reply to this email (use "Reply to
all" in your email client) and we can reopen the bug report.
[1: ad82bc9b29e]: 2023-11-05 17:36:21 +0100
Declare calc-eval-error in calc.el
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ad82bc9b29eacad29a441bbb4e87bd09ef1ff1c4
prev parent reply other threads:[~2023-11-05 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 17:02 bug#58801: [PATCH] Autoload the `calc-eval-error' variable Matt Armstrong
2022-11-11 13:16 ` Stefan Kangas
2022-11-15 18:24 ` Matt Armstrong
2022-11-15 18:42 ` Eli Zaretskii
2022-11-24 19:50 ` Stefan Kangas
2022-11-26 16:58 ` Matt Armstrong
2023-09-07 7:51 ` Stefan Kangas
2023-11-05 16:38 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmktBD8jbDxqoFR0Kp-qKpxTzbYiikPHB+juAH=SNGb3pg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=58801-done@debbugs.gnu.org \
--cc=matt@rfc20.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.