From: Matt Armstrong <matt@rfc20.org>
To: 58801@debbugs.gnu.org
Subject: bug#58801: [PATCH] Autoload the `calc-eval-error' variable
Date: Wed, 26 Oct 2022 10:02:50 -0700 [thread overview]
Message-ID: <87fsfaa56t.fsf@rfc20.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
Tags: patch
(rationale in the patch)
In GNU Emacs 29.0.50 (build 8, x86_64-pc-linux-gnu, GTK+ Version
3.24.34, cairo version 1.16.0) of 2022-10-25 built on naz
Repository revision: 9d7ba2b1998afc3664c37d9d1b6f6ca2d68356e9
Repository branch: feature/noverlay
System Description: Debian GNU/Linux bookworm/sid
Configured using:
'configure 'CFLAGS=-Og -g3' 'CXXFLAGS=-Og -g3' --enable-checking=yes
--enable-check-lisp-object-type --with-pgtk'
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Autoload-the-calc-eval-error-variable.patch --]
[-- Type: text/patch, Size: 1029 bytes --]
From 526d0b31e0d836e7a3c21d831849b8c50da2420e Mon Sep 17 00:00:00 2001
From: Matt Armstrong <matt@rfc20.org>
Date: Wed, 26 Oct 2022 09:46:37 -0700
Subject: [PATCH] Autoload the `calc-eval-error' variable
* lisp/calc/calc-aent.el: Autoload the `calc-eval-error' variable,
because it is documented as a lisp level option of the `calc-eval'
function, which is also autoloaded. Otherwise, even (require 'calc)
is not enough to get the variable defined; `calc-eval' must actually
be evaluated. This squashes byte compiler warnings in code using the
variable.
---
lisp/calc/calc-aent.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/calc/calc-aent.el b/lisp/calc/calc-aent.el
index ef3e0d4b67..59692beff7 100644
--- a/lisp/calc/calc-aent.el
+++ b/lisp/calc/calc-aent.el
@@ -252,6 +252,7 @@ calc-do-calc-eval
res (cdr res)))
buf)))))))))
+;;;###autoload
(defvar calc-eval-error nil
"Determines how calc handles errors.
If nil, return a list containing the character position of error.
--
2.35.1
next reply other threads:[~2022-10-26 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 17:02 Matt Armstrong [this message]
2022-11-11 13:16 ` bug#58801: [PATCH] Autoload the `calc-eval-error' variable Stefan Kangas
2022-11-15 18:24 ` Matt Armstrong
2022-11-15 18:42 ` Eli Zaretskii
2022-11-24 19:50 ` Stefan Kangas
2022-11-26 16:58 ` Matt Armstrong
2023-09-07 7:51 ` Stefan Kangas
2023-11-05 16:38 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsfaa56t.fsf@rfc20.org \
--to=matt@rfc20.org \
--cc=58801@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.