bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA

bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

X-Debbugs-CC: eric@ericabrahamsen.net

Hi all,

this is a tiny patch against vcard-parse.el in order to pacify the
warnings about

 ‘point-at-bol’ is an obsolete function ...
 ‘point-at-eol’ is an obsolete function ...

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-vcard-parse.el-vcard-parse-buffer-Pacify-the-compile.patch --]
[-- Type: text/x-patch, Size: 1098 bytes --]

From f0bf7e52772064d1ccfcfe84798a658220483ec6 Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Tue, 18 Jul 2023 22:31:50 +0200
Subject: [PATCH] ; * vcard-parse.el (vcard-parse-buffer): Pacify the compiler.

---
 vcard-parse.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/vcard-parse.el b/vcard-parse.el
index 571faa1c6e..e43ceed8be 100644
--- a/vcard-parse.el
+++ b/vcard-parse.el
@@ -1,6 +1,6 @@
 ;;; vcard-parse.el --- Library for parsing vCards      -*- lexical-binding: t; -*-
 
-;; Copyright (C) 2019-2022  Free Software Foundation, Inc.
+;; Copyright (C) 2019-2023  Free Software Foundation, Inc.
 
 ;; Author: Eric Abrahamsen <eric@ericabrahamsen.net>
 ;; Maintainer: Eric Abrahamsen <eric@ericabrahamsen.net>
@@ -221,8 +221,8 @@ Returns a list of contact objects."
 				   '(vcard) :error
 				   "Parsing failed with:\n %s"
 				   (buffer-substring-no-properties
-				    (point-at-bol)
-				    (point-at-eol))))))
+				    (line-beginning-position)
+				    (line-end-position))))))
 	(push card out)))
 
     (nreverse out)))
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 473 bytes --]

And while we're at: There are also

  In vcard-region-decode-base64:
  vcard.el:516:29: Warning: avoid ‘lsh’; use ‘ash’ instead
  vcard.el:518:27: Warning: avoid ‘lsh’; use ‘ash’ instead
  vcard.el:518:51: Warning: avoid ‘lsh’; use ‘ash’ instead
  vcard.el:530:32: Warning: avoid ‘lsh’; use ‘ash’ instead

Is `ash' a drop-in replacement?  Maybe these can be fixed as well.

This is with Emacs 30.0.50 (f624b283bf).

Best, Arash

bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA

[Eric Abrahamsen]

Arash Esbati <arash@gnu.org> writes:

> X-Debbugs-CC: eric@ericabrahamsen.net
>
> Hi all,
>
> this is a tiny patch against vcard-parse.el in order to pacify the
> warnings about
>
>  ‘point-at-bol’ is an obsolete function ...
>  ‘point-at-eol’ is an obsolete function ...
>
>
> And while we're at: There are also
>
>   In vcard-region-decode-base64:
>   vcard.el:516:29: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:518:27: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:518:51: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:530:32: Warning: avoid ‘lsh’; use ‘ash’ instead
>
> Is `ash' a drop-in replacement?  Maybe these can be fixed as well.

Thanks for this! I've applied your patch. This stuff with base64 looks
like it it's from the year 2000, and I should follow Stefan's comments
and update it to use `base64-decode-region' directly. This is one of the
many things I'm behind on, I will try to get to it this week. Let's
leave this bug open until then.

bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA

[Arash Esbati]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Thanks for this! I've applied your patch. This stuff with base64 looks
> like it it's from the year 2000, and I should follow Stefan's comments
> and update it to use `base64-decode-region' directly. This is one of the
> many things I'm behind on, I will try to get to it this week. Let's
> leave this bug open until then.

Thanks for installing that part.  Please feel free to close this report
whenever appropriate.

Best, Arash

bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA

[Stefan Kangas]

> Thanks for installing that part.  Please feel free to close this report
> whenever appropriate.

Closing this now.