From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#64717: [PATCH] Silence the compiler in vcard-parse.el from ELPA Date: Tue, 18 Jul 2023 14:59:18 -0700 Message-ID: <878rbc6fux.fsf@ericabrahamsen.net> References: <86a5vt6j5h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23715"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64717@debbugs.gnu.org To: Arash Esbati Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 19 00:00:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLskA-0005zJ-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jul 2023 00:00:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLsjs-0003Zm-Dq; Tue, 18 Jul 2023 18:00:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLsjk-0003ZR-Lu for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 18:00:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLsji-000428-HO for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 18:00:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLsji-0006lF-CM for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2023 18:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2023 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64717 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64717-submit@debbugs.gnu.org id=B64717.168971756825911 (code B ref 64717); Tue, 18 Jul 2023 22:00:02 +0000 Original-Received: (at 64717) by debbugs.gnu.org; 18 Jul 2023 21:59:28 +0000 Original-Received: from localhost ([127.0.0.1]:54498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLsjA-0006jq-GP for submit@debbugs.gnu.org; Tue, 18 Jul 2023 17:59:28 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:59306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLsj8-0006jd-KE for 64717@debbugs.gnu.org; Tue, 18 Jul 2023 17:59:27 -0400 Original-Received: from localhost (c-76-135-104-211.hsd1.wa.comcast.net [76.135.104.211]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id D7DADFA002; Tue, 18 Jul 2023 21:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1689717560; bh=btvC2krTiOFq4cdvZQx6AH+5HI4f++Df4pZEmR4rhSA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SRdLsZTFZ4p9mBb28eMXFaXlr99jDNvBg7RcRhuLT/il40YhM3c5oXlDVrc1KU5rs /MiRu1y+BpgF89X+i/TaIYIlLCxJPLlRMSMKEEC9DHwE3Mkw8HqwQcPEe7xCfKgnnp 5QPjQxcmCxxu3K6OI8wZGkv8zy0JhMecInesz+Gc= In-Reply-To: <86a5vt6j5h.fsf@gnu.org> (Arash Esbati's message of "Tue, 18 Jul 2023 22:48:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265500 Archived-At: Arash Esbati writes: > X-Debbugs-CC: eric@ericabrahamsen.net > > Hi all, > > this is a tiny patch against vcard-parse.el in order to pacify the > warnings about > > =E2=80=98point-at-bol=E2=80=99 is an obsolete function ... > =E2=80=98point-at-eol=E2=80=99 is an obsolete function ... > > > And while we're at: There are also > > In vcard-region-decode-base64: > vcard.el:516:29: Warning: avoid =E2=80=98lsh=E2=80=99; use =E2=80=98ash= =E2=80=99 instead > vcard.el:518:27: Warning: avoid =E2=80=98lsh=E2=80=99; use =E2=80=98ash= =E2=80=99 instead > vcard.el:518:51: Warning: avoid =E2=80=98lsh=E2=80=99; use =E2=80=98ash= =E2=80=99 instead > vcard.el:530:32: Warning: avoid =E2=80=98lsh=E2=80=99; use =E2=80=98ash= =E2=80=99 instead > > Is `ash' a drop-in replacement? Maybe these can be fixed as well. Thanks for this! I've applied your patch. This stuff with base64 looks like it it's from the year 2000, and I should follow Stefan's comments and update it to use `base64-decode-region' directly. This is one of the many things I'm behind on, I will try to get to it this week. Let's leave this bug open until then.