From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?6Lev5a6i?= Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes Date: Tue, 31 Jan 2023 00:53:17 +0800 Message-ID: References: <167500933323.27282.16366310039274039148@vcs2.savannah.gnu.org> <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000068890505f37e0fbf" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32329"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 30 17:55:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMXR0-00089x-EN for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Jan 2023 17:55:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMXQM-0008R5-CO; Mon, 30 Jan 2023 11:54:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMXQG-0008QA-Ua for emacs-devel@gnu.org; Mon, 30 Jan 2023 11:54:24 -0500 Original-Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMXPx-0007OV-EO for emacs-devel@gnu.org; Mon, 30 Jan 2023 11:54:24 -0500 Original-Received: by mail-oi1-x234.google.com with SMTP id dt8so7487617oib.0 for ; Mon, 30 Jan 2023 08:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ntO2lMlUdayTK+5P5QOfsG3KsjcOp0cQoesi5qDcifo=; b=OQE9M22RU8rx5bgpgHH0aCcxg9GVfawhZPrp4RRIrCu0oxMr89OKILhWiju/xgn2h+ X1D0kZI5b4PbzorTXP/7aex9w+NdqRLJk3SgiMuCsz7iKnpTcsppc/nStbEzJJpxCCMS gLcXHjW+l2905ixhafYymkoO11iyQBcMra7SC2OSCGuv4EjRdLR3az69sl1NFJXEXl+u /YIblA7BVBMFEP7lFi27T6TW7G+EDeEsk0EnpSTcAMEU+e2fHOO8jWfbl7+Pqw//xdKK 05LUkxVJ2QfTFIn6LIbUaxDzUUpH6DJoW2zD+5vZunikns/O3M9CT+6HoRSX5r112+Zb FZzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ntO2lMlUdayTK+5P5QOfsG3KsjcOp0cQoesi5qDcifo=; b=C3P5idWltL7T7aeKtKvFqDz5untei1umNi14a2ULJvx81MLEy3yefk0tRXfyRyDzGZ YSmDmSOzTmiGJ428rLqoSKHNXiUpfmOfuVtloR7j9g5S1DZ3rYBn0rbV1YI1Z1m5krHf zPmHFNCYVAQ8FFVDOHVdHJSHfAzX8Nlwsu5NfowX2Pc6Y1NK/PeKPGJYLC6hctc2yc9w NLCv0vifpT4SVDryXdQlcIG4nsvP78cfa7Mx3AfH8H8Yo/wZJvCMouPM04qXRfpw4c78 T9xnzjKW5hyhYB/4M6B60MjAGzLfuSDIFKrzNFbSLPuwLulaMBIu9ZqngXRJqSXNJpiL oxvA== X-Gm-Message-State: AO0yUKXHvTktNjZ0PxORfruMVZG8uu5sUkkCTcxvRlGnwV1yHs6tzLGp 2Fqax0NmprCYSUY57+55x3+yzeXZ6K8b2rPgzi9vb4bUX9k= X-Google-Smtp-Source: AK7set8cecibGIB6Zhy/5yhkmtDjKa5F8y/7Nl2iEsKYlj6yf9rtldP4XzDlbwjBUFOq3+7KUBjGnNBtOtiSvFttyBE= X-Received: by 2002:a05:6808:5c6:b0:375:41bc:b5ff with SMTP id d6-20020a05680805c600b0037541bcb5ffmr1040251oij.143.1675097633489; Mon, 30 Jan 2023 08:53:53 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=luke.yx.lee@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302796 Archived-At: --00000000000068890505f37e0fbf Content-Type: text/plain; charset="UTF-8" Thanks for spotting this. Yes you are right. My local branch was very different from the one on ELPA and it did not use nadvice package. Recently I merged ELPA version back and the code segment you highlighted was quite old and I don't even remember what it's for, probably a transition code during the period of transition from `xxx' to `cl-xxx' ... I've fixed it along with an issue found on the Windows version -- I just found that the Windows version is a convenient tool to help me test old Emacs versions like Emacs 24.2. Thanks. On Mon, 30 Jan 2023 at 11:01, Stefan Monnier wrote: > [ Resending with a better email address. ] > > > (eval-when-compile > > - (require 'cl-lib) > > + (if (version< emacs-version "27.0") > > + (progn > > + (require 'cl) ;; Package cl is deprecated for Emacs27+ > > + (require 'cl-macs)) > > + (require 'cl-lib)) > > This looks like a regression resulting from a misunderstanding. > What are you trying to do here? > > The rest of the code uses only `cl-lib` functionality, so (require 'cl) > will be useful only if it internally does (require 'cl-lib). > In Emacs<24.3, this will fail because (require 'cl) will not define the > macros that the rest of the code needs (e.g. `cl-eval-when`, `cl-loop`, > ...). > > > Stefan > > -- Best regards, Luke Lee --00000000000068890505f37e0fbf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for spotting this.=C2=A0 Yes you are right.=C2=A0 M= y local branch
was very different from the one on ELPA and it did not us= e
nadvice package.=C2=A0 Recently I merged ELPA version back and the
= code segment you highlighted was quite old and I don't even
remember= what it's for, probably a transition code during the
period of tran= sition from `xxx' to `cl-xxx' ...

I've fixed it along wi= th an issue found on the Windows version
-- I just found that the Window= s version is a convenient tool to
help me test old Emacs versions l= ike Emacs 24.2.=C2=A0
Thanks.


<= /div>


On Mon, 30 Jan 2023 at 11:01, Stefan Monnier <monnier@iro.umontreal.ca> wrot= e:
[ Resending w= ith a better email address.=C2=A0 ]

>=C2=A0 (eval-when-compile
> -=C2=A0 (require 'cl-lib)
> +=C2=A0 (if (version< emacs-version "27.0")
> +=C2=A0 =C2=A0 =C2=A0 (progn
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (require 'cl) ;; Package cl is deprec= ated for Emacs27+
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (require 'cl-macs))
> +=C2=A0 =C2=A0 (require 'cl-lib))

This looks like a regression resulting from a misunderstanding.
What are you trying to do here?

The rest of the code uses only `cl-lib` functionality, so (require 'cl)=
will be useful only if it internally does (require 'cl-lib).
In Emacs<24.3, this will fail because (require 'cl) will not define = the
macros that the rest of the code needs (e.g. `cl-eval-when`, `cl-loop`, ...= ).


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan



--
Best regards,
Luke Lee

--00000000000068890505f37e0fbf--