all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: "Alan Mackenzie" <acm@muc.de>,
	"Mattias Engdegård" <mattias.engdegard@gmail.com>,
	"Paul Eggert" <eggert@cs.ucla.edu>,
	64069@debbugs.gnu.org
Subject: bug#64069: 30.0.50; Mistyped shy group regexps
Date: Thu, 15 Jun 2023 08:39:40 +0100	[thread overview]
Message-ID: <87zg5141j7.fsf@epfl.ch> (raw)
In-Reply-To: <8d2a4d47-10d7-d16e-85d2-8009781a0dbc@gutov.dev> (Dmitry Gutov's message of "Thu, 15 Jun 2023 04:45:45 +0300")

Dmitry Gutov [2023-06-15 04:45 +0300] wrote:

> When you say "encode-time ... is passed ... +0100", what is your testing
> scenario?

Eyeballing the code and git-blame's output.

> IIUC, the change in commit 576fba5f58d removed the complex dates from the output
> (which we parse), replacing them with the simple yyyy-mm-dd format (that's what
> --date=short does). Seems like I tried (8 years ago) to retain the compatibility
> with the previous output in case we'll make the format configurable someday, but
> that still hasn't happened.

Is it not configurable via vc-git-annotate-switches?
When invoking git with multiple --date= options, the last one wins.

> So we could do away with the 'if' condition and simplify the regexp
> accordingly.

You mean ignoring anything other than the YYYY-MM-DD format?

No objections from me, but it's not that hard to fix&keep support for
the default --date=iso output from Git, if desired.

Thanks,

-- 
Basil





  reply	other threads:[~2023-06-15  7:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 16:43 bug#64069: 30.0.50; Mistyped shy group regexps Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-15  1:45 ` Dmitry Gutov
2023-06-15  7:39   ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-06-15 12:14     ` Dmitry Gutov
2023-06-15 20:58 ` Alan Mackenzie
2023-06-17 13:26   ` Alan Mackenzie
2023-06-17 15:39     ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg5141j7.fsf@epfl.ch \
    --to=bug-gnu-emacs@gnu.org \
    --cc=64069@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=contovob@tcd.ie \
    --cc=dmitry@gutov.dev \
    --cc=eggert@cs.ucla.edu \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.