all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Basil Contovounesios <contovob@tcd.ie>
Cc: "Dmitry Gutov" <dmitry@gutov.dev>,
	"Mattias Engdegård" <mattias.engdegard@gmail.com>,
	"Paul Eggert" <eggert@cs.ucla.edu>,
	64069@debbugs.gnu.org
Subject: bug#64069: 30.0.50; Mistyped shy group regexps
Date: Thu, 15 Jun 2023 20:58:38 +0000	[thread overview]
Message-ID: <ZIt7fvFFkVO5QFyO@ACM> (raw)
In-Reply-To: <87v8fq570k.fsf@epfl.ch>

Hello, Basil.

On Wed, Jun 14, 2023 at 17:43:39 +0100, Basil Contovounesios wrote:
> Severity: minor
> Tags: patch

> Further to https://bugs.gnu.org/64019#14, I attach a patch which tweaks
> four redundant or seemingly mistyped instances of \(:?...\), i.e. a
> numbered group starting with an optional colon in place of the likelier
> shy group.

> CCing:
> - Alan to review the change to c-or-c++-mode--regexp

Yes, that looks like a bug, just as you've surmised.

There are also three other occurrences of \(:? in CC Mode, namely in
cc-langs.el.

I will fix all of these in master.

[ .... ]

> diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el
> index 11a1d3fe6c2..5cf9b7e17f8 100644
> --- a/lisp/progmodes/cc-mode.el
> +++ b/lisp/progmodes/cc-mode.el
> @@ -2859,7 +2859,7 @@ c-or-c++-mode--regexp
>                                       "\\|" id "::"
>                                       "\\|" id ws-maybe "=\\)"
>                "\\|" "\\(?:inline" ws "\\)?namespace"
> -                    "\\(:?" ws "\\(?:" id "::\\)*" id "\\)?" ws-maybe "{"
> +                    "\\(?:" ws "\\(?:" id "::\\)*" id "\\)?" ws-maybe "{"
>                "\\|" "class"     ws id
>                      "\\(?:" ws "final" "\\)?" ws-maybe "[:{;\n]"
>                "\\|" "struct"     ws id "\\(?:" ws "final" ws-maybe "[:{\n]"

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).





  parent reply	other threads:[~2023-06-15 20:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 16:43 bug#64069: 30.0.50; Mistyped shy group regexps Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-15  1:45 ` Dmitry Gutov
2023-06-15  7:39   ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-15 12:14     ` Dmitry Gutov
2023-06-15 20:58 ` Alan Mackenzie [this message]
2023-06-17 13:26   ` Alan Mackenzie
2023-06-17 15:39     ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIt7fvFFkVO5QFyO@ACM \
    --to=acm@muc.de \
    --cc=64069@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=dmitry@gutov.dev \
    --cc=eggert@cs.ucla.edu \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.