From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64069: 30.0.50; Mistyped shy group regexps Date: Thu, 15 Jun 2023 08:39:40 +0100 Message-ID: <87zg5141j7.fsf@epfl.ch> References: <87v8fq570k.fsf@epfl.ch> <8d2a4d47-10d7-d16e-85d2-8009781a0dbc@gutov.dev> Reply-To: Basil Contovounesios Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37165"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Paul Eggert , 64069@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 09:40:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9hao-0009PX-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 09:40:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9haO-0007sr-Bb; Thu, 15 Jun 2023 03:40:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9haM-0007sR-AZ for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 03:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9haM-0004Zs-1k for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 03:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9haL-000174-TQ for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 03:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Basil Contovounesios Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2023 07:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64069 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64069-submit@debbugs.gnu.org id=B64069.16868147934253 (code B ref 64069); Thu, 15 Jun 2023 07:40:01 +0000 Original-Received: (at 64069) by debbugs.gnu.org; 15 Jun 2023 07:39:53 +0000 Original-Received: from localhost ([127.0.0.1]:46049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9haC-00016X-Kw for submit@debbugs.gnu.org; Thu, 15 Jun 2023 03:39:52 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:52492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9ha8-00015z-Gv for 64069@debbugs.gnu.org; Thu, 15 Jun 2023 03:39:51 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f8cec6641bso17064835e9.1 for <64069@debbugs.gnu.org>; Thu, 15 Jun 2023 00:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1686814782; x=1689406782; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=nb1itUscgVoxf6bMFuwHslvpui3EQLomzuSW7879cMM=; b=PBykAZud5/Mqs3vVn21jjb9i8rpFIKF/ll9x9bICeOyPltmq2Pz2fFeOyZ26Ub5AzH aCb/jGHPHeOqMLbhwyeEhDguqCLyiMgDJuyQSkhEP9COlZ6WwYGixQbaUhc7aFeY739D UKxzdOA+sfwvOeWzt6WwoegpRbiZlGzlYXTU25k23gKFiKUbn1xu2Sc/mp2MUgQYbTsE +uAilyhNsR+wvoarMMhblDugLkFgV++3oCylxd+pPH1KNcpo1BBWuxCPKgwQrd6R9HB1 q+r+etR0oW8HyWBp3VZy3T3vFOTvC05Bt81RXMhabjmfVkP7Ccf87U9xUZ8lAaBv8W1p vSCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686814782; x=1689406782; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nb1itUscgVoxf6bMFuwHslvpui3EQLomzuSW7879cMM=; b=EpzUI+ylNE/s98vVUzsa3HV/s+jgUmYF3I8metOGTFN0XJfnqrbQwetZu6JIj4b5fn 0oFddGKnbT4ZF9W2wF+IgpzJsmZS0xQVQIt0CSn4mIHrFb4DFuxKN2uQXZO64ZtiBlz2 vgJs0Hjzcv910EGmPWa+48l43dipYhg2xbIsvPQ8x7d031VxRD/Bv4mpqW+fEZf7cb0v mTYg8NJy0dDpZQuKt/m6MH6YuCbvBmfj1mi2sw5wHNx7tFyUObxps08qrafU4oiHpAvz GpzfxnaY5S1zLR7W72f0hbpqVOk2lo+pDQ2MqHBtH2+93EyENE8B6T2ESFwz1M7qtRTI Xrng== X-Gm-Message-State: AC+VfDzFSRhU/xcPQF72ZElaklqgcnK10sz/OPzG1EkVQQ9A1QcLVTvh DKCWr0NmVgpQS5aoMqYHlO7Dww== X-Google-Smtp-Source: ACHHUZ4z86b8roW+eW/RB9cGrBEXUFNuXMgs8+RIk+uXDtDk3vrZMYl8n2RbHHem/inpFycMtUvhdA== X-Received: by 2002:a7b:c3d5:0:b0:3f8:c5a6:4c11 with SMTP id t21-20020a7bc3d5000000b003f8c5a64c11mr6145448wmj.2.1686814782432; Thu, 15 Jun 2023 00:39:42 -0700 (PDT) Original-Received: from localhost ([109.78.21.96]) by smtp.gmail.com with ESMTPSA id a18-20020a056000101200b002c70ce264bfsm8683197wrx.76.2023.06.15.00.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 00:39:41 -0700 (PDT) In-Reply-To: <8d2a4d47-10d7-d16e-85d2-8009781a0dbc@gutov.dev> (Dmitry Gutov's message of "Thu, 15 Jun 2023 04:45:45 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263404 Archived-At: Dmitry Gutov [2023-06-15 04:45 +0300] wrote: > When you say "encode-time ... is passed ... +0100", what is your testing > scenario? Eyeballing the code and git-blame's output. > IIUC, the change in commit 576fba5f58d removed the complex dates from the output > (which we parse), replacing them with the simple yyyy-mm-dd format (that's what > --date=short does). Seems like I tried (8 years ago) to retain the compatibility > with the previous output in case we'll make the format configurable someday, but > that still hasn't happened. Is it not configurable via vc-git-annotate-switches? When invoking git with multiple --date= options, the last one wins. > So we could do away with the 'if' condition and simplify the regexp > accordingly. You mean ignoring anything other than the YYYY-MM-DD format? No objections from me, but it's not that hard to fix&keep support for the default --date=iso output from Git, if desired. Thanks, -- Basil