From: Philip Kaludercic <philipk@posteo.net>
To: Matt Armstrong <matt@rfc20.org>
Cc: 59728@debbugs.gnu.org, stefan monnier <monnier@iro.umontreal.ca>
Subject: bug#59728: 30.0.50; package-vc does not handle package-quickstart
Date: Wed, 30 Nov 2022 19:53:01 +0000 [thread overview]
Message-ID: <87y1rsw76q.fsf@posteo.net> (raw)
In-Reply-To: <87iliw8f55.fsf@rfc20.org> (Matt Armstrong's message of "Wed, 30 Nov 2022 10:35:02 -0800")
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
Matt Armstrong <matt@rfc20.org> writes:
> X-debbugs-cc: Philip Kaludercic <philipk@posteo.net>, Stefan Monnier <monnier@iro.umontreal.ca>
>
> package.el provides `package-quickstart':
>
> package-quickstart is a variable defined in ‘package.el’.
>
> Its value is t
> Original value was nil
>
> Precompute activation actions to speed up startup.
> This requires the use of ‘package-quickstart-refresh’ every time the
> activations need to be changed, such as when ‘package-load-list’ is modified.
>
> This places a package-quickstart.elc file in `user-emacs-directory' that
> is loaded at startup, instead of loading the individual
> `user-emacs-directory'/elpa/*-autoloads.el files.
>
> In practice package.el takes care of calling
> `package-quickstart-refresh' as needed. As a user making normal use of
> package.el I don't believe I have ever needed to call
> `package-quickstart-refresh' manually.
>
> I am playing with package-vc.el and immediately noticed that functions
> like `package-vc-install-from-checkout' and `package-vc-rebuild' do not
> call `package-quickstart-refresh'.
>
> The effect is that package-vc leaves a "stale" package-quickstart.elc in
> the `user-emacs-directory', and the user must run
> `package-quickstart-refresh' manually.
>
> Ideally the various `package-vc-*' functions take care of running the
> function when necessary.
The central function here is `package-vc--unpack-1' so the following
patch should take care of that:
[-- Attachment #2: Type: text/plain, Size: 579 bytes --]
diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index a4520ab800..5f7674190b 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -433,7 +433,8 @@ package-vc--unpack-1
(car load-path))))
(current-buffer))
(buffer-string))
- nil (expand-file-name auto-name pkg-dir))))
+ nil (expand-file-name auto-name pkg-dir)))
+ (package-quickstart-refresh))
;; Generate package file
(package-vc--generate-description-file pkg-desc pkg-file)
[-- Attachment #3: Type: text/plain, Size: 191 bytes --]
However I am uncertain if this is too aggressive? I don't have the time
to test it properly right now, but could try this (or some variation
thereof) and tell me if it addresses the issue?
next prev parent reply other threads:[~2022-11-30 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 18:35 bug#59728: 30.0.50; package-vc does not handle package-quickstart Matt Armstrong
2022-11-30 19:53 ` Philip Kaludercic [this message]
2022-12-01 0:14 ` Matt Armstrong
2022-12-10 9:01 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1rsw76q.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=59728@debbugs.gnu.org \
--cc=matt@rfc20.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.