From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#59728: 30.0.50; package-vc does not handle package-quickstart Date: Wed, 30 Nov 2022 19:53:01 +0000 Message-ID: <87y1rsw76q.fsf@posteo.net> References: <87iliw8f55.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12965"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59728@debbugs.gnu.org, stefan monnier To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 30 20:54:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0T9t-00037a-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Nov 2022 20:54:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0T9i-0002X8-TQ; Wed, 30 Nov 2022 14:54:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0T9g-0002Wv-5w for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 14:54:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0T9e-0003aa-Bl for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 14:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0T9e-0004yO-80 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 14:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2022 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59728 X-GNU-PR-Package: emacs Original-Received: via spool by 59728-submit@debbugs.gnu.org id=B59728.166983799319092 (code B ref 59728); Wed, 30 Nov 2022 19:54:02 +0000 Original-Received: (at 59728) by debbugs.gnu.org; 30 Nov 2022 19:53:13 +0000 Original-Received: from localhost ([127.0.0.1]:34752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0T8q-0004xs-Cl for submit@debbugs.gnu.org; Wed, 30 Nov 2022 14:53:13 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:38729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0T8l-0004xY-SP for 59728@debbugs.gnu.org; Wed, 30 Nov 2022 14:53:11 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 80CDD240103 for <59728@debbugs.gnu.org>; Wed, 30 Nov 2022 20:53:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669837981; bh=XJS+woZMEr6vvJLpIn5CzgAG5lIQFeZT/pTs7cU+7Q4=; h=From:To:Cc:Subject:Date:From; b=ZUFJjyJacTjAqvxs9QUKxJBYCCGcCTkRvmtXJkbgiRTExtTXB3FlntY5bHLbi3CgK 9FhI8UbcSziRVoqLiWu0i/jDKEH/xw0s56WVHb16LztzOuZ8XASyYQnU82hz/somKD eaxsKCruWR6BsyFy4f6zHl6/TLjjgw9JbScmIJdmDicuoUShQ/bJDcpjbHNefTx/yS Z8Ic6i4NC4yAajdxRA60YXjnRb4D4d34MwcWCEc5pY8KcXrs/IBWKzPExUA6paOlSf dGmIJUCXSDadJvmV2WMk1hJpUs7WKAv62OfSMR4Qk6vKQ9WIufa8Wau5wtngPREkuh USk4+wNS3vyXA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NMqcp6MhLz6tpD; Wed, 30 Nov 2022 20:52:58 +0100 (CET) In-Reply-To: <87iliw8f55.fsf@rfc20.org> (Matt Armstrong's message of "Wed, 30 Nov 2022 10:35:02 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249563 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Matt Armstrong writes: > X-debbugs-cc: Philip Kaludercic , Stefan Monnier > > package.el provides `package-quickstart': > > package-quickstart is a variable defined in =E2=80=98package.el=E2=80= =99. > > Its value is t > Original value was nil > > Precompute activation actions to speed up startup. > This requires the use of =E2=80=98package-quickstart-refresh=E2=80=99= every time the > activations need to be changed, such as when =E2=80=98package-load-li= st=E2=80=99 is modified. > > This places a package-quickstart.elc file in `user-emacs-directory' that > is loaded at startup, instead of loading the individual > `user-emacs-directory'/elpa/*-autoloads.el files. > > In practice package.el takes care of calling > `package-quickstart-refresh' as needed. As a user making normal use of > package.el I don't believe I have ever needed to call > `package-quickstart-refresh' manually. > > I am playing with package-vc.el and immediately noticed that functions > like `package-vc-install-from-checkout' and `package-vc-rebuild' do not > call `package-quickstart-refresh'. > > The effect is that package-vc leaves a "stale" package-quickstart.elc in > the `user-emacs-directory', and the user must run > `package-quickstart-refresh' manually. > > Ideally the various `package-vc-*' functions take care of running the > function when necessary. The central function here is `package-vc--unpack-1' so the following patch should take care of that: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index a4520ab800..5f7674190b 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -433,7 +433,8 @@ package-vc--unpack-1 (car load-path)))) (current-buffer)) (buffer-string)) - nil (expand-file-name auto-name pkg-dir)))) + nil (expand-file-name auto-name pkg-dir))) + (package-quickstart-refresh)) ;; Generate package file (package-vc--generate-description-file pkg-desc pkg-file) --=-=-= Content-Type: text/plain However I am uncertain if this is too aggressive? I don't have the time to test it properly right now, but could try this (or some variation thereof) and tell me if it addresses the issue? --=-=-=--