From: "J.P." <jp@neverwas.me>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-erc@gnu.org, Amin Bandali <bandali@gnu.org>, 68660@debbugs.gnu.org
Subject: bug#68660: 29.2; ELPA: Wrong type argument w. multiple maintainers in package-menu-mode
Date: Wed, 24 Jan 2024 06:31:39 -0800 [thread overview]
Message-ID: <87y1ceby5w.fsf__13940.6461430312$1706106821$gmane$org@neverwas.me> (raw)
In-Reply-To: <87ede7frtz.fsf@neverwas.me> (J. P.'s message of "Tue, 23 Jan 2024 17:22:32 -0800")
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
"J.P." <jp@neverwas.me> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>>> Its installable via `package-install`, but not from the
>>>> `package-menu-describe-package` because of this bug in that command.
>>>
>>> This indeed works interactively on Emacs 29. Thanks.
>>>
>>> However, ERC also supports versions 27 and 28. What's the recommended
>>> way for folks to upgrade on those Emacsen? The least gruesome thing I
>>> could conjure up is
>>>
>>> (package-install (car (alist-get 'erc package-archive-contents)))
>>
>> Do you mean that `package-install` won't work because the package is
>> already installed? Hmm... yeah, that'd be a problem.
>>
>> I can see several ways to "fix" this, but I think the simplest would be
Would one of those several ways possibly include overriding the
`package-desc-extras' :maintainer item scraped by `lm-maintainers' with
a spec item from an elpa-packages entry? I see that support for a
`:maintainer' keyword was recently added, but it appears to serve some
other purpose. Anyway, I've attached a sketch of what I'm trying to
describe, but I'm rather unfamiliar with this program.
Thanks.
>> to change
>>
>> ;; Maintainer: Amin Bandali <bandali@gnu.org>, F. Jason Park <jp@neverwas.me>
>>
>> into
>>
>> ;; Maintainer: emacs-erc@gnu.org
>>
>> Would that be a problem?
>
> I'll learn to live with it if Amin (Cc'd) can.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-POC-Allow-overriding-extras-maintainer-with-maint-co.patch --]
[-- Type: text/x-patch, Size: 1949 bytes --]
From 698918eb1b1f25a4b97bf951e69344ea441a8074 Mon Sep 17 00:00:00 2001
From: "F. Jason Park" <jp@neverwas.me>
Date: Tue, 23 Jan 2024 12:56:38 -0800
Subject: [PATCH] [POC] Allow overriding extras maintainer with :maint-compat
* elpa-admin.el (elpaa--supported-keywords): Add `:maint-compat'
to spec.
(elpaa--metadata): Allow overriding `package-desc-extras'
`:maintainer' entry with new `pkg-spec' item `:maint-compat'.
(Bug#68660)
---
elpa-admin.el | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/elpa-admin.el b/elpa-admin.el
index 9cbc805ba4..07db682085 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1011,7 +1011,7 @@ SPECS is the list of package specifications."
'(:url :core :auto-sync :ignored-files :release-branch :release
:readme :news :doc :renames :version-map :make :shell-command
:branch :lisp-dir :main-file :merge :excludes :rolling-release
- :maintainer :manual-sync)
+ :maint-compat :maintainer :manual-sync)
"List of keywords that can appear in a spec.")
(defun elpaa--publish-package-spec (spec)
@@ -1377,7 +1377,12 @@ PKG is the name of the package and DIR is the directory where it is."
(advice-add 'lm-header :around lmheader-advice))
(package-buffer-info))
(advice-remove 'lm-header lmheader-advice)))
- (extras (package-desc-extras pkg-desc))
+ (extras (let ((m-new (plist-get (cdr pkg-spec) :maint-compat)))
+ (when m-new
+ (setf (alist-get :maintainer
+ (package-desc-extras pkg-desc))
+ m-new))
+ (package-desc-extras pkg-desc)))
(version (package-desc-version pkg-desc))
(keywords (lm-keywords-list))
;; (_ (elpaa--version-to-list version)) ; Sanity check!
--
2.42.0
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0001-POC-elpa-packages-erc-Add-maint-compat-item.patch --]
[-- Type: text/x-patch, Size: 842 bytes --]
From f206ac628a43bfacc47e70933a383eda3ae08bdb Mon Sep 17 00:00:00 2001
From: "F. Jason Park" <jp@neverwas.me>
Date: Tue, 23 Jan 2024 13:02:17 -0800
Subject: [PATCH] [POC] * elpa-packages (erc): Add :maint-compat item.
---
elpa-packages | 2 ++
1 file changed, 2 insertions(+)
diff --git a/elpa-packages b/elpa-packages
index c73e8a066b..ae22abc02c 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -292,6 +292,8 @@
"etc/ERC-NEWS"
"COPYING")
:excludes ("lisp/erc/erc-loaddefs.el" "lisp/erc/ChangeLog.*")
+ :maint-compat ("Amin Bandali <bandali@gnu.org>, F. Jason Park <jp@neverwas.me>"
+ . "emacs-erc@gnu.org")
:shell-command "(echo '@set ERCDIST from GNU ELPA'; echo '@set EMACSVER') >emacsver.texi"
:doc "erc.texi"
:news "ERC-NEWS")
--
2.42.0
next prev parent reply other threads:[~2024-01-24 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 14:56 bug#68660: 29.2; ELPA: Wrong type argument w. multiple maintainers in package-menu-mode J.P.
2024-01-22 15:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <jwvjzo11jh2.fsf-monnier+emacs@gnu.org>
2024-01-23 14:57 ` J.P.
[not found] ` <87o7dcm718.fsf@neverwas.me>
2024-01-23 19:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <jwvplxrx2be.fsf-monnier+emacs@gnu.org>
2024-01-23 22:34 ` J.P.
[not found] ` <87le8fisqg.fsf@neverwas.me>
2024-01-24 0:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <jwvv87jsgfz.fsf-monnier+emacs@gnu.org>
2024-01-24 1:22 ` J.P.
[not found] ` <87ede7frtz.fsf@neverwas.me>
2024-01-24 14:31 ` J.P. [this message]
[not found] ` <87y1ceby5w.fsf@neverwas.me>
2024-01-24 15:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <jwv5xziyc60.fsf-monnier+emacs@gnu.org>
2024-01-24 17:57 ` J.P.
[not found] ` <877cjyaa31.fsf@neverwas.me>
2024-01-27 20:30 ` Amin Bandali
2024-01-31 19:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <jwvr0hxtinl.fsf-monnier+emacs@gnu.org>
2024-02-01 2:52 ` J.P.
[not found] ` <87ttmssxok.fsf@neverwas.me>
2024-02-14 1:58 ` J.P.
[not found] ` <87eddfg61t.fsf@neverwas.me>
2024-02-14 16:59 ` Philip Kaludercic
[not found] ` <87a5o3gexk.fsf@posteo.net>
2024-02-14 19:15 ` J.P.
[not found] ` <877cj6eu2t.fsf@neverwas.me>
2024-02-14 20:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <jwvmss2lsgn.fsf-monnier+emacs@gnu.org>
2024-02-14 20:54 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87y1ceby5w.fsf__13940.6461430312$1706106821$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=68660@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=emacs-erc@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.