From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#68660: 29.2; ELPA: Wrong type argument w. multiple maintainers in package-menu-mode Date: Wed, 24 Jan 2024 06:31:39 -0800 Message-ID: <87y1ceby5w.fsf__13940.6461430312$1706106821$gmane$org@neverwas.me> References: <877ck14dt4.fsf@neverwas.me> <87o7dcm718.fsf@neverwas.me> <87le8fisqg.fsf@neverwas.me> <87ede7frtz.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1630"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org, Amin Bandali , 68660@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 24 15:33:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSeJp-0000A3-JL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jan 2024 15:33:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSeJP-0001tA-2G; Wed, 24 Jan 2024 09:33:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSeJF-0001rP-Oi for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 09:32:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSeJF-0004TB-Gf for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 09:32:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSeJK-00013m-Nd for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 09:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68660 X-GNU-PR-Package: emacs Original-Received: via spool by 68660-submit@debbugs.gnu.org id=B68660.17061067313997 (code B ref 68660); Wed, 24 Jan 2024 14:33:02 +0000 Original-Received: (at 68660) by debbugs.gnu.org; 24 Jan 2024 14:32:11 +0000 Original-Received: from localhost ([127.0.0.1]:44833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSeIU-00012P-Dt for submit@debbugs.gnu.org; Wed, 24 Jan 2024 09:32:11 -0500 Original-Received: from mail-108-mta58.mxroute.com ([136.175.108.58]:46287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSeIK-00011f-Uh for 68660@debbugs.gnu.org; Wed, 24 Jan 2024 09:32:02 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta58.mxroute.com (ZoneMTA) with ESMTPSA id 18d3be2735f0003727.001 for <68660@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 24 Jan 2024 14:31:52 +0000 X-Zone-Loop: e7addb4a9d5819a0c0b79956c526462e392ca04d8bc0 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ckd5JzCy6Q64oMfXwAtceb2M5P9AXb1FtLxzqLYEIr4=; b=h+DF5wthjP8vu2wCn5PAQZOgin JZMky+MFVZv/ub2SCmPEf82mC0bue52KtMyWk1Cep7ixmjeSvM/M+42ipuyWbljEgMTX9Egl7dbyj xR4l29tWmkkv+fF3xb6paEbVzvopfNWiEliHha7c0God34JcCK27Pa/yFBtqks+wFjgO1m1uH+zfM +LIpa5FDu/bsiMSfXEwjMODdB+9oqQGFUJTR25i0cUMchm0jWVocOwYQAnvH6A8ZLCL8Sl7p0RBnd cAOuZqumrtMFPhewYSbRcnqUUzvilgBd16RkkudBcZ4BRvIrg9PHS3ADVKRLfp0vzcqwwmYGJO1hW TzI0X4zA==; In-Reply-To: <87ede7frtz.fsf@neverwas.me> (J. P.'s message of "Tue, 23 Jan 2024 17:22:32 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278786 Archived-At: --=-=-= Content-Type: text/plain "J.P." writes: > Stefan Monnier writes: > >>>> Its installable via `package-install`, but not from the >>>> `package-menu-describe-package` because of this bug in that command. >>> >>> This indeed works interactively on Emacs 29. Thanks. >>> >>> However, ERC also supports versions 27 and 28. What's the recommended >>> way for folks to upgrade on those Emacsen? The least gruesome thing I >>> could conjure up is >>> >>> (package-install (car (alist-get 'erc package-archive-contents))) >> >> Do you mean that `package-install` won't work because the package is >> already installed? Hmm... yeah, that'd be a problem. >> >> I can see several ways to "fix" this, but I think the simplest would be Would one of those several ways possibly include overriding the `package-desc-extras' :maintainer item scraped by `lm-maintainers' with a spec item from an elpa-packages entry? I see that support for a `:maintainer' keyword was recently added, but it appears to serve some other purpose. Anyway, I've attached a sketch of what I'm trying to describe, but I'm rather unfamiliar with this program. Thanks. >> to change >> >> ;; Maintainer: Amin Bandali , F. Jason Park >> >> into >> >> ;; Maintainer: emacs-erc@gnu.org >> >> Would that be a problem? > > I'll learn to live with it if Amin (Cc'd) can. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-POC-Allow-overriding-extras-maintainer-with-maint-co.patch >From 698918eb1b1f25a4b97bf951e69344ea441a8074 Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Tue, 23 Jan 2024 12:56:38 -0800 Subject: [PATCH] [POC] Allow overriding extras maintainer with :maint-compat * elpa-admin.el (elpaa--supported-keywords): Add `:maint-compat' to spec. (elpaa--metadata): Allow overriding `package-desc-extras' `:maintainer' entry with new `pkg-spec' item `:maint-compat'. (Bug#68660) --- elpa-admin.el | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/elpa-admin.el b/elpa-admin.el index 9cbc805ba4..07db682085 100644 --- a/elpa-admin.el +++ b/elpa-admin.el @@ -1011,7 +1011,7 @@ SPECS is the list of package specifications." '(:url :core :auto-sync :ignored-files :release-branch :release :readme :news :doc :renames :version-map :make :shell-command :branch :lisp-dir :main-file :merge :excludes :rolling-release - :maintainer :manual-sync) + :maint-compat :maintainer :manual-sync) "List of keywords that can appear in a spec.") (defun elpaa--publish-package-spec (spec) @@ -1377,7 +1377,12 @@ PKG is the name of the package and DIR is the directory where it is." (advice-add 'lm-header :around lmheader-advice)) (package-buffer-info)) (advice-remove 'lm-header lmheader-advice))) - (extras (package-desc-extras pkg-desc)) + (extras (let ((m-new (plist-get (cdr pkg-spec) :maint-compat))) + (when m-new + (setf (alist-get :maintainer + (package-desc-extras pkg-desc)) + m-new)) + (package-desc-extras pkg-desc))) (version (package-desc-version pkg-desc)) (keywords (lm-keywords-list)) ;; (_ (elpaa--version-to-list version)) ; Sanity check! -- 2.42.0 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-POC-elpa-packages-erc-Add-maint-compat-item.patch >From f206ac628a43bfacc47e70933a383eda3ae08bdb Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Tue, 23 Jan 2024 13:02:17 -0800 Subject: [PATCH] [POC] * elpa-packages (erc): Add :maint-compat item. --- elpa-packages | 2 ++ 1 file changed, 2 insertions(+) diff --git a/elpa-packages b/elpa-packages index c73e8a066b..ae22abc02c 100644 --- a/elpa-packages +++ b/elpa-packages @@ -292,6 +292,8 @@ "etc/ERC-NEWS" "COPYING") :excludes ("lisp/erc/erc-loaddefs.el" "lisp/erc/ChangeLog.*") + :maint-compat ("Amin Bandali , F. Jason Park " + . "emacs-erc@gnu.org") :shell-command "(echo '@set ERCDIST from GNU ELPA'; echo '@set EMACSVER') >emacsver.texi" :doc "erc.texi" :news "ERC-NEWS") -- 2.42.0 --=-=-=--