From: Philip Kaludercic <philipk@posteo.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: 62417@debbugs.gnu.org
Subject: bug#62417: 30.0.50; Regression: 59ecf25fc860 is the first bad commit
Date: Fri, 24 Mar 2023 16:05:42 +0000 [thread overview]
Message-ID: <87wn365e3t.fsf@posteo.net> (raw)
In-Reply-To: <87o7oicgy4.fsf@gmail.com> ("João Távora"'s message of "Fri, 24 Mar 2023 15:22:27 +0000")
João Távora <joaotavora@gmail.com> writes:
> tag 62417 patch
>
> João Távora <joaotavora@gmail.com> writes:
>
>> I haven't yet investigated the reason. There are other use cases inside
>> SLY that are also failing with similar errors, but they are not as easy
>> to trigger.
>
> The simples way to fix this is to make display-buffer-assq-regexp keep
> the old protocol before trying `buffer-match-p'.
>
> diff --git a/lisp/window.el b/lisp/window.el
> index 2da2f8bb2c8..0932a05aabf 100644
> --- a/lisp/window.el
> +++ b/lisp/window.el
> @@ -7502,8 +7502,13 @@ display-buffer-assq-regexp
> the form of the action argument passed to `display-buffer'."
> (catch 'match
> (dolist (entry alist)
> - (when (buffer-match-p (car entry) buffer-name action)
> - (throw 'match (cdr entry))))))
> + (let ((key (car entry)))
> + (when (or (and (stringp key)
> + (string-match-p key buffer-name))
> + (and (functionp key)
> + (funcall key buffer-name action))
> + (buffer-match-p (car entry) buffer-name action))
> + (throw 'match (cdr entry)))))))
>
> (defvar display-buffer--same-window-action
> '(display-buffer-same-window
>
> Another way would be to fix this in buffer-match-p.
I cannot make out what is broken in `buffer-match-p'? The patch would
appear to me to be redundant, because both strings and functions are
handled the same way in that function. If you could explain the
background, I think it would be better to fix `buffer-match-p',
considering that this should be how it behaves.
> João
--
Philip Kaludercic
next prev parent reply other threads:[~2023-03-24 16:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:16 bug#62417: 30.0.50; Regression: 59ecf25fc860 is the first bad commit João Távora
2023-03-24 15:22 ` João Távora
2023-03-24 16:05 ` Philip Kaludercic [this message]
2023-03-24 16:07 ` João Távora
2023-03-24 19:48 ` bug#62417: ; " João Távora
2023-03-25 12:55 ` Eli Zaretskii
2023-03-25 13:04 ` João Távora
2023-03-25 13:20 ` Eli Zaretskii
2023-03-25 13:56 ` João Távora
2023-03-25 14:13 ` Eli Zaretskii
2023-03-25 14:15 ` João Távora
2023-03-26 20:22 ` João Távora
2023-03-26 21:23 ` Philip Kaludercic
2023-03-27 2:24 ` Eli Zaretskii
2023-03-27 12:06 ` João Távora
2023-03-27 13:49 ` Eli Zaretskii
2023-03-27 14:08 ` João Távora
2023-03-27 15:20 ` Eli Zaretskii
2023-03-27 16:33 ` Eli Zaretskii
2023-03-27 16:42 ` João Távora
2023-03-27 17:09 ` Eli Zaretskii
2023-03-27 19:26 ` Philip Kaludercic
2023-03-28 11:11 ` Eli Zaretskii
2023-03-27 16:38 ` João Távora
2023-03-25 13:17 ` Philip Kaludercic
2023-03-25 13:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn365e3t.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=62417@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.