From: Eli Zaretskii <eliz@gnu.org>
To: joaotavora@gmail.com
Cc: philipk@posteo.net, 62417@debbugs.gnu.org
Subject: bug#62417: ; Regression: 59ecf25fc860 is the first bad commit
Date: Mon, 27 Mar 2023 19:33:53 +0300 [thread overview]
Message-ID: <83v8im887i.fsf@gnu.org> (raw)
In-Reply-To: <83zg7y8blb.fsf@gnu.org> (message from Eli Zaretskii on Mon, 27 Mar 2023 18:20:48 +0300)
> Cc: philipk@posteo.net, 62417@debbugs.gnu.org
> Date: Mon, 27 Mar 2023 18:20:48 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: João Távora <joaotavora@gmail.com>
> > Date: Mon, 27 Mar 2023 14:08:17 +0000
> > Cc: philipk@posteo.net, 62417@debbugs.gnu.org
> >
> > > since buffer-match-p accepts
> > > both buffers and their names. Please explain.
> >
> > In the patch I showed, which you and Philip approved, the docstring of
> > the variable display-buffer-alist was clarified to state that it is a buffer
> > name string, and _not_ a buffer object, that is passed to buffer-match-p.
> > This is absolutely necessary, and we've already been through this.
>
> I don't understand why this is necessary, and I didn't intend to limit
> buffer-match-p to accepting only buffer names. Please explain why is
> it necessary.
>
> What I did say was that _if_ buffer-match-p will be able to accept
> _both_ buffer names and objects _and_ will pass to the function
> exactly the argument it was passed, i.e. either a buffer object or a
> name of a buffer, _then_ the backward-incompatibility will be solved.
>
> The responsibility of making sure buffer-match-p accepts a name when
> the function expects only names is _on_the_caller_. And the caller is
> NOT display-buffer, it's the Lisp code which calls display-buffer or
> which prepares the alist that will be passed to display-buffer.
To make a long story short: here's how the call to
display-buffer-assq-regexp looked like in Emacs 28:
(let* ((user-action
(display-buffer-assq-regexp
(buffer-name buffer) display-buffer-alist action))
And here's how it looks like in Emacs 29:
(let* ((user-action
(display-buffer-assq-regexp
buffer display-buffer-alist action))
Your change modified display-buffer-assq-regexp to pass to
buffer-match-p the name of the buffer if display-buffer-assq-regexp
was called with a buffer object. This is not TRT, since, among other
issues, it changes the API of display-buffer-assq-regexp, which is a
public function. Instead, we should do the following:
. restore the calling convention of display-buffer-assq-regexp as it
was in Emacs 28, where it accepted only buffer names, and fix its
doc string accordingly
. remove from display-buffer-assq-regexp the code which ensures
buffer-match-p is called with the name of the buffer
. make sure display-buffer call display-buffer-assq-regexp with a
buffer's name, as it did in Emacs 28
OK?
(I can do this myself if you agree, and there are no other
objections.)
next prev parent reply other threads:[~2023-03-27 16:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:16 bug#62417: 30.0.50; Regression: 59ecf25fc860 is the first bad commit João Távora
2023-03-24 15:22 ` João Távora
2023-03-24 16:05 ` Philip Kaludercic
2023-03-24 16:07 ` João Távora
2023-03-24 19:48 ` bug#62417: ; " João Távora
2023-03-25 12:55 ` Eli Zaretskii
2023-03-25 13:04 ` João Távora
2023-03-25 13:20 ` Eli Zaretskii
2023-03-25 13:56 ` João Távora
2023-03-25 14:13 ` Eli Zaretskii
2023-03-25 14:15 ` João Távora
2023-03-26 20:22 ` João Távora
2023-03-26 21:23 ` Philip Kaludercic
2023-03-27 2:24 ` Eli Zaretskii
2023-03-27 12:06 ` João Távora
2023-03-27 13:49 ` Eli Zaretskii
2023-03-27 14:08 ` João Távora
2023-03-27 15:20 ` Eli Zaretskii
2023-03-27 16:33 ` Eli Zaretskii [this message]
2023-03-27 16:42 ` João Távora
2023-03-27 17:09 ` Eli Zaretskii
2023-03-27 19:26 ` Philip Kaludercic
2023-03-28 11:11 ` Eli Zaretskii
2023-03-27 16:38 ` João Távora
2023-03-25 13:17 ` Philip Kaludercic
2023-03-25 13:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8im887i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62417@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.