From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62417: 30.0.50; Regression: 59ecf25fc860 is the first bad commit Date: Fri, 24 Mar 2023 16:05:42 +0000 Message-ID: <87wn365e3t.fsf@posteo.net> References: <87sfducmrc.fsf@gmail.com> <87o7oicgy4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34237"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62417@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 24 23:05:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfpX4-0008c1-Hj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Mar 2023 23:05:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfpTk-0004Xp-NN; Fri, 24 Mar 2023 18:01:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfpTK-0004Az-3s for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 18:01:22 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfpTJ-0000eY-Qu for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 18:01:17 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfjvW-0005vL-S8 for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 12:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2023 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167967395222733 (code B ref 62417); Fri, 24 Mar 2023 16:06:02 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 24 Mar 2023 16:05:52 +0000 Original-Received: from localhost ([127.0.0.1]:41209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfjvM-0005ub-6o for submit@debbugs.gnu.org; Fri, 24 Mar 2023 12:05:52 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:48281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfjvK-0005uN-0b for 62417@debbugs.gnu.org; Fri, 24 Mar 2023 12:05:50 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3932A240309 for <62417@debbugs.gnu.org>; Fri, 24 Mar 2023 17:05:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679673944; bh=M8OuyGbbfaWEGQKQbvfXBLZDpCU6y2/IE6RKJ2byTsw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=YlRp310cnDq2OWwYTZZOYPbfqGwZ54jaALFwWnc8IcSZakLpe5xpZ+PZuI1xkSxw3 sMnlUgnlp0aA7XmbNPugSyPklk9EYtCIj1DFOkG54QRZx1jg/zsMf63jUqeYDRuz9d ZBxHCTOoZTn2Yf8a0J24TkW0psiYEOm9AottC9JogF4ZjtcTs0VHTfzn3neJbhVVg/ 0qINinvq4O7CfIWT1qfICe+++F4okodfcAFa8wqkOXzjL4GtZ8H8J5oSITCyPdjyyz 85154sCWi1K5NQQ1nZ7mxqR01f8KHPYDQEVrAWdJ27ks6IOxrWAO7R9dM1AVd89co0 YkfwWsQ+waYWQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pjn9z4Xf2z9rxD; Fri, 24 Mar 2023 17:05:42 +0100 (CET) In-Reply-To: <87o7oicgy4.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 24 Mar 2023 15:22:27 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258527 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > tag 62417 patch > > Jo=C3=A3o T=C3=A1vora writes: > >> I haven't yet investigated the reason. There are other use cases inside >> SLY that are also failing with similar errors, but they are not as easy >> to trigger. > > The simples way to fix this is to make display-buffer-assq-regexp keep > the old protocol before trying `buffer-match-p'. > > diff --git a/lisp/window.el b/lisp/window.el > index 2da2f8bb2c8..0932a05aabf 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -7502,8 +7502,13 @@ display-buffer-assq-regexp > the form of the action argument passed to `display-buffer'." > (catch 'match > (dolist (entry alist) > - (when (buffer-match-p (car entry) buffer-name action) > - (throw 'match (cdr entry)))))) > + (let ((key (car entry))) > + (when (or (and (stringp key) > + (string-match-p key buffer-name)) > + (and (functionp key) > + (funcall key buffer-name action)) > + (buffer-match-p (car entry) buffer-name action)) > + (throw 'match (cdr entry))))))) >=20=20 > (defvar display-buffer--same-window-action > '(display-buffer-same-window > > Another way would be to fix this in buffer-match-p. I cannot make out what is broken in `buffer-match-p'? The patch would appear to me to be redundant, because both strings and functions are handled the same way in that function. If you could explain the background, I think it would be better to fix `buffer-match-p', considering that this should be how it behaves. > Jo=C3=A3o --=20 Philip Kaludercic