From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Wed, 15 Mar 2023 20:24:41 +0000 Message-ID: <87v8j14vau.fsf@gmail.com> References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34885"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62194@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 15 21:23:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcXed-0008ry-Ot for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Mar 2023 21:23:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcXeK-0003TQ-8w; Wed, 15 Mar 2023 16:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcXeJ-0003S6-7v for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 16:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcXeI-0004UZ-Vx for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 16:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcXeI-0000jk-Iz for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2023 16:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Mar 2023 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.16789117692800 (code B ref 62194); Wed, 15 Mar 2023 20:23:02 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 15 Mar 2023 20:22:49 +0000 Original-Received: from localhost ([127.0.0.1]:40609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcXe5-0000j6-D8 for submit@debbugs.gnu.org; Wed, 15 Mar 2023 16:22:49 -0400 Original-Received: from mail-wm1-f41.google.com ([209.85.128.41]:53107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcXe3-0000is-HY for 62194@debbugs.gnu.org; Wed, 15 Mar 2023 16:22:47 -0400 Original-Received: by mail-wm1-f41.google.com with SMTP id bi20so3462417wmb.2 for <62194@debbugs.gnu.org>; Wed, 15 Mar 2023 13:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678911761; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z/oWlq8gSPjJXm5NPtjwwpsZmp60nFVHVv/7ylkA6T4=; b=ECgbpSxL1+M9I9Jup4WasCXZiVpa89oZAJNHq3dYEMJJm401btvvu8ALpHC1t6BL+U P1r444ZsAnbR3umOriagukNjjdjTamETT0KO1Lq3vYnrUUEOUV6ygBeU36i24mD9RU9H Ln+OpJNNyuliG+ZcaSX/t5JQN1lctLk84s5cphGXJ/RVXEn/sITllcRU7/8XunL3APCZ VsLcdw8QQZBzI73ocYSPcq/rlC6TBCWgHSopIHyrPcIVcSZiVlU1MwXQXHbLBmGKWExo XEuh9XaSK3fSpdhpc8m9aM/+6DevQUXxFKE6vc9Z3UjFeaB6qbi8lBD3TYl/m+8SDnWb Tt3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678911761; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z/oWlq8gSPjJXm5NPtjwwpsZmp60nFVHVv/7ylkA6T4=; b=spampemxgcUADG+xbRzITFWRh83Pid9ve92Nl9Ml4BTQvbvmDjOzvqGeZFhWVCU/ox PhsrBLi9Mgi8ihypPw2HLDY9Jhsp+atcoDWXMcCF2DljJroGi04aWwtUG3mS/emIJuqo CGyS1JfIHnnxbCktSSAnnrTgrGZb2bp51oCdHaa/oamPj45zJiXf5FAn8WECCZ7wS5MS wnr85bguEl5Z+OWZpuZ990Qwpnh7TLr0/ZdIY3R60tNfDGXyxk602GTDnD+V9HaNpoS7 7YuG+YvlaDtcSgwj//O68i/Pnd4faylt5cxhBq8VfzOPHkZyfFmMLRzPWyci8HpjSaD8 BwjA== X-Gm-Message-State: AO0yUKVmKjpNywiIcFGIQK5w4sZ5J/bcSQYRhUJOWCa59/tweuAiQ8B2 8rFix5ivB2itRcvU52ydu2g5ESg/RCo= X-Google-Smtp-Source: AK7set9aXGqVrn5sMvxUrQINsRq0hMiWhxQSrjP5OrE6B4jB/ntOqv5Z1RV8aoAB58uCFYRPip0pQQ== X-Received: by 2002:a05:600c:3b9d:b0:3ed:29db:cb80 with SMTP id n29-20020a05600c3b9d00b003ed29dbcb80mr9337939wms.18.1678911761309; Wed, 15 Mar 2023 13:22:41 -0700 (PDT) Original-Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id p11-20020a05600c1d8b00b003daffc2ecdesm2883810wms.13.2023.03.15.13.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 13:22:40 -0700 (PDT) In-Reply-To: <874jqmjl0s.fsf@gmx.de> (Michael Albinus's message of "Wed, 15 Mar 2023 12:45:23 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257984 Archived-At: merge 62194 61350 thanks Michael Albinus writes: > So I reommend the following: > > - At least in 'eglot--call-with-tramp-test', better in your Eglot > package, suppress vc related checks, by binding > > (let ((vc-ignore-dir-regexp > (format "\\(%s\\)\\|\\(%s\\)" > vc-ignore-dir-regexp > tramp-file-name-regexp))) > ...) > > - If this works sufficiently, this bug shall be either closed, or merged > with bug#60534, which tracks this error. I don't think I should be doing something this in eglot-tests.el, because the tests pass on emacs-29 and this failure was introduced very recently. I've just confirmed inequivocally that these failures are direct fallout from the fix to bug#61350, so I'm merging the two bugs: 62194 and 61350. As I wrote in bug#61350, if I revert that commit and apply the simpler patch that we discussed, everything's good, and I can remove the ControlMaster supression workaround in Eglot, too. Jo=C3=A3o diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el index 47173b95bea..885b29f9471 100644 --- a/lisp/net/tramp.el +++ b/lisp/net/tramp.el @@ -5800,6 +5800,11 @@ tramp-accept-process-output This is needed in order to hide `last-coding-system-used', which is set for process communication also. If the user quits via `C-g', it is propagated up to `tramp-file-name-handl= er'." + (when-let (((process-get proc 'shared-socket)) + (v (process-get proc 'vector))) + (dolist (p (delq proc (process-list))) + (when (tramp-file-name-equal-p v (process-get p 'vector)) + (while (accept-process-output p 0 nil t))))) (with-current-buffer (process-buffer proc) (let ((inhibit-read-only t) last-coding-system-used