From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Chong Yidong <cyd@stupidchicken.com>, emacs-devel@gnu.org
Subject: Re: bug in copy-directory
Date: Tue, 08 Feb 2011 11:58:16 +0100 [thread overview]
Message-ID: <87sjvysshj.fsf@gmail.com> (raw)
In-Reply-To: <87pqr2c2a7.fsf@gmx.de> (Michael Albinus's message of "Tue, 08 Feb 2011 10:18:40 +0100")
Michael Albinus <michael.albinus@gmx.de> writes:
> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>
>> Michael, could you apply the patch i sent here to Stefan and do:
>>
>> M-: (copy-directory "/tmp/test" "~/") RET
>>
>> You will see it works fine.
>
> Yes.
>
>> M-x copy-directory works fine too
>>
>> and copying from dired works fine also.
>
> Yes.
>
> However, when copying in dired "/tmp/test" to "~/", the second attempt
> results in a wrong directory structure.
Can't reproduce that here, all work fine from dired in emacs -Q
You can use also the unit-test i sent you, it exit with no failures.
(modify it a bit as code have changed now)
> For file name handlers your approach is a little bit, hmm, surprising.
> You call the handler for `copy-directory' inside of `copy-directory1'.
> This could work, or course, but it isn't a clean approach, and it will
> add a maintenance burden when all of us have forgotten what we are doing
> here.
Yes but copy-directory call copy-directory-1, so what's the problem?
file name handlers have to be in copy-directory-1 because dired MUST use
copy-directory-1 and not copy-directory.
> At least *I* am pretty good in forgetting (my wife says :-)
So nothing to remember, just use copy-directory as before. ;-)
--
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2011-02-08 10:58 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 15:18 bug in copy-directory Thierry Volpiatto
2011-01-28 1:13 ` Chong Yidong
2011-01-28 9:05 ` Thierry Volpiatto
2011-01-28 15:02 ` Stefan Monnier
2011-01-28 16:30 ` Chong Yidong
2011-01-28 16:51 ` Lennart Borgman
2011-01-28 17:05 ` Andreas Schwab
2011-01-28 17:08 ` Lennart Borgman
2011-01-28 17:18 ` Andreas Schwab
2011-01-28 17:13 ` Thierry Volpiatto
2011-01-28 17:17 ` Lennart Borgman
2011-01-28 18:11 ` Thierry Volpiatto
2011-01-28 18:28 ` Lennart Borgman
2011-01-28 20:12 ` Jan Djärv
2011-01-28 20:48 ` Lennart Borgman
2011-01-28 22:44 ` Jan Djärv
2011-01-28 22:55 ` Lennart Borgman
2011-01-28 18:31 ` Eli Zaretskii
2011-01-28 18:33 ` Thierry Volpiatto
2011-01-28 18:35 ` Stefan Monnier
2011-01-29 22:12 ` Chong Yidong
2011-01-29 22:51 ` Thierry Volpiatto
2011-01-30 10:51 ` Michael Albinus
2011-01-30 13:54 ` Thierry Volpiatto
2011-01-30 14:05 ` Michael Albinus
2011-01-30 10:46 ` Michael Albinus
2011-01-30 13:51 ` Thierry Volpiatto
2011-01-30 14:12 ` Michael Albinus
2011-01-30 14:36 ` Thierry Volpiatto
2011-01-30 15:21 ` Thierry Volpiatto
2011-01-30 16:00 ` Thierry Volpiatto
2011-01-30 17:43 ` Michael Albinus
2011-01-30 18:07 ` Thierry Volpiatto
2011-01-30 18:32 ` Thierry Volpiatto
2011-01-30 18:36 ` Michael Albinus
2011-01-30 19:07 ` Thierry Volpiatto
2011-01-30 21:18 ` Thierry Volpiatto
2011-01-31 17:06 ` Chong Yidong
2011-02-01 9:44 ` Michael Albinus
2011-02-01 11:57 ` Thierry Volpiatto
2011-02-02 8:19 ` Thierry Volpiatto
2011-02-02 9:24 ` Thierry Volpiatto
2011-02-02 9:47 ` Michael Albinus
2011-02-02 20:48 ` Thierry Volpiatto
2011-02-04 8:40 ` Thierry Volpiatto
2011-02-04 10:17 ` Michael Albinus
2011-02-04 17:28 ` Thierry Volpiatto
2011-02-04 19:20 ` Michael Albinus
2011-02-04 20:00 ` Thierry Volpiatto
2011-02-06 5:01 ` Chong Yidong
2011-02-06 6:23 ` Thierry Volpiatto
2011-02-06 12:03 ` Michael Albinus
2011-02-06 13:33 ` Chong Yidong
2011-02-07 16:43 ` Michael Albinus
2011-02-07 17:32 ` Thierry Volpiatto
2011-02-08 9:18 ` Michael Albinus
2011-02-08 10:58 ` Thierry Volpiatto [this message]
2011-02-08 11:29 ` Michael Albinus
2011-02-08 15:06 ` Thierry Volpiatto
2011-02-08 15:22 ` Michael Albinus
2011-02-08 16:39 ` Michael Albinus
2011-02-09 0:46 ` Chong Yidong
2011-02-09 7:13 ` Thierry Volpiatto
2011-02-09 8:32 ` Michael Albinus
2011-02-09 15:37 ` Chong Yidong
2011-02-09 16:07 ` Michael Albinus
2011-02-09 16:11 ` Thierry Volpiatto
2011-02-09 16:50 ` Chong Yidong
2011-02-09 17:37 ` Thierry Volpiatto
2011-02-06 17:22 ` Thierry Volpiatto
2011-02-06 17:46 ` Thierry Volpiatto
2011-02-07 15:22 ` Stefan Monnier
2011-02-07 16:02 ` Thierry Volpiatto
2011-02-07 18:55 ` Stefan Monnier
2011-02-07 20:00 ` Thierry Volpiatto
2011-02-08 3:32 ` Stefan Monnier
2011-02-09 16:02 ` Chong Yidong
2011-02-09 21:42 ` Stefan Monnier
2011-02-11 8:12 ` Thierry Volpiatto
2011-02-11 8:32 ` Michael Albinus
2011-02-11 9:48 ` Thierry Volpiatto
2011-02-11 10:36 ` Michael Albinus
2011-02-11 23:58 ` Chong Yidong
2011-02-12 7:06 ` Thierry Volpiatto
2011-02-12 9:01 ` Michael Albinus
2011-02-12 18:42 ` Chong Yidong
2011-02-12 19:41 ` Chong Yidong
2011-02-12 21:55 ` Thierry Volpiatto
2011-02-12 22:46 ` Chong Yidong
2011-02-14 11:40 ` Thierry Volpiatto
2011-02-12 7:26 ` Thierry Volpiatto
2011-02-06 17:47 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjvysshj.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.