From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Tue, 08 Feb 2011 11:58:16 +0100 Message-ID: <87sjvysshj.fsf@gmail.com> References: <87ipxaidea.fsf@gmail.com> <878vy59ejz.fsf@stupidchicken.com> <87lj23ickn.fsf@stupidchicken.com> <87sjway8i3.fsf@gmx.de> <87wrll2ebe.fsf@stupidchicken.com> <87hbcot7gq.fsf@gmx.de> <87ei7qrdp0.fsf@gmail.com> <87ipx2dayh.fsf@gmx.de> <87y65yyxfu.fsf@gmail.com> <87d3n8xkeq.fsf@gmail.com> <878vxw6r4m.fsf@gmx.de> <87pqr790b0.fsf@gmail.com> <87oc6r7gjc.fsf@gmx.de> <87ipwz8t92.fsf@gmail.com> <878vxt69k7.fsf@stupidchicken.com> <874o8hbc9q.fsf@gmx.de> <87tygh8ez6.fsf@stupidchicken.com> <87zkq7okvk.fsf@gmx.de> <87vd0vwy0k.fsf@gmail.com> <87pqr2c2a7.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297162722 6122 80.91.229.12 (8 Feb 2011 10:58:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 8 Feb 2011 10:58:42 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 08 11:58:37 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PmlHH-0000Hl-Ru for ged-emacs-devel@m.gmane.org; Tue, 08 Feb 2011 11:58:36 +0100 Original-Received: from localhost ([127.0.0.1]:60321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmlHC-0001UM-68 for ged-emacs-devel@m.gmane.org; Tue, 08 Feb 2011 05:58:30 -0500 Original-Received: from [140.186.70.92] (port=32925 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PmlH4-0001So-8F for emacs-devel@gnu.org; Tue, 08 Feb 2011 05:58:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PmlH3-0003KF-2b for emacs-devel@gnu.org; Tue, 08 Feb 2011 05:58:22 -0500 Original-Received: from mail-wy0-f169.google.com ([74.125.82.169]:62587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PmlH2-0003K0-Tq for emacs-devel@gnu.org; Tue, 08 Feb 2011 05:58:21 -0500 Original-Received: by wyj26 with SMTP id 26so5921193wyj.0 for ; Tue, 08 Feb 2011 02:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=5Wp3t2FbZ2u9Iwrgqy4Z5bpe86PR9K3jgEN5F4y1NPA=; b=dcxqhVlbjioQLguWrjRbbJx7WNe8p824rKbiMufE4BFI1dli8P0BgRPiJ7KC5gXyq6 OOWJnGcPELJKjzlkX290l/ogVw1YkhILU70JsvbEEcStuaDFRam3GsmkIsAqHGh6+ocN P+Y0zoAyQw+EUb6FGyDs7gkqxctBSgTdJooTo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=pIE2YrOH0wL6Z0WCIzJOMjfR8eJHP1iL1Mn/hTCEqDQsVGGoz1MZClK1JfJVM5lFHj Z1GYznxRWs/aW8W+stu7gOLf6Z+K3NSh7sZJKkDyZyTiuEzFkunp6h10kU3zh1l1lxXH 7+HI9VoaDS/N/vlTr59gMSQPUIlU/U4HIXn4I= Original-Received: by 10.216.188.67 with SMTP id z45mr15560350wem.7.1297162698780; Tue, 08 Feb 2011 02:58:18 -0800 (PST) Original-Received: from thierry-MM061 (98.78.88-79.rev.gaoland.net [79.88.78.98]) by mx.google.com with ESMTPS id r38sm2751369weq.47.2011.02.08.02.58.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 08 Feb 2011 02:58:18 -0800 (PST) In-Reply-To: <87pqr2c2a7.fsf@gmx.de> (Michael Albinus's message of "Tue, 08 Feb 2011 10:18:40 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2.93 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135739 Archived-At: Michael Albinus writes: > Thierry Volpiatto writes: > >> Michael, could you apply the patch i sent here to Stefan and do: >> >> M-: (copy-directory "/tmp/test" "~/") RET >> >> You will see it works fine. > > Yes. > >> M-x copy-directory works fine too >> >> and copying from dired works fine also. > > Yes. > > However, when copying in dired "/tmp/test" to "~/", the second attempt > results in a wrong directory structure. Can't reproduce that here, all work fine from dired in emacs -Q You can use also the unit-test i sent you, it exit with no failures. (modify it a bit as code have changed now) > For file name handlers your approach is a little bit, hmm, surprising. > You call the handler for `copy-directory' inside of `copy-directory1'. > This could work, or course, but it isn't a clean approach, and it will > add a maintenance burden when all of us have forgotten what we are doing > here. Yes but copy-directory call copy-directory-1, so what's the problem? file name handlers have to be in copy-directory-1 because dired MUST use copy-directory-1 and not copy-directory. > At least *I* am pretty good in forgetting (my wife says :-) So nothing to remember, just use copy-directory as before. ;-) -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997