Re: bug in copy-directory

[Thierry Volpiatto <thierry.volpiatto@gmail.com>]

Chong Yidong <cyd@stupidchicken.com> writes:

> Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
>
>>> Go ahead and send the patch anytime it's ready.
>>
>> Find it attached.
>
> Thanks, I've applied it to the trunk.  A few comments:
>
> 1. I didn't apply the change to dired-aux.el.  It doesn't seem to do the
> right thing.  With that change patch, if I try to use the `C' command in
> Dired, I get an error.
>
>    mkdir ~/a
>    emacs ~/
>    [move point to a]
>    C
>    ~/b RET  => error.
To be sure:
b is a non--existing directory, right?

> Could you check this part again?  What's its purpose?


> 2. You have non-standard indentation settings which make your patches
> bigger than they should be, harder to read, and requires re-editing of
> the results before they can be committed.  Stuff like this should not be
I use cl indent, just apply patch and reindent.

> 3. Don't include frivolous whitespace changes in patches, they are
> irrelevant and make it harder to follow.

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997