bug#58709: 29.0.50; [PATCH] Fallout 307ad21

[Philip Kaludercic <philipk@posteo.net>]

Juri Linkov <juri@linkov.net> writes:

>> Hadn't known vc-refresh-state gets into my find-file-hook
>> irregardless.  This won't work with git branches in a detached
>> HEAD state.
>>...
>>  (defun vc-git-working-revision (_file)
>>    "Git-specific version of `vc-working-revision'."
>>    (let* ((process-file-side-effects nil)
>> -         (commit (vc-git--rev-parse "HEAD" t)))
>> -    (or (vc-git-symbolic-commit commit) commit)))
>
> Maybe Philip could comment on this (Cc:ed).
>
> Regarding the commit 307ad21, what I noticed is that after this commit,
> typing 'C-c C-w' (log-edit-generate-changelog-from-diff) in log-edit mode,
> creates temporary buffers with names that contain symbolic revision names
> in their buffer names instead of hash numbers, that looks very strange.

If that is the case, the change should be reverted, and ideally some
other way could be found to request that vc-working-revision generates a
symbolic reference.  Perhaps using a dynamic variable?