From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#58709: 29.0.50; [PATCH] Fallout 307ad21 Date: Wed, 26 Oct 2022 07:16:26 +0000 Message-ID: <87pmefqcl1.fsf@posteo.net> References: <87czal12oi.fsf@dick> <86tu3t6m59.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26680"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58709@debbugs.gnu.org, dick To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 26 09:18:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onag5-0006hz-5W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Oct 2022 09:18:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onaex-0006Tz-9c; Wed, 26 Oct 2022 03:17:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onaeu-0006Sv-TJ for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 03:17:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onaes-0000dl-Fc for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 03:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1onaes-0003Ub-A2 for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 03:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Oct 2022 07:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58709-submit@debbugs.gnu.org id=B58709.166676859913391 (code B ref 58709); Wed, 26 Oct 2022 07:17:02 +0000 Original-Received: (at 58709) by debbugs.gnu.org; 26 Oct 2022 07:16:39 +0000 Original-Received: from localhost ([127.0.0.1]:53132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onaeV-0003Tv-7T for submit@debbugs.gnu.org; Wed, 26 Oct 2022 03:16:39 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:32801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onaeT-0003Ti-AU for 58709@debbugs.gnu.org; Wed, 26 Oct 2022 03:16:37 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 251D5240101 for <58709@debbugs.gnu.org>; Wed, 26 Oct 2022 09:16:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666768591; bh=//sU/TWe8mWHe53s7Z2rCxgH//VCnOHVwSadVeD46Uw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=cK6X7xaPfhAOvuqhvMETdaeu5osHzgzZ1toJi01LYjRrMY6jnQ1Ie8p31vibDHABx MNU0QKPdBvc5eFm6ja15rBbSlZ18n9osvurOL5b7LmdOkw5bB69mE2Du78Qh9+r9OU 0yD6//1950h/W5QDZlfzmnLWRPKQBpim7djZ2EHlUe1aWNwLgFKfUc1TpFyl1el9yc CMPstgVkJJGaZfL1imTQQo+9KKxgczJNhzAR0zGJX4b0WelRAu5/g4vN7/aiyxp2UB EK0r8C7cXPeJFT8lhu2axFR+SzNoIgsdhtmBIVVzOMZqcL8VDuTdBg8f+NqctJtiQu 1ttBF5oaVnk2g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4My0V36nY3z9rxH; Wed, 26 Oct 2022 09:16:26 +0200 (CEST) In-Reply-To: <86tu3t6m59.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 24 Oct 2022 22:39:38 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246200 Archived-At: Juri Linkov writes: >> Hadn't known vc-refresh-state gets into my find-file-hook >> irregardless. This won't work with git branches in a detached >> HEAD state. >>... >> (defun vc-git-working-revision (_file) >> "Git-specific version of `vc-working-revision'." >> (let* ((process-file-side-effects nil) >> - (commit (vc-git--rev-parse "HEAD" t))) >> - (or (vc-git-symbolic-commit commit) commit))) > > Maybe Philip could comment on this (Cc:ed). > > Regarding the commit 307ad21, what I noticed is that after this commit, > typing 'C-c C-w' (log-edit-generate-changelog-from-diff) in log-edit mode, > creates temporary buffers with names that contain symbolic revision names > in their buffer names instead of hash numbers, that looks very strange. If that is the case, the change should be reverted, and ideally some other way could be found to request that vc-working-revision generates a symbolic reference. Perhaps using a dynamic variable?