all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: dick <dick.r.chiang@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>, 58709@debbugs.gnu.org
Subject: bug#58709: 29.0.50; [PATCH] Fallout 307ad21
Date: Mon, 24 Oct 2022 22:39:38 +0300	[thread overview]
Message-ID: <86tu3t6m59.fsf@mail.linkov.net> (raw)
In-Reply-To: <87czal12oi.fsf@dick> (dick's message of "Fri, 21 Oct 2022 13:55:57 -0400")

> Hadn't known vc-refresh-state gets into my find-file-hook
> irregardless.  This won't work with git branches in a detached
> HEAD state.
>...
>  (defun vc-git-working-revision (_file)
>    "Git-specific version of `vc-working-revision'."
>    (let* ((process-file-side-effects nil)
> -         (commit (vc-git--rev-parse "HEAD" t)))
> -    (or (vc-git-symbolic-commit commit) commit)))

Maybe Philip could comment on this (Cc:ed).

Regarding the commit 307ad21, what I noticed is that after this commit,
typing 'C-c C-w' (log-edit-generate-changelog-from-diff) in log-edit mode,
creates temporary buffers with names that contain symbolic revision names
in their buffer names instead of hash numbers, that looks very strange.





  parent reply	other threads:[~2022-10-24 19:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 17:55 bug#58709: 29.0.50; [PATCH] Fallout 307ad21 dick
2022-10-22 12:35 ` dick
2022-10-24 19:39 ` Juri Linkov [this message]
2022-10-26  7:16   ` Philip Kaludercic
2022-11-07 17:39     ` Matt Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tu3t6m59.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=58709@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.