From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 58820@debbugs.gnu.org, "Łukasz Stelmach" <stlman@poczta.fm>
Subject: bug#58820: [PATCH] Calculate age cutoff at n-th midnight instead of n*24h mark
Date: Sat, 23 Sep 2023 16:36:11 -0700 [thread overview]
Message-ID: <87il80laxg.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <CADwFkmnqAG+dDDTiC0UUURME9v5YEfPH1+a4hvcn9UWV_y63gQ@mail.gmail.com> (Stefan Kangas's message of "Thu, 7 Sep 2023 13:29:05 -0700")
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
Stefan Kangas <stefankangas@gmail.com> writes:
> Łukasz Stelmach <stlman@poczta.fm> writes:
>
>> * lisp/gnus/gnus-sum.el (gnus-summary-limit-to-age): Calculate cutoff to
>> point to n-th past midnight (1st is 00:00 today). This way messages sent
>> between n*24h mark and the next midnight will be excluded (or included
>> if limitting to younger messages), which seems more intuitive when users
>> are asked to enter age in days.
>
> Eric, do you have any comments on this patch? Thanks in advance.
Hi!
I do think this a reasonable change, thanks to Łukasz for the report.
I'd like to apply the attached, which is mostly Łukasz's code with the
addition of a simplification of the argument reading.
I've also changed the docstring a bit, as I found the original change a
little hard to understand. However, this might not be any better!
WDYT?
Eric
[-- Attachment #2: 0001-Have-gnus-summary-limit-to-age-operate-on-calendar-d.patch --]
[-- Type: text/x-patch, Size: 3098 bytes --]
From 5b050f666dce02636921f4d1f7529efae6aec856 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Sat, 23 Sep 2023 16:31:10 -0700
Subject: [PATCH] Have gnus-summary-limit-to-age operate on calendar days
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Reported and patched by Łukasz Stelmach <stlman@poczta.fm>.
* lisp/gnus/gnus-sum.el (gnus-summary-limit-to-age): Rather than
24-hour blocks. Also use `read-number', and drop the confusing option
to reverse younger/older both with the prefix argument and with a
negative number.
---
lisp/gnus/gnus-sum.el | 40 +++++++++++++++-------------------------
1 file changed, 15 insertions(+), 25 deletions(-)
diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index a3be5577f7a..f576d4e6147 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -8331,39 +8331,29 @@ gnus-summary-limit-to-predicate
(defun gnus-summary-limit-to-age (age &optional younger-p)
"Limit the summary buffer to articles that are older than (or equal) AGE days.
-If YOUNGER-P (the prefix) is non-nil, limit the summary buffer to
-articles that are younger than AGE days."
+Days are counted from midnight to midnight, and now to the
+previous midnight counts as day one. If YOUNGER-P (the prefix)
+is non-nil, limit the summary buffer to articles that are younger
+than AGE days."
(interactive
- (let ((younger current-prefix-arg)
- (days-got nil)
- days)
- (while (not days-got)
- (setq days (if younger
- (read-string "Limit to articles younger than (in days, older when negative): ")
- (read-string
- "Limit to articles older than (in days, younger when negative): ")))
- (when (> (length days) 0)
- (setq days (read days)))
- (if (numberp days)
- (progn
- (setq days-got t)
- (when (< days 0)
- (setq younger (not younger))
- (setq days (* days -1))))
- (message "Please enter a number.")
- (sleep-for 1)))
+ (let* ((younger current-prefix-arg)
+ (days (read-number
+ (if younger "Limit to articles younger than days: "
+ "Limit to articles older than days: "))))
(list days younger))
gnus-summary-mode)
(prog1
- (let ((data gnus-newsgroup-data)
- (cutoff (days-to-time age))
- articles d date is-younger)
+ (let* ((data gnus-newsgroup-data)
+ (now (append '(0 0 0) (cdddr (decode-time))))
+ (delta (make-decoded-time :day (* -1 (- age 1))))
+ (cutoff (encode-time (decoded-time-add now delta)))
+ articles d date is-younger)
(while (setq d (pop data))
(when (and (mail-header-p (gnus-data-header d))
(setq date (mail-header-date (gnus-data-header d))))
(setq is-younger (time-less-p
- (time-since (gnus-date-get-time date))
- cutoff))
+ cutoff
+ (gnus-date-get-time date)))
(when (if younger-p
is-younger
(not is-younger))
--
2.42.0
next prev parent reply other threads:[~2023-09-23 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 18:50 bug#58820: [PATCH] Calculate age cutoff at n-th midnight instead of n*24h mark Łukasz Stelmach
2023-09-07 20:29 ` Stefan Kangas
2023-09-23 23:36 ` Eric Abrahamsen [this message]
2023-10-11 14:57 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il80laxg.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=58820@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
--cc=stlman@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.