From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 58820@debbugs.gnu.org, "Łukasz Stelmach" <stlman@poczta.fm>
Subject: bug#58820: [PATCH] Calculate age cutoff at n-th midnight instead of n*24h mark
Date: Wed, 11 Oct 2023 07:57:24 -0700 [thread overview]
Message-ID: <87il7durzf.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87il80laxg.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 23 Sep 2023 16:36:11 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Łukasz Stelmach <stlman@poczta.fm> writes:
>>
>>> * lisp/gnus/gnus-sum.el (gnus-summary-limit-to-age): Calculate cutoff to
>>> point to n-th past midnight (1st is 00:00 today). This way messages sent
>>> between n*24h mark and the next midnight will be excluded (or included
>>> if limitting to younger messages), which seems more intuitive when users
>>> are asked to enter age in days.
>>
>> Eric, do you have any comments on this patch? Thanks in advance.
>
> Hi!
>
> I do think this a reasonable change, thanks to Łukasz for the report.
> I'd like to apply the attached, which is mostly Łukasz's code with the
> addition of a simplification of the argument reading.
>
> I've also changed the docstring a bit, as I found the original change a
> little hard to understand. However, this might not be any better!
>
> WDYT?
I feel fairly okay about this patch, so will apply tomorrow unless
anyone complains.
Thanks,
Eric
prev parent reply other threads:[~2023-10-11 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 18:50 bug#58820: [PATCH] Calculate age cutoff at n-th midnight instead of n*24h mark Łukasz Stelmach
2023-09-07 20:29 ` Stefan Kangas
2023-09-23 23:36 ` Eric Abrahamsen
2023-10-11 14:57 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il7durzf.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=58820@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
--cc=stlman@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.