From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#58820: [PATCH] Calculate age cutoff at n-th midnight instead of n*24h mark Date: Wed, 11 Oct 2023 07:57:24 -0700 Message-ID: <87il7durzf.fsf@ericabrahamsen.net> References: <20221027185006.1033130-1-stlman@poczta.fm> <87il80laxg.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31525"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58820@debbugs.gnu.org, =?UTF-8?Q?=C5=81ukasz?= Stelmach To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 11 16:58:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqaew-0007wD-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Oct 2023 16:58:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqaec-0006zO-QI; Wed, 11 Oct 2023 10:57:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqaea-0006uM-Mt for bug-gnu-emacs@gnu.org; Wed, 11 Oct 2023 10:57:40 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqaea-0001jg-Ee for bug-gnu-emacs@gnu.org; Wed, 11 Oct 2023 10:57:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqaew-0001Iw-84 for bug-gnu-emacs@gnu.org; Wed, 11 Oct 2023 10:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Oct 2023 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58820 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58820-submit@debbugs.gnu.org id=B58820.16970362795006 (code B ref 58820); Wed, 11 Oct 2023 14:58:02 +0000 Original-Received: (at 58820) by debbugs.gnu.org; 11 Oct 2023 14:57:59 +0000 Original-Received: from localhost ([127.0.0.1]:39845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqaet-0001Ic-5t for submit@debbugs.gnu.org; Wed, 11 Oct 2023 10:57:59 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:52974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqaeo-0001IH-SP for 58820@debbugs.gnu.org; Wed, 11 Oct 2023 10:57:58 -0400 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CB810FAB23; Wed, 11 Oct 2023 14:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1697036246; bh=WBUKF02+KuCN8X0IPpWDf3+chSsaW6MDR8ZCWaAPqFw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ys4s/tu4u81LIH7VmNusqQCqic0CGu0YmLLzJkSnQ1+VfXwbtSSUJd03BItFNlCl/ hWYRqKeHirYFk7jhLYmk5nHgAJ+F9SPrHLjg76xaROhGfVkJjFxS/E/aLH8FsTk+QP OIKcDm7o1926INC35JHKApA/YhbRqWQ4V+sgbM/Y= In-Reply-To: <87il80laxg.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 23 Sep 2023 16:36:11 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272256 Archived-At: Eric Abrahamsen writes: > Stefan Kangas writes: > >> =C5=81ukasz Stelmach writes: >> >>> * lisp/gnus/gnus-sum.el (gnus-summary-limit-to-age): Calculate cutoff to >>> point to n-th past midnight (1st is 00:00 today). This way messages se= nt >>> between n*24h mark and the next midnight will be excluded (or included >>> if limitting to younger messages), which seems more intuitive when users >>> are asked to enter age in days. >> >> Eric, do you have any comments on this patch? Thanks in advance. > > Hi! > > I do think this a reasonable change, thanks to =C5=81ukasz for the report. > I'd like to apply the attached, which is mostly =C5=81ukasz's code with t= he > addition of a simplification of the argument reading. > > I've also changed the docstring a bit, as I found the original change a > little hard to understand. However, this might not be any better! > > WDYT? I feel fairly okay about this patch, so will apply tomorrow unless anyone complains. Thanks, Eric