bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt

["J.P." <jp@neverwas.me>]

Emanuel Berg <incal@dataswamp.org> writes:

> J.P. wrote:
>
>> The attached patch is a unit test for all four commands.
>> It doesn't bother asserting M-x behavior (because see
>> above). Please try to make it pass without changing the test
>> itself (unless there's a bug).
>>
>>   $ git am /tmp/0002-5.x-Add...etc.patch
>>
>>   $ make -C test lisp/erc/erc-scenarios-misc-commands.log \
>>     SELECTOR=erc-scenarios-misc-commands--AMSG-GMSG-AME-GME
>
> The test failed
>
>   (error "Failed awaiting: string: <alice> bob: Our queen and all")
>
> Here is the entire erc-scenarios-misc-commands.log
>
> Source file `/home/incal/src/emacs/lisp/emacs-lisp/bytecomp.el' newer than byte-compiled file; using older file

                                                                  ^~~~~~ hint

  $ ./src/emacs -Q -batch -l erc -eval "(print (list :minep? (fboundp 'erc-cmd-GMSG)))"

> Source file `/home/incal/src/emacs/lisp/erc/erc.el' newer than byte-compiled file; using older file
> Source file `/home/incal/src/emacs/lisp/erc/erc-common.el' newer than byte-compiled file; using older file
> Source file `/home/incal/src/emacs/lisp/auth-source.el' newer than byte-compiled file; using older file
> Running 1 tests (2024-01-23 14:35:36+0100, selector `erc-scenarios-misc-commands--AMSG-GMSG-AME-GME')
> Source file `/home/incal/src/emacs/lisp/erc/erc-button.el' newer than byte-compiled file; using older file
> Source file `/home/incal/src/emacs/lisp/erc/erc-track.el' newer than byte-compiled file; using older file
> Error running timer `erc-d--on-request': (error "Match failed: \"PRIVMSG #bar :1 foonet only\" (:exes (\"\\\\`PRIVMSG #bar :2 barnet only\") :dialog amsg-barnet)")
> Test erc-scenarios-misc-commands--AMSG-GMSG-AME-GME backtrace:
> Source file `/home/incal/src/emacs/lisp/help-fns.el' newer than byte-compiled file; using older file
>   error("Failed awaiting: %s" "string: <alice> bob: Our queen and all"
>   (if inverted (setq inverted nil) (error "Failed awaiting: %s" (forma
>   (progn (if inverted (setq inverted nil) (error "Failed awaiting: %s"
>   (if (eq -with-timeout-value- 'timeout) (progn (if inverted (setq inv
>   (let ((-with-timeout-value- (catch 'timeout (let* ((-with-timeout-ti
>   (let ((time-out (abs timeout)) (inverted (< timeout 0)) (result 'res
>   (let ((ert--infos (cons (cons "Info: " (concat erc-d-t--wait-message
>   (let* ((rxp (consp text)) (fun (if rxp #'search-forward-regexp #'sea
>   (save-restriction (widen) (let* ((rxp (consp text)) (fun (if rxp #'s
>   erc-d-t-search-for(10 "<alice> bob: Our queen and all" #<marker in n
>   (let* ((pos (cdr (assq (current-buffer) positions))) (erc-d-t--wait-
>   (closure ((positions (#<killed buffer> . #<marker in no buffer>) (#<
>   funcall((closure ((positions (#<killed buffer> . #<marker in no buff
>   (save-current-buffer (set-buffer "#foo") (funcall expect 10 "<tester
>   (let ((ert--infos (cons (cons "Info: " "/AMSG only sent to issuing c
>   (progn (erc-scenarios-common--add-silence) (let ((ert--infos (cons (
>   (unwind-protect (progn (erc-scenarios-common--add-silence) (let ((er
>   (let* ((orig-autojoin-mode (and (boundp 'erc-autojoin-mode) erc-auto
>   (closure (t) nil (let* ((orig-autojoin-mode (and (boundp 'erc-autojo
>   #f(compiled-function () #<bytecode -0x199f34135bd6a333>)()
>   handler-bind-1(#f(compiled-function () #<bytecode -0x199f34135bd6a33
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name erc-scenarios-misc-commands--AMSG-GMS
>   ert-run-or-rerun-test(#s(ert--stats :selector erc-scenarios-misc-com
>   ert-run-tests(erc-scenarios-misc-commands--AMSG-GMSG-AME-GME #f(comp
>   ert-run-tests-batch(erc-scenarios-misc-commands--AMSG-GMSG-AME-GME)
>   ert-run-tests-batch-and-exit(erc-scenarios-misc-commands--AMSG-GMSG-
>   eval((ert-run-tests-batch-and-exit 'erc-scenarios-misc-commands--AMS
>   command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/erc/erc-scenarios-mi
>   command-line()
>   normal-top-level()
> Test erc-scenarios-misc-commands--AMSG-GMSG-AME-GME condition:
>     Info: /AMSG only sent to issuing context's server
>     Info: string: <alice> bob: Our queen and all
>     (error "Failed awaiting: string: <alice> bob: Our queen and all")
> Source file `/home/incal/src/emacs/lisp/vc/vc-git.el' newer than byte-compiled file; using older file
>    FAILED  1/1  erc-scenarios-misc-commands--AMSG-GMSG-AME-GME (10.450133 sec) at lisp/erc/erc-scenarios-misc-commands.el:133
>
> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-23 14:35:47+0100, 10.618589 sec)
>
> 1 unexpected results:
>    FAILED  erc-scenarios-misc-commands--AMSG-GMSG-AME-GME