From: "J.P." <jp@neverwas.me>
To: 68401@debbugs.gnu.org
Cc: emacs-erc@gnu.org
Subject: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt
Date: Tue, 23 Jan 2024 16:36:06 -0800 [thread overview]
Message-ID: <87bk9bh8jt.fsf__34675.6314321951$1706056632$gmane$org@neverwas.me> (raw)
In-Reply-To: <87le8gi3bn.fsf@dataswamp.org> (Emanuel Berg's message of "Tue, 23 Jan 2024 14:31:24 +0100")
Emanuel Berg <incal@dataswamp.org> writes:
> Tags: patch
>
> Here is a patch with the latest version.
>
> I'll run the unit test now.
>
>> From b4248461e88241cb81f64ea6c073dad82df8b48c Mon Sep 17 00:00:00 2001
> From: Emanuel Berg <incal@dataswamp.org>
> Date: Tue, 23 Jan 2024 14:21:49 +0100
> Subject: [PATCH] Make erc-cmd-AMSG session local; add /GMSG, /AME and /GME
>
> * lisp/erc/erc.el (erc-cmd-AMSG): Make it consistent with the doc
> string by only affecting the current connection.
> (erc-cmd-GMSG, erc-cmd-AME, erc-cmd-GME): new IRC slash commands
> (Bug#68401)
> ---
> lisp/erc/erc.el | 44 +++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 37 insertions(+), 7 deletions(-)
>
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> index 767a693a52e..e89733e7871 100644
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -4004,16 +4004,46 @@ erc--split-string-shell-cmd
> ;; Input commands handlers
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>
> -(defun erc-cmd-AMSG (line)
> - "Send LINE to all channels of the current server that you are on."
> - (interactive "sSend to all channels you're on: ")
> - (setq line (erc-trim-string line))
> +(defun erc--connected-and-joined-p ()
> + (and (erc--current-buffer-joined-p)
> + erc-server-connected))
I took your initial remarks advocating for a DRY helper and, in
particular, this bit about error-proneness
Okay, but instead of having these checks embedded and
hopefully correctly repeated four times, shouldn't we ...
to mean you wanted to factor out more than just a predicate, e.g., with
something like
(defun erc--run-in-joined-buffers (line-function line &optional proc)
(erc-with-all-buffers-of-server proc #'erc--connected-and-joined-p
(funcall line-function line)))
(Not that I think such a thing is needed.)
> +
> +(defun erc-cmd-GMSG (line)
> + "Send LINE to all channels on all networks you are on."
> + (setq line (string-remove-prefix " " line))
> (erc-with-all-buffers-of-server nil
> - (lambda ()
> - (erc-channel-p (erc-default-target)))
> - (erc-send-message line)))
> + (lambda () (erc-channel-p (erc-default-target)))
> + (when (erc--connected-and-joined-p)
> + (erc-send-message line))))
> +(put 'erc-cmd-GMSG 'do-not-parse-args t)
I don't understand the point of adding your purpose-built predicate
`erc--connected-and-joined-p' if you're not going to use it to replace
(lambda () (erc-channel-p (erc-default-target)))
completely. IOW, having both is redundant. If you're not already doing
so, please try expanding your macro use sites to verify correctness.
> +
> +(defun erc-cmd-AMSG (line)
> + "Send LINE to all channels of the current network.
> +Interactively, prompt for the line of text to send."
> + (interactive "sSend to all channels on this network: ")
> + (setq line (string-remove-prefix " " line))
> + (erc-with-all-buffers-of-server erc-server-process
> + (lambda () (erc-channel-p (erc-default-target)))
> + (when (erc--connected-and-joined-p)
> + (erc-send-message line))))
> (put 'erc-cmd-AMSG 'do-not-parse-args t)
>
> +(defun erc-cmd-GME (line)
> + "Send LINE as an action to all channels on all networks you are on."
> + (erc-with-all-buffers-of-server nil
> + (lambda () (erc-channel-p (erc-default-target)))
> + (when (erc--connected-and-joined-p)
> + (erc-cmd-ME line))))
> +(put 'erc-cmd-GME 'do-not-parse-args t)
> +
> +(defun erc-cmd-AME (line)
> + "Send LINE as an action to all channels on the current network."
> + (erc-with-all-buffers-of-server erc-server-process
> + (lambda () (erc-channel-p (erc-default-target)))
> + (when (erc--connected-and-joined-p)
> + (erc-cmd-ME line))))
> +(put 'erc-cmd-AME 'do-not-parse-args t)
> +
> (defun erc-cmd-SAY (line)
> "Send LINE to the current query or channel as a message, not a command.
>
> --
> 2.39.2
next prev parent reply other threads:[~2024-01-24 0:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87v87yvnly.fsf@dataswamp.org>
2024-01-12 12:08 ` bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt Eli Zaretskii
2024-01-12 14:12 ` Emanuel Berg
2024-01-12 14:39 ` Eli Zaretskii
2024-01-13 2:09 ` Emanuel Berg
2024-01-13 2:31 ` Emanuel Berg
2024-01-13 2:45 ` Emanuel Berg
2024-01-13 7:23 ` Eli Zaretskii
2024-01-14 9:11 ` Emanuel Berg
[not found] ` <834jfikb4d.fsf@gnu.org>
2024-01-12 12:36 ` Emanuel Berg
[not found] ` <87ply6vidl.fsf@dataswamp.org>
2024-01-12 14:03 ` Eli Zaretskii
2024-01-12 14:30 ` Emanuel Berg
[not found] ` <87mstavias.fsf@dataswamp.org>
[not found] ` <87wmseoskl.fsf@dataswamp.org>
2024-01-19 2:58 ` J.P.
2024-01-22 10:18 ` Emanuel Berg
2024-01-22 15:11 ` J.P.
2024-01-22 17:00 ` Emanuel Berg
2024-01-22 19:23 ` Emanuel Berg
[not found] ` <87y1ch851b.fsf@igel.home>
2024-01-22 21:05 ` Emanuel Berg
2024-01-22 21:27 ` J.P.
2024-01-23 4:25 ` Emanuel Berg
2024-01-23 4:32 ` Emanuel Berg
2024-01-23 6:20 ` Emanuel Berg
2024-01-23 13:31 ` Emanuel Berg
2024-01-24 0:36 ` J.P. [this message]
2024-01-24 0:56 ` Emanuel Berg
2024-01-24 1:38 ` J.P.
2024-01-24 2:01 ` Emanuel Berg
2024-01-23 13:42 ` Emanuel Berg
2024-01-24 0:34 ` J.P.
2024-01-24 1:28 ` Emanuel Berg
2024-01-24 1:38 ` Emanuel Berg
2024-01-24 11:15 ` Emanuel Berg
2024-01-24 11:55 ` Emanuel Berg
2024-02-05 0:52 ` Emanuel Berg
2024-02-06 3:44 ` J.P.
2024-02-11 1:58 ` Emanuel Berg
2024-02-11 2:27 ` Emanuel Berg
2024-02-11 3:30 ` Emanuel Berg
2024-02-11 3:52 ` Emanuel Berg
2024-02-14 1:42 ` J.P.
2024-02-17 5:21 ` Emanuel Berg
2024-02-17 8:52 ` Emanuel Berg
2024-02-21 1:11 ` J.P.
[not found] ` <87ttm2boza.fsf@neverwas.me>
2024-02-21 1:16 ` Emanuel Berg
2024-03-01 0:18 ` J.P.
2024-01-12 10:43 Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87bk9bh8jt.fsf__34675.6314321951$1706056632$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=68401@debbugs.gnu.org \
--cc=emacs-erc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.